From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F0802A04BB; Tue, 6 Oct 2020 14:01:42 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E1B0325B3; Tue, 6 Oct 2020 14:01:40 +0200 (CEST) Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68]) by dpdk.org (Postfix) with ESMTP id 4F9AB1C01 for <dev@dpdk.org>; Tue, 6 Oct 2020 14:01:38 +0200 (CEST) Received: by mail-io1-f68.google.com with SMTP id k6so12707454ior.2 for <dev@dpdk.org>; Tue, 06 Oct 2020 05:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8bm5yR15T2IbTnSmczS97zJMi5hTvhh9I1GdffN4w2Y=; b=Gb6Upr64l/cqHRYu3Uwkp6vMuCzTk5PJ7Cu6q414I9HMn6ApfHXquZ6F4l34+QsQTT wr+J0yIE/Hm/jF6omgroRICpygXIXODceS4FmZ0hdXA29p8NyJc/DuMP2l0xIQ9/MsTu 9jGD1TI4ffHHFg+y9FeK1uZ7sqnTCDoLg+pHTheA7zzgq51kwMRmRfZx/WiF/AF2Q41O +0o5Kx55O0z1I0Q/sxoEggBpGZ5fonmpZaGpEU0jY8GLG3H/rp8YPHP3p6jQGueuHMf5 xHJ9rntB3RzZ4KBEioRm72JvN8JRJHunWxNTQiKL2nm/sYq0z8RlsliRsxCP/ynQbx7Q ZUrg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8bm5yR15T2IbTnSmczS97zJMi5hTvhh9I1GdffN4w2Y=; b=Ae96YLlICSp7ia4v4pA4XAvWazoFIc1CGl7bKg+S37QVprtb3NzR6imDdMzvUy5J5C 0QUH8x/iGZZhDexpkKQIZN8PjHuT9rDY0W6RDNju74wM5TrercGhEahdNyttz8Neu/Zz POiYLT8BazDqa2z1hmbuBCAwIPk70NVKtN6ug2X3QPzLuVFPeVO5PgIR19XC8NEu+8n1 njU9TWsviXXnREkWoIZFlxsxPUjWDdCoV4PmBvijzoIKvhd3p2LeOTEz7jk8bO5YJKNj LsRsjOhzJhc5tg+miyXSdW8oRq5zdOfiTLI/cGlh+J/mE5zVkF3OPTCafMk/5o6yY2JA Lo5w== X-Gm-Message-State: AOAM531dthZW5qalGvJxX4PFXH6BhxqBRvbkUMvI5t5LL8wo4UJBbA1s 9ZtAQOmfATUPZKD/5uab4gLgpTHD7CvkscosI84= X-Google-Smtp-Source: ABdhPJyjsYCtQ1Qt2J2Vr/o3wnb1o3wCyds03f2QRcWPFmorLsDUv8S9Ra9S5SQhcifhhNR5Y6S070AYRU1BGVsOuFw= X-Received: by 2002:a5d:9e0c:: with SMTP id h12mr727424ioh.163.1601985697566; Tue, 06 Oct 2020 05:01:37 -0700 (PDT) MIME-Version: 1.0 References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201005071506.28861-1-nipun.gupta@nxp.com> <20201005083455.2fdf57f2@hermes.local> <CALBAE1OPphUyVC7n2W6KhufUMQBbCx_wO49ZqpVZTxWxQ46K4A@mail.gmail.com> <AM5PR0401MB2593D8A46BE35A269D5CB8F8E60D0@AM5PR0401MB2593.eurprd04.prod.outlook.com> In-Reply-To: <AM5PR0401MB2593D8A46BE35A269D5CB8F8E60D0@AM5PR0401MB2593.eurprd04.prod.outlook.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Tue, 6 Oct 2020 17:31:21 +0530 Message-ID: <CALBAE1O4bWaqDbdnEuqP2t8Lo4ow-oQ6suKHGPpc7jVBR_eR_Q@mail.gmail.com> To: Nipun Gupta <nipun.gupta@nxp.com> Cc: Stephen Hemminger <stephen@networkplumber.org>, dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <arybchenko@solarflare.com>, Hemant Agrawal <hemant.agrawal@nxp.com>, Sachin Saxena <sachin.saxena@nxp.com>, Rohit Raj <rohit.raj@nxp.com> Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Tue, Oct 6, 2020 at 4:07 PM Nipun Gupta <nipun.gupta@nxp.com> wrote: > > > > > -----Original Message----- > > From: Jerin Jacob <jerinjacobk@gmail.com> > > Sent: Monday, October 5, 2020 9:40 PM > > To: Stephen Hemminger <stephen@networkplumber.org> > > Cc: Nipun Gupta <nipun.gupta@nxp.com>; dpdk-dev <dev@dpdk.org>; Thomas > > Monjalon <thomas@monjalon.net>; Ferruh Yigit <ferruh.yigit@intel.com>; > > Andrew Rybchenko <arybchenko@solarflare.com>; Hemant Agrawal > > <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>; Rohit > > Raj <rohit.raj@nxp.com> > > Subject: Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error > > packets > > > > On Mon, Oct 5, 2020 at 9:05 PM Stephen Hemminger > > <stephen@networkplumber.org> wrote: > > > > > > On Mon, 5 Oct 2020 12:45:04 +0530 > > > nipun.gupta@nxp.com wrote: > > > > > > > From: Nipun Gupta <nipun.gupta@nxp.com> > > > > > > > > This change adds a RX offload capability, which once enabled, > > > > hardware will drop the packets in case there of any error in > > > > the packet such as L3 checksum error or L4 checksum. > > > > IMO, Providing additional support up to the level to choose the errors > > to drops give more control to the application. Meaning, > > L1 errors such as FCS error > > L2 errors .. > > L3 errors such checksum > > i.e ethdev spec need to have error level supported by PMD and the > > application can set the layers interested to drop. > > Agree, but 'DEV_RX_OFFLOAD_ERR_PKT_DROP' shall also be there to drop all the > error packets? Maybe we can rename it to DEV_RX_OFFLOAD_ALL_ERR_PKT_DROP. IMHO, we introduce such shortcut for a single flag for all err drop then we can not change the scheme without an API/ABI break. > > Currently we have not planned to add separate knobs for separate error in > the driver, maybe we can define them separately, or we need have them in > this series itself? I think, ethdev API can have the capability on what are levels it supported, in your driver case, you can express the same. > > > > > > > > > > > Signed-off-by: Nipun Gupta <nipun.gupta@nxp.com> > > > > Signed-off-by: Rohit Raj <rohit.raj@nxp.com> > > > > --- > > > > These patches are based over series: > > > > > > https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwo > > rk.dpdk.org%2Fpatch%2F78630%2F&data=02%7C01%7Cnipun.gupta%40nx > > p.com%7C90b516fd465c48945e7008d869492b3e%7C686ea1d3bc2b4c6fa92cd9 > > 9c5c301635%7C0%7C0%7C637375110263097933&sdata=RBQswMBsfpM6 > > nyKur%2FaHvOMvNK7RU%2BRyhHt%2FXBsP1OM%3D&reserved=0 > > > > > > > > Changes in v2: > > > > - Add support in DPAA1 driver (patch 2/3) > > > > - Add support and config parameter in testpmd (patch 3/3) > > > > > > > > lib/librte_ethdev/rte_ethdev.h | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > Maybe this should be an rte_flow match/action which would then make it > > > more flexible? > > > > I think, it is not based on any Patten matching. So IMO, it should be best if it > > is part of RX offload. > > > > > > > > There is not much of a performance gain for this in real life and > > > if only one driver supports it then I am not convinced this is needed. > > > > Marvell HW has this feature.