From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 779F6A00C3; Wed, 15 Jun 2022 20:11:43 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 29425427EB; Wed, 15 Jun 2022 20:11:43 +0200 (CEST) Received: from mail-qv1-f52.google.com (mail-qv1-f52.google.com [209.85.219.52]) by mails.dpdk.org (Postfix) with ESMTP id 08BFC410D0 for ; Wed, 15 Jun 2022 20:11:42 +0200 (CEST) Received: by mail-qv1-f52.google.com with SMTP id v12so2832886qvh.9 for ; Wed, 15 Jun 2022 11:11:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xAhyo1SVgYOIvlkJTIisNyEM+YJX+J/i/kqfibEBYqs=; b=X7ptMr1Oe31j+0XnfAxtCNlp157wkx2I1phtTDCU8YtpEJjpyWzeOEjj4oqKglHWBn 7G+/mJU6KOWYgyiH9Q1jg9TLXCWZQKqRX3d5UwFf0n78X6sfnA4FfVwyC/IfuGqpGOE3 WIS8vwDerQz4q/087xtCs4npR0wRS2Rh0OfcCd0hqmWgU7Y4yG0dIqWbCbvPcSVpADwo fr0yVqFNe7BJzlFvDL/k0NtiQrMyd2nsqLkPdU/igt7R2sdk736azHUoxnY1TFpKeCW6 y05yt/xf6YQi7mo8fu7Fh/eIqOacBGqR3U/gcEg+Si6MHWx8BGk6VghVSx6uO2GGVzN6 ZC8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xAhyo1SVgYOIvlkJTIisNyEM+YJX+J/i/kqfibEBYqs=; b=bkGBkHABjiyX8V4vtr9DQHULVZ4xpwqyDyLPbuLkN5bTzLkft6MvH9QWMjTEIKyeGy Uhnpfhze+dfOB7r48Izy0If3V1TWrOnCXRYwOmwTLxfPqAZjJ2mu3iDgop4E7lJbEjiZ oJ/AjerKdWTNI7R/GNx7D/hXKtEsa8s+CpD7VjXCmoOq6EfRcO9Sr8N1xehqdwnSMRpz HO8m6P623tYLOoQqiUAG9XvFJIwpOfvm6xOS2i3IJfOyDJ4WwB4VdydgIbt3rmNrXz4V qAJbzwW3X9YfSExVvnrd9Cw67xpqli/bVFr+LdKAJY0kaJYo28Afb8CNF2YSyO0GPrdE EgiQ== X-Gm-Message-State: AJIora85h0LDkXDCM2O5DFiZrXgAR+8fuDHBdTvDTXzcxHOHEZyIRP0h z12rNpFZ3Z1f7GRfxrk4UI37zksYf7Tg8b1NOKg= X-Google-Smtp-Source: AGRyM1vDpuwnq7rf/IHaCJYqHJSJ4etkug5m7Fnovsx1pp2kalnujdFC9SfDnLPNrqnIErp2WYZorPhhA6WcZPSphGc= X-Received: by 2002:ad4:594d:0:b0:46b:afcf:fb67 with SMTP id eo13-20020ad4594d000000b0046bafcffb67mr798308qvb.11.1655316701256; Wed, 15 Jun 2022 11:11:41 -0700 (PDT) MIME-Version: 1.0 References: <20220607120014.49823-1-fengchengwen@huawei.com> <20220614055900.22848-1-fengchengwen@huawei.com> <20220614055900.22848-3-fengchengwen@huawei.com> In-Reply-To: From: Jerin Jacob Date: Wed, 15 Jun 2022 23:41:15 +0530 Message-ID: Subject: Re: [PATCH v2 2/3] eal: fix trace init fail with long file-prefix To: David Marchand Cc: Chengwen Feng , Thomas Monjalon , dev , "Burakov, Anatoly" , Jerin Jacob Kollanukkaran , Bruce Richardson Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Jun 15, 2022 at 7:32 PM David Marchand wrote: > > On Tue, Jun 14, 2022 at 8:06 AM Chengwen Feng wrote: > > > > Bug scenario: > > 1. start testpmd: > > dpdk-testpmd -l 4-6 -a 0000:7d:00.0 --trace=.* \ > > -file-prefix=trace_autotest -- -i > > 2. then observed: > > EAL: eal_trace_init():94 failed to initialize trace [File exists] > > This is not directly related to the issue being fixed, but this error > log is really obscure.. > Can we enhance this, maybe in a followup patch? > > > > EAL: FATAL: Cannot init trace > > EAL: Cannot init trace > > EAL: Error - exiting with code: 1 > > > > The root cause it that the offset set wrong with long file-prefix and > > then lead the strftime return failed. > > > > Fixes: 321dd5f8fa62 ("trace: add internal init and fini interface") > > Cc: stable@dpdk.org > > > > Signed-off-by: Chengwen Feng > > Reviewed-by: David Marchand Acked-by: Jerin Jacob