From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AB8F3A0524; Tue, 13 Apr 2021 10:55:01 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 94D6E160CED; Tue, 13 Apr 2021 10:55:01 +0200 (CEST) Received: from mail-il1-f179.google.com (mail-il1-f179.google.com [209.85.166.179]) by mails.dpdk.org (Postfix) with ESMTP id 90419160CE4; Tue, 13 Apr 2021 10:54:59 +0200 (CEST) Received: by mail-il1-f179.google.com with SMTP id c3so7358641ils.5; Tue, 13 Apr 2021 01:54:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VxEsct7qw+ErjWN77bm9KKPCRcjueZmxXeb5tcotVkM=; b=GHc7q6wp0JoaRRqhc3DfEVGPb4IUdeZMrTRa0Nnz2ZkDfwZutC3v3h5x2l7VCwWKYz kE7CGP2AH0gWIYkKsEomT4FgVCRL0mCOo4SzKMb8vWH/wRhcuqprT/WROg6aC9efz9Zw L2lYQYQZya4cVYJv2E5gSwMj7EwZzvaqEYHasS37h6LWpuQvGKba4+OcgypgfUbX/Ukh DtwXQpOOQD05HoCZmDMMbMZoVNwPB0FwX0CyBqRB9SLES1dS16E4C9iV/l5QcRFL5ljv nK2BOiqPJY0zbdIRPjvLlXfTekP1nkrMqgVp4MzX0o2ZOsnlVfkGbyDnb4ggow0gdxCJ CxaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VxEsct7qw+ErjWN77bm9KKPCRcjueZmxXeb5tcotVkM=; b=eN/Rsba2soyTO9GxbKzksnpOuNtixX7gXp7/JDq4nnBV4vTbpsvqwATjNMGAlgfEA0 in6ewbeVLcSeXxh6+VpNkVvrj4CApjlFfetB4N2VXzqOLrxDZ0EuB4lNHpiDtInPhY+N xPVf5uDZiJ42+L95wwW62SvvdeghE6vKwXzadjQuVkdku3S+uTRziqlJO+lBWYvhWV6g NUOW2yl6T/uuTY06pe00Y3560hdYBxKQeEVNdcvoX6v4Lhs+hudAPk0WFOf0Z5Xp6yNe UctDCqwlDM5SxYZlKDwjKBaen0gaxuXjXC05vpJNi4iuWbsQLtTgWioQJ5xDf2stqUzz B24Q== X-Gm-Message-State: AOAM530lk8i+9ag85EAuZTtfO91UAwwBmpZnhoQQYlKfq+2u6DHEgY6/ yfq/iMtwXWO+BX827FxCbvtzUjrp+Jlq20M3JKg= X-Google-Smtp-Source: ABdhPJw4jHi4IBlhl7QPAqGHkFBZvLw7reAveb9qj/eAZpLVcuziPxh08Z77fNAgjdi99MfvYD5JgqwOwDWt7uFZOh0= X-Received: by 2002:a92:c26a:: with SMTP id h10mr7214896ild.294.1618304099018; Tue, 13 Apr 2021 01:54:59 -0700 (PDT) MIME-Version: 1.0 References: <3565653.Ar8n8QqFrN@thomas> In-Reply-To: From: Jerin Jacob Date: Tue, 13 Apr 2021 14:24:43 +0530 Message-ID: To: David Marchand Cc: Thomas Monjalon , Timothy McDaniel , Jerin Jacob Kollanukkaran , Ray Kinsella , Aaron Conole , dpdklab , "abhinandan.gujjar@intel.com" , "harry.van.haaren@intel.com" , dev , Shijith Thotton , Akhil Goyal , Pavan Nikhilesh Bhagavatula , "mattias.ronnblom@ericsson.com" , ci@dpdk.org Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [pull-request] dpdk-next-net-eventdev - 21.05 - PRE-RC1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Apr 13, 2021 at 12:46 PM David Marchand wrote: > > On Tue, Apr 13, 2021 at 12:12 AM Thomas Monjalon wrote: > > > > 12/04/2021 15:20, Jerin Jacob Kollanukkaran: > > > http://dpdk.org/git/next/dpdk-next-eventdev > > > > Pulled, thanks. > > > > Note few changes in titles like uppercases for acronyms, > > or "add support" simplified as "support", > > and release notes moved in the right place. > > The ABI check now reports an error on event/dlb. > The reason is that the event/dlb driver has been removed, and so the > check complains about a missing dump. > This will have to be fixed quickly or reverted. > > > This has been missed by multiple people, so trying to understand why. I was running the following script[1] to detect ABI issues. Since the "./devtools/test-meson-builds.sh" did not return non zero value or the error print was "Error: cannot find librte_event_dlb.dump", It is missed from my side. @David Marchand @Thomas Monjalon Could you share the snippet you are using for detecting the ABI issue. ------------------------ # ABI check DPDK_ABI_REF_VERSION=v20.11 DPDK_ABI_REF_DIR=/tmp bash ./devtools/test-meson-builds.sh 1> /tmp/build.log 2> /tmp/build.log if [ $? -ne 0 ]; then echo "ABI check failed" exit fi grep "Error: ABI issue reported" /tmp/build.log if [ $? -eq 0 ]; then echo "ABI issue" exit fi ------------------------------------------------------- > > The ABI check should have caught this when run by maintainers (/me > looks at Thomas and Jerin). Sorry for that :-(