From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1A454318E; Tue, 17 Oct 2023 18:04:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8E8FC40273; Tue, 17 Oct 2023 18:04:32 +0200 (CEST) Received: from mail-qt1-f170.google.com (mail-qt1-f170.google.com [209.85.160.170]) by mails.dpdk.org (Postfix) with ESMTP id 763D940270 for ; Tue, 17 Oct 2023 18:04:31 +0200 (CEST) Received: by mail-qt1-f170.google.com with SMTP id d75a77b69052e-41cba6e8e65so155241cf.2 for ; Tue, 17 Oct 2023 09:04:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1697558671; x=1698163471; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=WzJF+/redeluVhICOqPzmIDBSFGooIfsDgIUaV3zOzU=; b=U55tp5bhuMEksFvsrAaPNN8ZVHLTwJqy4NwsGubDLe0qkcuRO3Lxo/WWkM8PcSHdWV lIY+nWmMDhIKYkTuOcYpp2aU0V3PmEL35SOPwU83xgbssNRr01qJPUUAcB3MepuLZZq6 Bhiir2750HALmp2g3z0Ywe2PwMd0pWTi7dayJVU2eIhD8up2lemtypmCgB8hBU2Wd78z JznVeto/bxDO1jY1nN5PtrM9FHUXHaCazzOBbcuUu9K23gxaA/THm1EdHBnZylp3TeCH H01lB4lKAKcpRXg/Ld+FZDt48dZeKQvIG6t+ztt1ILi+l6pNuevrZrtiwzbJE4DeeCLR fLeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1697558671; x=1698163471; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WzJF+/redeluVhICOqPzmIDBSFGooIfsDgIUaV3zOzU=; b=KuZ2M3BZwcQw/Y4z8UntPfoWX8vCDdVPd28X6AIjg0I8x7Wya5Zz5WRojGwL0YOyPe +x8nil2rRs4LnJNXJfUHdrRdQik2LNnnFNVlK/tRFnQJByJ8cr8GQGnYQd2rLWJEg7Ul mkO9mHHA56V0w605cvgts4mQ5ZMc4CU7tOXuqO6dNrHFWHOW8vWPZ4q8IvCsNhPCwsxj HVEBW8qa0Wl50y7KIs80+nHVuhk/hZPU7vmvGINDwduhMkSSo7Q3aY5fPcvwBfppAj6k YzIGdzTO+mXpEljVuHpqJVBZAaLAggde1D825RJ7febRAqmYy6FvqsOxxugedXPLaLsv x6Lg== X-Gm-Message-State: AOJu0YzSyBdaS+5AiVdP6Y/S0uzWcOLPiUcHrFzxfisRczddXRwH6BFZ bW1CUxwpJVuViKTT2PYudLiJOK97BfKepWH4HW/bxc6f9zE= X-Google-Smtp-Source: AGHT+IGSTqMOEtXNWZYnWfxCFqDV1jWLGsAybQ8WE4Wz2YgmOMuZVw338H1xgds0e6DBoV9HHqVgOhNY5SXVO8K5nZc= X-Received: by 2002:ac8:5901:0:b0:417:8eb5:2780 with SMTP id 1-20020ac85901000000b004178eb52780mr2987456qty.18.1697558670587; Tue, 17 Oct 2023 09:04:30 -0700 (PDT) MIME-Version: 1.0 References: <20231017154532.152741-1-bruce.richardson@intel.com> In-Reply-To: <20231017154532.152741-1-bruce.richardson@intel.com> From: Jerin Jacob Date: Tue, 17 Oct 2023 21:34:04 +0530 Message-ID: Subject: Re: [PATCH] event/dsw: fix missing device pointer To: Bruce Richardson Cc: dev@dpdk.org, mattias.ronnblom@ericsson.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 17, 2023 at 9:32=E2=80=AFPM Bruce Richardson wrote: > > After calling rte_event_dev_info_get() the ".dev" field of the info > structure should have a pointer to the underlying device, allowing the > user to e.g. get the device name using using rte_dev_name(info.dev). > > The distributed software eventdev info structure did not return a > correct device pointer, though, instead returning NULL, which caused > crashes getting "rte_dev_name". Initializing the dev pointer inside the > "eventdev" struct in the device probe function fixes this by ensuring we > have a valid pointer to return in info_get calls. > > Fixes: 46a186b1f0c5 ("event/dsw: add device registration and build system= ") > Cc: mattias.ronnblom@ericsson.com > > Signed-off-by: Bruce Richardson Is this issue for all "vdev" devices? if so, Please check for drivers/event/skeleton too. > --- > drivers/event/dsw/dsw_evdev.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/event/dsw/dsw_evdev.c b/drivers/event/dsw/dsw_evdev.= c > index 785c12f61f..44da3c60d1 100644 > --- a/drivers/event/dsw/dsw_evdev.c > +++ b/drivers/event/dsw/dsw_evdev.c > @@ -440,6 +440,7 @@ dsw_probe(struct rte_vdev_device *vdev) > return -EFAULT; > > dev->dev_ops =3D &dsw_evdev_ops; > + dev->dev =3D &vdev->device; > dev->enqueue =3D dsw_event_enqueue; > dev->enqueue_burst =3D dsw_event_enqueue_burst; > dev->enqueue_new_burst =3D dsw_event_enqueue_new_burst; > -- > 2.39.2 >