From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B40AA034F; Wed, 13 May 2020 14:36:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 459E31D584; Wed, 13 May 2020 14:36:37 +0200 (CEST) Received: from mail-io1-f66.google.com (mail-io1-f66.google.com [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 868D51D582 for ; Wed, 13 May 2020 14:36:35 +0200 (CEST) Received: by mail-io1-f66.google.com with SMTP id 79so8634348iou.2 for ; Wed, 13 May 2020 05:36:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=jTPfFudlbLIB7do+03Xvu27x0nWOPEssECEHnOSdgA0=; b=AdMkQ76US7SCXLcrZK1uVpppFcPJkgqwKNLwR/+5H+51G2LTs12WU4seIUvYIx6D0e Jbl5FM8zAcWVKUkAa7TcDswfPpTXyy/Hu2Z95DuzuuMYbx/juMkcH8yADk5T9feZzgHR ThDgcHojJuMw4V694zQIqZNCwNJhis4s/qvQRXKoCOHZ9BBqiUQ66LHYt2q0hoChgFb5 GM+9kjiMl41Arch2mAnZ9rhsFH9S36AMnLKHUtxoiv0SdqOS6peWlqsrZXjjjphDECuO yGXXLdINaZaK8IJtEdDOF4LVXL+OXmtu0htLx0MExX7prYZxs/2/E+XYPDQXLtTkjvZC N9JQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=jTPfFudlbLIB7do+03Xvu27x0nWOPEssECEHnOSdgA0=; b=QLbBMcvCikOfFp+oIgJhw0NaVEvpgsnpqGheuIzCiNIKXcbVr2nOyUj7IB3ES4fl8T +34GvBvUWTJVpz0xD1eX6Ri6H2zaE6z6+BpTw5XbzaMzMcDjiIYLSpET3VurSS4VUgB+ oTGoukNXLwlin1A5NgL2Ui2OhnoxWIuHCUuzzX/P9CuHpYASgchf73cAzFgh1TxVZwXv 3xVcfWUiv3zuq2Cu/Us2igkGAo+TAoFO+01f93XYXFw3NCclzZe/Yb33NOGrjbwdgJmp hzLkfhxN9QSCc3JtTL8/szepzZth1kBqG+qgOu9y7Ls0iKr9TaNDJ3nKQfeRG3bwi3pe 5zGg== X-Gm-Message-State: AGi0Pub1f7xaKNC7sj3miXsfgR+82rw6kmeYff/Cb5R5wiuywBQYE5Pr sq4ejCkRlzIfddQUaRhJAI3E7Xr/aojwPi+hFPw= X-Google-Smtp-Source: APiQypKZjwQrkPMSPxiEcp0cbP3joU2x/3ENIINldS05vjffjD6uBewmv7AyEaiDhZ8SczsyBv2DzfTM+zwkt9SKtGI= X-Received: by 2002:a02:9a0d:: with SMTP id b13mr24984271jal.60.1589373394655; Wed, 13 May 2020 05:36:34 -0700 (PDT) MIME-Version: 1.0 References: <20200513054816.18848-1-ndabilpuram@marvell.com> <20200513120605.28912-1-ndabilpuram@marvell.com> In-Reply-To: <20200513120605.28912-1-ndabilpuram@marvell.com> From: Jerin Jacob Date: Wed, 13 May 2020 18:06:18 +0530 Message-ID: To: Nithin Dabilpuram Cc: Kiran Kumar K , Jerin Jacob , David Marchand , Pavan Nikhilesh , dpdk-dev , "Ruifeng Wang (Arm Technology China)" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] node: fix arm64 build issue for older gcc X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 13, 2020 at 5:36 PM Nithin Dabilpuram wrote: > > Older GCC(~4) complains about uninitialized 'dip' > var though all the lanes of the vec register are set. > Hence this patch explicitly initializes vec register > to fix the issue. > > In file included from ip4_lookup.c:34:0: > ip4_lookup_neon.h: n function =E2=80=98ip4_lookup_node_process=E2=80=99: = \ > ip4_lookup_neon.h:25:12: error: =E2=80=98dip=E2=80=99 may be used uniniti= alized in \ > this function [-Werror=3Dmaybe-uninitiali= zed] > int32x4_t dip; > ^ > > Fixes: 16df6a2c6671 ("node: add IPv4 lookup for arm64") > Reported-by: David Marchand > Signed-off-by: Nithin Dabilpuram > Reviewed-by: Ruifeng Wang It is a false positive, all the lines are updated by the c code. Just to make the old compiler to happy we need to add unnecessary additional instruction. Looks like there is no other clean way to suppress the warning. Reviewed-by: Jerin Jacob > --- > v2: > - Add error in commit msg. > > lib/librte_node/ip4_lookup_neon.h | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/lib/librte_node/ip4_lookup_neon.h b/lib/librte_node/ip4_look= up_neon.h > index bb3150f..dd21cb2 100644 > --- a/lib/librte_node/ip4_lookup_neon.h > +++ b/lib/librte_node/ip4_lookup_neon.h > @@ -45,6 +45,7 @@ ip4_lookup_node_process(struct rte_graph *graph, struct= rte_node *node, > rte_prefetch0(rte_pktmbuf_mtod_offset(pkts[i], void *, > sizeof(struct rte_ether_h= dr))); > > + dip =3D vdupq_n_s32(0); > /* Get stream for the speculated next node */ > to_next =3D rte_node_next_stream_get(graph, node, next_index, nb_= objs); > while (n_left_from >=3D 4) { > -- > 2.8.4 >