DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Olivier Matz <olivier.matz@6wind.com>
Cc: dev@dpdk.org, "Harry van Haaren" <harry.van.haaren@intel.com>,
	"Bruce Richardson" <bruce.richardson@intel.com>,
	"David Hunt" <david.hunt@intel.com>,
	"Anatoly Burakov" <anatoly.burakov@intel.com>,
	"Morten Brørup" <mb@smartsharesystems.com>,
	"Andrew Rybchenko" <andrew.rybchenko@oktetlabs.ru>,
	stable@dpdk.org
Subject: Re: [PATCH 2/2] event/sw: fix invalid log in selftest
Date: Wed, 19 Oct 2022 19:37:08 +0530	[thread overview]
Message-ID: <CALBAE1O9CQifwqzvaAaVE+hU6ByHJQZr0sLOyRH3E18Vni0_rg@mail.gmail.com> (raw)
In-Reply-To: <20221014203710.6172-2-olivier.matz@6wind.com>

On Sat, Oct 15, 2022 at 2:08 AM Olivier Matz <olivier.matz@6wind.com> wrote:
>
> The log should display the value, not the id.
>
> Fixes: e21df4b062b5 ("test/eventdev: add SW xstats tests")
> Cc: stable@dpdk.org
>
> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>
> ---
>  drivers/event/sw/sw_evdev_selftest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/event/sw/sw_evdev_selftest.c b/drivers/event/sw/sw_evdev_selftest.c
> index 4f18d66f36..834681dbec 100644
> --- a/drivers/event/sw/sw_evdev_selftest.c
> +++ b/drivers/event/sw/sw_evdev_selftest.c
> @@ -1644,8 +1644,8 @@ xstats_id_reset_tests(struct test *t)
>                 }
>                 if (val != port_expected[i]) {
>                         printf("%d: %s value incorrect, expected %"PRIu64
> -                               " got %d\n", __LINE__, port_names[i],
> -                               port_expected[i], id);
> +                               " got %"PRIu64"\n", __LINE__, port_names[i],

There was merge conflict due to "eventdev: increase xstats ID width to 64 bits".
I have fixed and Series applied to dpdk-next-net-eventdev/for-main. Thanks



> +                               port_expected[i], val);
>                         failed = 1;
>                 }
>                 /* reset to zero */
> --
> 2.30.2
>

  reply	other threads:[~2022-10-19 14:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-10-14 20:37 [PATCH 1/2] event/sw: fix missing flow ID init " Olivier Matz
2022-10-14 20:37 ` [PATCH 2/2] event/sw: fix invalid log " Olivier Matz
2022-10-19 14:07   ` Jerin Jacob [this message]
2022-10-15  8:25 ` [PATCH 1/2] event/sw: fix missing flow ID init " Morten Brørup
2022-10-17  7:30 ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1O9CQifwqzvaAaVE+hU6ByHJQZr0sLOyRH3E18Vni0_rg@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=anatoly.burakov@intel.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=david.hunt@intel.com \
    --cc=dev@dpdk.org \
    --cc=harry.van.haaren@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=olivier.matz@6wind.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).