Add QLogic vendor id support for BCM57840 device ids. Fixes: 9fb557035d90 ("bnx2x: enable PMD build") Cc: stable@dpdk.org Reported-by: Souvik Dey <sodey@rbbn.com> Signed-off-by: Rasesh Mody <rmody@marvell.com> --- drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c index 40225b2f4..ce9df8748 100644 --- a/drivers/net/bnx2x/bnx2x_ethdev.c +++ b/drivers/net/bnx2x/bnx2x_ethdev.c @@ -17,6 +17,7 @@ * The set of PCI devices this driver supports */ #define BROADCOM_PCI_VENDOR_ID 0x14E4 +#define QLOGIC_PCI_VENDOR_ID 0x1077 static const struct rte_pci_id pci_id_bnx2x_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) }, @@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, #endif { .vendor_id = 0, } }; @@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, { .vendor_id = 0, } }; -- 2.18.0
On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody <rmody@marvell.com> wrote: > > Add QLogic vendor id support for BCM57840 device ids. > > Fixes: 9fb557035d90 ("bnx2x: enable PMD build") > Cc: stable@dpdk.org > > Reported-by: Souvik Dey <sodey@rbbn.com> > Signed-off-by: Rasesh Mody <rmody@marvell.com> There was an error from CI on Broadcom CI, Since this patch is about Broadcom PMD fix, Do we need to worry about this? http://mails.dpdk.org/archives/test-report/2020-October/158246.html > --- > drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > index 40225b2f4..ce9df8748 100644 > --- a/drivers/net/bnx2x/bnx2x_ethdev.c > +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > @@ -17,6 +17,7 @@ > * The set of PCI devices this driver supports > */ > #define BROADCOM_PCI_VENDOR_ID 0x14E4 > +#define QLOGIC_PCI_VENDOR_ID 0x1077 > static const struct rte_pci_id pci_id_bnx2x_map[] = { > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) }, > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) }, > @@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, > #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > #endif > { .vendor_id = 0, } > }; > @@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, > { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > { .vendor_id = 0, } > }; > > -- > 2.18.0 >
On 10/13/2020 7:28 PM, Jerin Jacob wrote: > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody <rmody@marvell.com> wrote: >> >> Add QLogic vendor id support for BCM57840 device ids. >> >> Fixes: 9fb557035d90 ("bnx2x: enable PMD build") >> Cc: stable@dpdk.org >> >> Reported-by: Souvik Dey <sodey@rbbn.com> >> Signed-off-by: Rasesh Mody <rmody@marvell.com> > > > There was an error from CI on Broadcom CI, > Since this patch is about Broadcom PMD fix, Do we need to worry about this? > http://mails.dpdk.org/archives/test-report/2020-October/158246.html > Errors shouldn't be related to this patch, so I think error can be ignored for this patch. But added Ajit & lab for the issue. > >> --- >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c >> index 40225b2f4..ce9df8748 100644 >> --- a/drivers/net/bnx2x/bnx2x_ethdev.c >> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c >> @@ -17,6 +17,7 @@ >> * The set of PCI devices this driver supports >> */ >> #define BROADCOM_PCI_VENDOR_ID 0x14E4 >> +#define QLOGIC_PCI_VENDOR_ID 0x1077 >> static const struct rte_pci_id pci_id_bnx2x_map[] = { >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) }, >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) }, >> @@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, >> #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, >> #endif >> { .vendor_id = 0, } >> }; >> @@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, >> { .vendor_id = 0, } >> }; >> >> -- >> 2.18.0 >>
On Tue, Oct 13, 2020 at 1:43 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > On 10/13/2020 7:28 PM, Jerin Jacob wrote: > > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody <rmody@marvell.com> wrote: > >> > >> Add QLogic vendor id support for BCM57840 device ids. > >> > >> Fixes: 9fb557035d90 ("bnx2x: enable PMD build") > >> Cc: stable@dpdk.org > >> > >> Reported-by: Souvik Dey <sodey@rbbn.com> > >> Signed-off-by: Rasesh Mody <rmody@marvell.com> > > > > > > There was an error from CI on Broadcom CI, > > Since this patch is about Broadcom PMD fix, Do we need to worry about this? > > http://mails.dpdk.org/archives/test-report/2020-October/158246.html > > > > Errors shouldn't be related to this patch, so I think error can be ignored for > this patch. +1 > > But added Ajit & lab for the issue. I have seen this behavior earlier. It showed up randomly on some patches which are not even related to Broadcom PMD. I will try to keep an eye on it. > > > > >> --- > >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > >> index 40225b2f4..ce9df8748 100644 > >> --- a/drivers/net/bnx2x/bnx2x_ethdev.c > >> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > >> @@ -17,6 +17,7 @@ > >> * The set of PCI devices this driver supports > >> */ > >> #define BROADCOM_PCI_VENDOR_ID 0x14E4 > >> +#define QLOGIC_PCI_VENDOR_ID 0x1077 > >> static const struct rte_pci_id pci_id_bnx2x_map[] = { > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) }, > >> @@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, > >> #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > >> #endif > >> { .vendor_id = 0, } > >> }; > >> @@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > >> { .vendor_id = 0, } > >> }; > >> > >> -- > >> 2.18.0 > >> >
On Wed, Oct 14, 2020 at 3:07 AM Ajit Khaparde <ajit.khaparde@broadcom.com> wrote: > > On Tue, Oct 13, 2020 at 1:43 PM Ferruh Yigit <ferruh.yigit@intel.com> wrote: > > > > On 10/13/2020 7:28 PM, Jerin Jacob wrote: > > > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody <rmody@marvell.com> wrote: > > >> > > >> Add QLogic vendor id support for BCM57840 device ids. > > >> > > >> Fixes: 9fb557035d90 ("bnx2x: enable PMD build") > > >> Cc: stable@dpdk.org > > >> > > >> Reported-by: Souvik Dey <sodey@rbbn.com> > > >> Signed-off-by: Rasesh Mody <rmody@marvell.com> > > > > > > > > > There was an error from CI on Broadcom CI, > > > Since this patch is about Broadcom PMD fix, Do we need to worry about this? > > > http://mails.dpdk.org/archives/test-report/2020-October/158246.html > > > > > > > Errors shouldn't be related to this patch, so I think error can be ignored for > > this patch. > +1 > > > > > But added Ajit & lab for the issue. > I have seen this behavior earlier. > It showed up randomly on some patches which are not even > related to Broadcom PMD. I will try to keep an eye on it. Applied to dpdk-next-net-mrvl/for-main. Thanks > > > > > > > > >> --- > > >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ > > >> 1 file changed, 4 insertions(+) > > >> > > >> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > > >> index 40225b2f4..ce9df8748 100644 > > >> --- a/drivers/net/bnx2x/bnx2x_ethdev.c > > >> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > > >> @@ -17,6 +17,7 @@ > > >> * The set of PCI devices this driver supports > > >> */ > > >> #define BROADCOM_PCI_VENDOR_ID 0x14E4 > > >> +#define QLOGIC_PCI_VENDOR_ID 0x1077 > > >> static const struct rte_pci_id pci_id_bnx2x_map[] = { > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) }, > > >> @@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, > > >> #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > > >> #endif > > >> { .vendor_id = 0, } > > >> }; > > >> @@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, > > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > > >> { .vendor_id = 0, } > > >> }; > > >> > > >> -- > > >> 2.18.0 > > >> > >