From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id C0D7FA2F18
	for <public@inbox.dpdk.org>; Thu,  3 Oct 2019 08:30:53 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 8AEE01BFC6;
	Thu,  3 Oct 2019 08:30:53 +0200 (CEST)
Received: from mail-io1-f66.google.com (mail-io1-f66.google.com
 [209.85.166.66]) by dpdk.org (Postfix) with ESMTP id 936C61BFC6
 for <dev@dpdk.org>; Thu,  3 Oct 2019 08:30:51 +0200 (CEST)
Received: by mail-io1-f66.google.com with SMTP id c25so2860524iot.12
 for <dev@dpdk.org>; Wed, 02 Oct 2019 23:30:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=F+LQzOBkwDavyBpi0A/KUeLgwEQ0FFl1aM/1BoljNuI=;
 b=bRsRYOj07Ei5rzQDgvUgfIhOhXlGvfIXh8WdznV2sAf+WoceEbfNc6zkWcaNovK03r
 JJyDcZyUOZ7tiSP/DZBdhda/MXtRdxOcL+ILyPwugT8DGViqfV7SSyHMQncw4DZJkJXB
 uf9NmaC0Rv2+owUXx8dpRqQ9T2XejJPGLxZ5sF7MF2dIlOqD4NnGB086j5P7nROoGNBv
 3kSI62STtD5hRLc2FUsxUhCEVMwANdpVWQIJsGssqdUQIgGSzdzy2UV2cTKOPaJMmhPQ
 lxVDNdc7s56zPKXyBe4wi+H3eSVIzIOJef53b5pkAN7gCJDmZg0MWRchAE12DMhl0KK3
 D4tg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=F+LQzOBkwDavyBpi0A/KUeLgwEQ0FFl1aM/1BoljNuI=;
 b=FaHcZqLsGULG2Asnbl9ECcAUSy9HTQalgVQOl1+k4p9M/7ngTAmwzsPHQNMaGAHWUP
 98+cs+L4BDSz+c/KkvhWOq7YsvAKg+YCVsm6+AEWB0KMWlx4/He/ipyx6LVjY7JonQZP
 kwBVwvozctlyQv5gHLwvZ5zu61/zEdxFN9EB34JduIiFPG4fgEoaE0mlMyaFZ2ObkmyU
 qKJVkMmoGrIogxdIMuHrew1RmTgWKrEXvhotvsFdERYqg3BCqQ6Iawb2oqpcoLwm9Ej/
 VvgzVrpkk/wz2dkArwEwkEdqYeHTrbZx3dE1Z7D5A97yxIYLpoYeZ/rX66TxaCBfn2kU
 0VtQ==
X-Gm-Message-State: APjAAAWio5nvpeCfpR1FpP/xmDH2CkAygFliJxDSxwrPZt35oUyVmtK+
 IAWtQc7rT/OOXdy2bhagYtAtXrfaEb26U9LwL1s=
X-Google-Smtp-Source: APXvYqwZcL3jBWc8zgfPyiZ3m0X1OsA0BRZzhCV52KNIsRiW/kJep+u3Gv3lqASNi6sGvpE0u46HmKJt7ZyUtksI/dw=
X-Received: by 2002:a02:9009:: with SMTP id w9mr7914530jaf.112.1570084250746; 
 Wed, 02 Oct 2019 23:30:50 -0700 (PDT)
MIME-Version: 1.0
References: <52364461.s3POrlgOHr@xps>
 <CAJFAV8yyA6xa9EnwY2c7cnXRTBUsWSc=Nf9Kgym_jNxGW2rWpQ@mail.gmail.com>
 <CAJFAV8zud76Sqt+5_BfSYshB5kLiy8tGNStneepuWE0eCSrB3A@mail.gmail.com>
In-Reply-To: <CAJFAV8zud76Sqt+5_BfSYshB5kLiy8tGNStneepuWE0eCSrB3A@mail.gmail.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Thu, 3 Oct 2019 12:00:39 +0530
Message-ID: <CALBAE1OA-LmtpbEBLPWnfPPaPY7pduuR5smX5mAN1rj4eGTJjw@mail.gmail.com>
To: David Marchand <david.marchand@redhat.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
 Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>, 
 Bruce Richardson <bruce.richardson@intel.com>,
 Thomas Monjalon <thomas@monjalon.net>, dev <dev@dpdk.org>, 
 Hemant Agrawal <hemant.agrawal@nxp.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] meson support of armv8 crypto PMD
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, Oct 2, 2019 at 4:09 PM David Marchand <david.marchand@redhat.com> wrote:
>
> On Wed, Oct 2, 2019 at 11:19 AM David Marchand
> <david.marchand@redhat.com> wrote:
> >
> > On Wed, Oct 2, 2019 at 10:56 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > There is no meson support for drivers/crypto/armv8/
> > >
> > > Please, who can add it?
> >
> > From my side, I would love to get detailed instructions on cross
> > compiling the external library "armv8_crypto".
>
> Something has been broken in this library.
> Current HEAD won't compile, went back to some reference Thomas had in his setup.
>
> d498a6f - (HEAD -> master, origin/master, origin/HEAD) crypto/armv8:
> ILP optimizations for AES128CBCdec+SHA256 HMAC (2 years, 7 months ago)
> <Zbigniew Bodek>
>
> Won't compile.
>
> 71258fb - Makefile: remove DPDK dependency (2 years, 9 months ago)
> <Zbigniew Bodek>
>
> Builds fine.
>
>
> Please someone fix this library and/or the documentation we have in dpdk.

I have fixed the 'native' build issue. We will add cross-compilation
support and update the library README.

I was expecting a similar issue and I was against creating a separate
library to have an unnecessary
dependency. This library was soley meant for DPDK so there was no
technical reason for making it
a separate library. I don't believe the external libraries are really
open source way of doing the stuff.
I think the argument to keep the external library was
- Crypto export license issues.
-  Assembly code is diffcult to understand and therefore maintain it.








> Thanks.
>
>
> --
> David Marchand
>