DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>
Cc: dpdk-dev <dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>,
	 David Marchand <david.marchand@redhat.com>,
	Olivier Matz <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] DPDK Release Status Meeting 9/04/2020
Date: Thu, 9 Apr 2020 18:40:35 +0530	[thread overview]
Message-ID: <CALBAE1OB7jACoeghbXf=Maa=gs5i0FStJcoiOVxjha+bpsBkmQ@mail.gmail.com> (raw)
In-Reply-To: <0e082fc8-c60c-f62b-ef22-4b453e193567@intel.com>

>     * tracing library
>       * Some concerns on the API, it is copy/paste of log API

The following API  signatures are taken from log API.

1) void rte_trace_global_level_set(uint32_t level);
2) uint32_t rte_trace_global_level_get(void);
3) uint32_t rte_trace_level_get(rte_trace_t trace);
4) int rte_trace_level_set(rte_trace_t trace, uint32_t level);
5) int rte_trace_pattern(const char *pattern, bool enable);
6) int rte_trace_regexp(const char *regex, bool enable);

I have intentionally kept public API similar to rte_log wherever it is
possible. Reason being,

1) In the future, it is easy to replace rte_log with trace _if needed_.
2) Avoid the new API learning curve.
3) I did not find anything wrong with the existing log API to improve
on at least on API that selected to copy the prototype.

If there are specific comments on why we need to take the deviation
from log API on the above schematics. I am happy to change it.

>       * Lacking more reviews

Just FYI:
There is enough documentation on the programming model and
implementation details if someone likes to kick start the review.

http://patches.dpdk.org/patch/67792/

  reply	other threads:[~2020-04-09 13:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-09 12:42 Ferruh Yigit
2020-04-09 13:10 ` Jerin Jacob [this message]
2020-04-09 13:36   ` Thomas Monjalon
2020-04-09 13:47     ` Jerin Jacob

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1OB7jACoeghbXf=Maa=gs5i0FStJcoiOVxjha+bpsBkmQ@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=olivier.matz@6wind.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).