From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 10555423FA; Tue, 17 Jan 2023 08:49:53 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B864540151; Tue, 17 Jan 2023 08:49:52 +0100 (CET) Received: from mail-vk1-f171.google.com (mail-vk1-f171.google.com [209.85.221.171]) by mails.dpdk.org (Postfix) with ESMTP id 3CBD0400D4 for ; Tue, 17 Jan 2023 08:49:52 +0100 (CET) Received: by mail-vk1-f171.google.com with SMTP id e132so4085374vke.11 for ; Mon, 16 Jan 2023 23:49:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cg8yjieeqvBLQkj+rMN+ZwUoWD9cxe8Jinumudhd+js=; b=OWvxxlQqIV7NYXABLVRRA54ul+Hx/RfPi8nE2+RBCxO0xty8ojwzxg1I0Yri3mxu9g 6cRrRxfEnmmh7qqI+Zps/ysauyIC9BpQ3Cf5Tq1pRwuZE1vcOk51bJaTNW1HXphxnA5/ K/zfmb4vXQBnZYa/Mqpyl6wRDuc7I7KX38D7PV6SFyKwJ4Rwuu4EX/tsaQd7BFx1t9vW Px8cQHGr4GOnEcVGvJBlIFMihpGHug55eZZgO9EvxTGtRdnYaFPdpMooujvGf+m1kEy6 /utI7Shj0haG5n6bSON8bzdOk7aTIYvjZJF1um9z3v7t7ojz0WPAt3i7r4Y+aZqf0iz8 xUjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cg8yjieeqvBLQkj+rMN+ZwUoWD9cxe8Jinumudhd+js=; b=hD0jqE/+6DrEcVByMcgvj0TprpCs2LxorvAUzIoiMCQ78zAw1I89wetj9CWSUh5+5N ZpvbPW9DVnLwGs83dfSyyQ/sS5xJuTvFgjtth0AiN82bxJ7ggH0YuBVC+ws2c94DSjyY 5WMJXBgv7xcHikJhUwLFZQcV/1FpbNJkqv2yGxrRTPwm/1yYEv4M9VhkdtqeHqjMC4ev U3/QiwFKpBqrZh2tFSyvq/W8S0AOllvFgyKheknADAyg2NfNObb5y+yxOtnP0EeH1oGb XX+6ZUgNmuQ8HX19mAKS8GC7wXNoJsM+9lv0RrAzAyAahKTWXlnyrcRo7JdCBncXN7s6 f07Q== X-Gm-Message-State: AFqh2koEtYaRgyZyhuug1YnX/T8MGug2F/tXEq+DfyX0EEt6w3Ea+Q0x BniWcZHCS5O5DQe213iFm9rgY8q8roDJVOfsG8o= X-Google-Smtp-Source: AMrXdXtvEWKZzuzngCxoNGHOP3sJe68wnNxCmgyXRQVCqaWZ519V4p8XkglcOqXwLvLQUAxGYVbpOCELJCOd4eU19yY= X-Received: by 2002:a05:6122:91d:b0:3e1:a746:2b9e with SMTP id j29-20020a056122091d00b003e1a7462b9emr69463vka.5.1673941791473; Mon, 16 Jan 2023 23:49:51 -0800 (PST) MIME-Version: 1.0 References: <1670439617-9054-1-git-send-email-roretzla@linux.microsoft.com> <1673635923-12432-1-git-send-email-roretzla@linux.microsoft.com> <1673635923-12432-3-git-send-email-roretzla@linux.microsoft.com> In-Reply-To: <1673635923-12432-3-git-send-email-roretzla@linux.microsoft.com> From: Jerin Jacob Date: Tue, 17 Jan 2023 13:19:25 +0530 Message-ID: Subject: Re: [PATCH v4 2/4] eal: remove thread getname API To: Tyler Retzlaff Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, mb@smartsharesystems.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Sat, Jan 14, 2023 at 12:22 AM Tyler Retzlaff wrote: > > Remove the rte_thread_getname API. The API is __rte_experimental and > requires no deprecation notice. > > Fold the platform specific variants into the one place it is used as a > special case to retain the functionality for linux only. > > void > __rte_trace_mem_per_thread_alloc(void) > { > @@ -356,7 +369,7 @@ rte_trace_mode rte_trace_mode_get(void) > /* Store the thread name */ > char *name = header->stream_header.thread_name; > memset(name, 0, __RTE_TRACE_EMIT_STRING_LEN_MAX); > - rte_thread_getname(pthread_self(), name, > + rte_thread_get_name(rte_thread_self(), name, Since it's a local function. Please change thread_get_name or so?