From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D4C69A0548; Mon, 14 Jun 2021 05:27:24 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 567F44003F; Mon, 14 Jun 2021 05:27:24 +0200 (CEST) Received: from mail-io1-f52.google.com (mail-io1-f52.google.com [209.85.166.52]) by mails.dpdk.org (Postfix) with ESMTP id 6DFBB4003E for ; Mon, 14 Jun 2021 05:27:22 +0200 (CEST) Received: by mail-io1-f52.google.com with SMTP id s19so28371640ioc.3 for ; Sun, 13 Jun 2021 20:27:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2vyHt3mZvB9kt5aPb7xLxdQDVpSJwBVGRars1kyCF8o=; b=rY6RaQDeLo6BEdW48oQqHxFc8mLNNcpaf4FrvZXc6dWq5/GJlUWXDo8Lbs3DQkNseM snxnMEcIT2Rqta8t39A2ky9K98709mph1j/m5f0wpEnzLvraXTnQcAlRsvh2dPfRqO+I SEP4Yq+D/UhG1Mz8AigukrR0ycDRogOqN9buK2J2wNrE+WFXC6C18YzH411geXNSMdUT hm7qkuns1waeEdICGR28N+LH6lEYE4rNvIQfkvqqaIFpjCw/kObL18OLpU5V5LnTSkAq aXHHkAgGyaPxU6iOj2TyCV7ZBsAunY5U59c8ZJnLiXpIGNkEkw3iKmH8son06DAOmJrT 3/Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2vyHt3mZvB9kt5aPb7xLxdQDVpSJwBVGRars1kyCF8o=; b=FUOx/RSFHb2me9eNjwvrfmbgQnW3lPouq75XCq29FgbVFkm+aoqESjWgFz7WcVYzzm 8Z4Sw+elpyEJ8a4mHMnjfL6dh01wGBLoNkDckryvUZGfJRHr8fOo/QE9IkNe4U85LGKc GNq73x954y6ZuAeVw29Kc7MlbMoWyyi9JA9Nd7cyrzqb5gbqiNsOGreZo9NdR4Uukxj9 qSzWQyn1SCxxoxAfmRcU2dReu2VPtzFu+fm08fNPN1nDjtnrjLmrzGtevC8W+Lf0m+Jh Fb/+mZHyGD9ntMcSikhbQZkNnfMMUwTKRUa6r4KybKA/2rxCzdwg11y8KbZ3MkPJyhDC EYsw== X-Gm-Message-State: AOAM531nizhvT+X5kEAOMxlvHeT2HKOjXHS53cm7mP3WESRJTzM8jNDp 76p4fCeEQiD9w3jEhVPmDlgM0p8u4361CW3fuXA= X-Google-Smtp-Source: ABdhPJyjsA1AI5g9HbS2Yyw8b7p/CE8Eds43JrOnieyt8sDFX9CSX6OVbwbv4a/QJQl8vkwzYTtVtkrAL2IxOXXs9a0= X-Received: by 2002:a05:6638:12cd:: with SMTP id v13mr14918074jas.104.1623641241339; Sun, 13 Jun 2021 20:27:21 -0700 (PDT) MIME-Version: 1.0 References: <20210306153404.10781-1-ndabilpuram@marvell.com> <20210607175943.31690-1-ndabilpuram@marvell.com> In-Reply-To: <20210607175943.31690-1-ndabilpuram@marvell.com> From: Jerin Jacob Date: Mon, 14 Jun 2021 08:57:05 +0530 Message-ID: To: Nithin Dabilpuram Cc: dpdk-dev , Jerin Jacob , Sunil Kumar Kori , Satha Koteswara Rao Kottidi , Pavan Nikhilesh , Kiran Kumar K , Satheesh Paul , Ashwin Sekhar Thalakalath Kottilveetil Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 00/62] Marvell CNXK Ethdev Driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Jun 7, 2021 at 11:33 PM Nithin Dabilpuram wrote: > > This patchset adds support for Marvell CN106XX SoC based on 'common/cnxk' > driver. In future, CN9K a.k.a octeontx2 will also be supported by same > driver when code is ready and 'net/octeontx2' will be deprecated. A couple of checkpatch and check-git-log issue to check and fix. Wrong headline format: net/cnxk: support for rss in rte_flow net/cnxk: added reta and rss_hash operations Wrong headline prefix: net/cnxk: add flow ops get operation Wrong headline case: "net/cnxk: added reta and rss_hash operations": reta --> RETA Wrong headline case: "net/cnxk: support for rss in rte_flow": rss --> RSS Is it candidate for Cc: stable@dpdk.org backport? common/cnxk: fix batch alloc completion poll logic common/cnxk: fix flow create on CN98xx CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #267: FILE: drivers/net/cnxk/cn9k_rx.h:195: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #178: FILE: drivers/net/cnxk/cn9k_rx.h:397: + ol_flags0 = nix_update_match_id( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #181: FILE: drivers/net/cnxk/cn9k_rx.h:400: + ol_flags1 = nix_update_match_id( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #184: FILE: drivers/net/cnxk/cn9k_rx.h:403: + ol_flags2 = nix_update_match_id( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #187: FILE: drivers/net/cnxk/cn9k_rx.h:406: + ol_flags3 = nix_update_match_id( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #173: FILE: drivers/net/cnxk/cn9k_tx.h:89: + *oudplen = rte_cpu_to_be_16( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #268: FILE: drivers/net/cnxk/cn10k_rx.h:193: + rte_prefetch_non_temporal( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #190: FILE: drivers/net/cnxk/cn10k_rx.h:394: + ol_flags0 = nix_update_match_id( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #193: FILE: drivers/net/cnxk/cn10k_rx.h:397: + ol_flags1 = nix_update_match_id( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #196: FILE: drivers/net/cnxk/cn10k_rx.h:400: + ol_flags2 = nix_update_match_id( CHECK:OPEN_ENDED_LINE: Lines should not end with a '(' #199: FILE: drivers/net/cnxk/cn10k_rx.h:403: + ol_flags3 = nix_update_match_id( WARNING:STRLCPY: Prefer strscpy over strlcpy - see: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ #131: FILE: drivers/net/cnxk/cnxk_stats.c:125: + strlcpy(xstats_names[i].name, roc_xstats_name[i].name, WARNING:STRLCPY: Prefer strscpy over strlcpy - see: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ #161: FILE: drivers/net/cnxk/cnxk_stats.c:155: + strlcpy(xstats_names[i].name, xnames[ids[i]].name, total: 0 errors, 2 warnings, 0 checks, 184 lines checked ### net/cnxk: add ethdev firmware version get WARNING:STRLCPY: Prefer strscpy over strlcpy - see: https://lore.kernel.org/r/CAHk-=wgfRnXz0W3D37d01q3JFkr_i_uTL=V6A6G1oUZcprmknw@mail.gmail.com/ #90: FILE: drivers/net/cnxk/cnxk_ethdev_ops.c:647: + strlcpy(fw_version, str, fw_size); WARNING:TYPO_SPELLING: 'cant' may be misspelled - perhaps 'can't'? #79: FILE: drivers/net/cnxk/cn10k_ethdev.c:327: + /* In case of VF, setting of MTU cant be done directly in this ^^^^ WARNING:TYPO_SPELLING: 'cant' may be misspelled - perhaps 'can't'? #208: FILE: drivers/net/cnxk/cn9k_ethdev.c:336: + /* In case of VF, setting of MTU cant be done directly in this ^^^^ total: 0 errors, 2 warnings, 0 checks, 248 lines checked > > Harman Kalra (1): > common/cnxk: allocate lmt region in userspace > > Jerin Jacob (7): > common/cnxk: fix batch alloc completion poll logic > net/cnxk: add Rx support for cn9k > net/cnxk: add Rx vector version for cn9k > net/cnxk: add Tx support for cn9k > net/cnxk: add Rx support for cn10k > net/cnxk: add Rx vector version for cn10k > net/cnxk: add Tx support for cn10k > > Kiran Kumar K (2): > net/cnxk: add support to configure npc > net/cnxk: add initial version of rte flow support > > Nithin Dabilpuram (17): > net/cnxk: add build infra and common probe > net/cnxk: add platform specific probe and remove > net/cnxk: add common devargs parsing function > net/cnxk: add common dev infos get support > net/cnxk: add device configuration operation > net/cnxk: add link status update support > net/cnxk: add Rx queue setup and release > net/cnxk: add Tx queue setup and release > net/cnxk: add packet type support > net/cnxk: add queue start and stop support > net/cnxk: add Rx multi-segmented version for cn9k > net/cnxk: add Tx multi-segment version for cn9k > net/cnxk: add Tx vector version for cn9k > net/cnxk: add Rx multi-segment version for cn10k > net/cnxk: add Tx multi-segment version for cn10k > net/cnxk: add Tx vector version for cn10k > net/cnxk: add device start and stop operations > > Satha Rao (8): > common/cnxk: add support to lock NIX RQ contexts > common/cnxk: add provision to enable RED on RQ > net/cnxk: add port/queue stats > net/cnxk: add xstats apis > net/cnxk: add rxq/txq info get operations > net/cnxk: add ethdev firmware version get > net/cnxk: add get register operation > net/cnxk: added reta and rss_hash operations > > Satheesh Paul (6): > common/cnxk: add support to dump flow entries > common/cnxk: support for mark and flag flow actions > common/cnxk: fix flow create on CN98xx > net/cnxk: add flow ops get operation > net/cnxk: support for rss in rte_flow > net/cnxk: support for rte flow dev dump API > > Srujana Challa (1): > common/cnxk: update Rx inline IPsec mbox message format > > Sunil Kumar Kori (20): > net/cnxk: add MAC address set ops > net/cnxk: add MTU set device operation > net/cnxk: add promiscuous mode enable and disable > net/cnxk: add DMAC filter support > net/cnxk: add all multicast enable/disable ethops > net/cnxk: add Rx/Tx burst mode get ops > net/cnxk: add flow ctrl set/get ops > net/cnxk: add link up/down operations > net/cnxk: add EEPROM module info get operations > net/cnxk: add Rx queue interrupt enable/disable ops > net/cnxk: add validation API for mempool ops > net/cnxk: add device close and reset operations > net/cnxk: add pending Tx mbuf cleanup operation > net/cnxk: register callback to get PTP status > net/cnxk: add base PTP timesync support > net/cnxk: add timesync enable/disable operations > net/cnxk: add Rx/Tx timestamp read operations > net/cnxk: add time read/write/adjust operations > net/cnxk: add read clock operation > net/cnxk: add multicast filter support > > -- > > v2: > - Fixed issue with flow validate and flow create for 98xx > - Fixed issue batch alloc logic > - Fix lmtline allocation to be cached > - Sync Inline IPSec Rx mbox with kernel > - Add support for mark and flag flow actions > - Add reta key and hash update ops > - Added PTP and multicast filter support > > MAINTAINERS | 3 + > doc/guides/nics/cnxk.rst | 343 ++++++ > doc/guides/nics/features/cnxk.ini | 90 ++ > doc/guides/nics/features/cnxk_vec.ini | 44 + > doc/guides/nics/features/cnxk_vf.ini | 40 + > doc/guides/nics/index.rst | 1 + > doc/guides/platform/cnxk.rst | 3 + > drivers/common/cnxk/hw/npc.h | 2 + > drivers/common/cnxk/meson.build | 1 + > drivers/common/cnxk/roc_api.h | 2 + > drivers/common/cnxk/roc_dev.c | 98 +- > drivers/common/cnxk/roc_dev_priv.h | 1 + > drivers/common/cnxk/roc_mbox.h | 6 + > drivers/common/cnxk/roc_model.h | 6 + > drivers/common/cnxk/roc_nix.h | 39 +- > drivers/common/cnxk/roc_nix_queue.c | 52 + > drivers/common/cnxk/roc_nix_rss.c | 51 +- > drivers/common/cnxk/roc_nix_tm_utils.c | 86 +- > drivers/common/cnxk/roc_npa.c | 10 +- > drivers/common/cnxk/roc_npa.h | 35 +- > drivers/common/cnxk/roc_npc.c | 41 +- > drivers/common/cnxk/roc_npc.h | 15 +- > drivers/common/cnxk/roc_npc_mcam_dump.c | 611 +++++++++++ > drivers/common/cnxk/roc_npc_priv.h | 2 +- > drivers/common/cnxk/roc_npc_utils.c | 4 + > drivers/common/cnxk/roc_platform.h | 13 + > drivers/common/cnxk/version.map | 5 + > drivers/net/cnxk/cn10k_ethdev.c | 534 ++++++++++ > drivers/net/cnxk/cn10k_ethdev.h | 40 + > drivers/net/cnxk/cn10k_rx.c | 78 ++ > drivers/net/cnxk/cn10k_rx.h | 546 ++++++++++ > drivers/net/cnxk/cn10k_rx_mseg.c | 17 + > drivers/net/cnxk/cn10k_rx_vec.c | 22 + > drivers/net/cnxk/cn10k_tx.c | 82 ++ > drivers/net/cnxk/cn10k_tx.h | 1737 +++++++++++++++++++++++++++++++ > drivers/net/cnxk/cn10k_tx_mseg.c | 25 + > drivers/net/cnxk/cn10k_tx_vec.c | 26 + > drivers/net/cnxk/cn9k_ethdev.c | 557 ++++++++++ > drivers/net/cnxk/cn9k_ethdev.h | 38 + > drivers/net/cnxk/cn9k_rx.c | 78 ++ > drivers/net/cnxk/cn9k_rx.h | 548 ++++++++++ > drivers/net/cnxk/cn9k_rx_mseg.c | 17 + > drivers/net/cnxk/cn9k_rx_vec.c | 20 + > drivers/net/cnxk/cn9k_tx.c | 81 ++ > drivers/net/cnxk/cn9k_tx.h | 1605 ++++++++++++++++++++++++++++ > drivers/net/cnxk/cn9k_tx_mseg.c | 25 + > drivers/net/cnxk/cn9k_tx_vec.c | 26 + > drivers/net/cnxk/cnxk_ethdev.c | 1511 +++++++++++++++++++++++++++ > drivers/net/cnxk/cnxk_ethdev.h | 478 +++++++++ > drivers/net/cnxk/cnxk_ethdev_devargs.c | 173 +++ > drivers/net/cnxk/cnxk_ethdev_ops.c | 904 ++++++++++++++++ > drivers/net/cnxk/cnxk_link.c | 113 ++ > drivers/net/cnxk/cnxk_lookup.c | 326 ++++++ > drivers/net/cnxk/cnxk_ptp.c | 287 +++++ > drivers/net/cnxk/cnxk_rte_flow.c | 366 +++++++ > drivers/net/cnxk/cnxk_rte_flow.h | 69 ++ > drivers/net/cnxk/cnxk_stats.c | 217 ++++ > drivers/net/cnxk/meson.build | 45 + > drivers/net/cnxk/version.map | 3 + > drivers/net/meson.build | 1 + > 60 files changed, 12116 insertions(+), 83 deletions(-) > create mode 100644 doc/guides/nics/cnxk.rst > create mode 100644 doc/guides/nics/features/cnxk.ini > create mode 100644 doc/guides/nics/features/cnxk_vec.ini > create mode 100644 doc/guides/nics/features/cnxk_vf.ini > create mode 100644 drivers/common/cnxk/roc_npc_mcam_dump.c > create mode 100644 drivers/net/cnxk/cn10k_ethdev.c > create mode 100644 drivers/net/cnxk/cn10k_ethdev.h > create mode 100644 drivers/net/cnxk/cn10k_rx.c > create mode 100644 drivers/net/cnxk/cn10k_rx.h > create mode 100644 drivers/net/cnxk/cn10k_rx_mseg.c > create mode 100644 drivers/net/cnxk/cn10k_rx_vec.c > create mode 100644 drivers/net/cnxk/cn10k_tx.c > create mode 100644 drivers/net/cnxk/cn10k_tx.h > create mode 100644 drivers/net/cnxk/cn10k_tx_mseg.c > create mode 100644 drivers/net/cnxk/cn10k_tx_vec.c > create mode 100644 drivers/net/cnxk/cn9k_ethdev.c > create mode 100644 drivers/net/cnxk/cn9k_ethdev.h > create mode 100644 drivers/net/cnxk/cn9k_rx.c > create mode 100644 drivers/net/cnxk/cn9k_rx.h > create mode 100644 drivers/net/cnxk/cn9k_rx_mseg.c > create mode 100644 drivers/net/cnxk/cn9k_rx_vec.c > create mode 100644 drivers/net/cnxk/cn9k_tx.c > create mode 100644 drivers/net/cnxk/cn9k_tx.h > create mode 100644 drivers/net/cnxk/cn9k_tx_mseg.c > create mode 100644 drivers/net/cnxk/cn9k_tx_vec.c > create mode 100644 drivers/net/cnxk/cnxk_ethdev.c > create mode 100644 drivers/net/cnxk/cnxk_ethdev.h > create mode 100644 drivers/net/cnxk/cnxk_ethdev_devargs.c > create mode 100644 drivers/net/cnxk/cnxk_ethdev_ops.c > create mode 100644 drivers/net/cnxk/cnxk_link.c > create mode 100644 drivers/net/cnxk/cnxk_lookup.c > create mode 100644 drivers/net/cnxk/cnxk_ptp.c > create mode 100644 drivers/net/cnxk/cnxk_rte_flow.c > create mode 100644 drivers/net/cnxk/cnxk_rte_flow.h > create mode 100644 drivers/net/cnxk/cnxk_stats.c > create mode 100644 drivers/net/cnxk/meson.build > create mode 100644 drivers/net/cnxk/version.map > > -- > 2.8.4 >