* [PATCH] event/cnxk: wait for CPT fc on wqe path
@ 2022-12-09 13:41 Rahul Bhansali
2023-01-18 15:06 ` Jerin Jacob
2023-01-19 5:53 ` [PATCH v2] event/cnxk: wait for CPT flow control on WQE path Rahul Bhansali
0 siblings, 2 replies; 5+ messages in thread
From: Rahul Bhansali @ 2022-12-09 13:41 UTC (permalink / raw)
To: dev, Pavan Nikhilesh, Shijith Thotton, Nithin Dabilpuram,
Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: jerinj, Rahul Bhansali
Wait for CPT flow control on WQE path.
Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
drivers/event/cnxk/cn9k_worker.h | 1 +
drivers/net/cnxk/cn9k_tx.h | 10 ++++++++++
2 files changed, 11 insertions(+)
diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
index 4c3932da47..d3c5180fbc 100644
--- a/drivers/event/cnxk/cn9k_worker.h
+++ b/drivers/event/cnxk/cn9k_worker.h
@@ -730,6 +730,7 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, uint64_t base,
rte_io_wmb();
cn9k_sso_txq_fc_wait(txq);
+ cn9k_nix_sec_fc_wait_one(txq);
/* Write CPT instruction to lmt line */
vst1q_u64(lmt_addr, cmd01);
diff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h
index 404edd6aed..7362025a34 100644
--- a/drivers/net/cnxk/cn9k_tx.h
+++ b/drivers/net/cnxk/cn9k_tx.h
@@ -388,6 +388,16 @@ cn9k_nix_xmit_prep_lmt(uint64_t *cmd, void *lmt_addr, const uint32_t flags)
roc_lmt_mov(lmt_addr, cmd, cn9k_nix_tx_ext_subs(flags));
}
+static __rte_always_inline void
+cn9k_nix_sec_fc_wait_one(const struct cn9k_eth_txq *txq)
+{
+ uint64_t nb_desc = txq->cpt_desc;
+ uint64_t *fc = txq->cpt_fc;
+
+ while (nb_desc <= __atomic_load_n(fc, __ATOMIC_RELAXED))
+ ;
+}
+
static __rte_always_inline uint64_t
cn9k_nix_xmit_submit_lmt(const rte_iova_t io_addr)
{
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] event/cnxk: wait for CPT fc on wqe path
2022-12-09 13:41 [PATCH] event/cnxk: wait for CPT fc on wqe path Rahul Bhansali
@ 2023-01-18 15:06 ` Jerin Jacob
2023-01-19 5:53 ` [PATCH v2] event/cnxk: wait for CPT flow control on WQE path Rahul Bhansali
1 sibling, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2023-01-18 15:06 UTC (permalink / raw)
To: Rahul Bhansali
Cc: dev, Pavan Nikhilesh, Shijith Thotton, Nithin Dabilpuram,
Kiran Kumar K, Sunil Kumar Kori, Satha Rao, jerinj
On Fri, Dec 9, 2022 at 7:11 PM Rahul Bhansali <rbhansali@marvell.com> wrote:
>
> Wait for CPT flow control on WQE path.
Please add Why? If it is bug add Fixes:
Also change the subject as event/cnxk: wait for CPT flow control on WQE path
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
> ---
> drivers/event/cnxk/cn9k_worker.h | 1 +
> drivers/net/cnxk/cn9k_tx.h | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
> index 4c3932da47..d3c5180fbc 100644
> --- a/drivers/event/cnxk/cn9k_worker.h
> +++ b/drivers/event/cnxk/cn9k_worker.h
> @@ -730,6 +730,7 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, uint64_t base,
>
> rte_io_wmb();
> cn9k_sso_txq_fc_wait(txq);
> + cn9k_nix_sec_fc_wait_one(txq);
>
> /* Write CPT instruction to lmt line */
> vst1q_u64(lmt_addr, cmd01);
> diff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h
> index 404edd6aed..7362025a34 100644
> --- a/drivers/net/cnxk/cn9k_tx.h
> +++ b/drivers/net/cnxk/cn9k_tx.h
> @@ -388,6 +388,16 @@ cn9k_nix_xmit_prep_lmt(uint64_t *cmd, void *lmt_addr, const uint32_t flags)
> roc_lmt_mov(lmt_addr, cmd, cn9k_nix_tx_ext_subs(flags));
> }
>
> +static __rte_always_inline void
> +cn9k_nix_sec_fc_wait_one(const struct cn9k_eth_txq *txq)
> +{
> + uint64_t nb_desc = txq->cpt_desc;
> + uint64_t *fc = txq->cpt_fc;
> +
> + while (nb_desc <= __atomic_load_n(fc, __ATOMIC_RELAXED))
> + ;
> +}
> +
> static __rte_always_inline uint64_t
> cn9k_nix_xmit_submit_lmt(const rte_iova_t io_addr)
> {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] event/cnxk: wait for CPT flow control on WQE path
2022-12-09 13:41 [PATCH] event/cnxk: wait for CPT fc on wqe path Rahul Bhansali
2023-01-18 15:06 ` Jerin Jacob
@ 2023-01-19 5:53 ` Rahul Bhansali
2023-01-24 8:52 ` Jerin Jacob
1 sibling, 1 reply; 5+ messages in thread
From: Rahul Bhansali @ 2023-01-19 5:53 UTC (permalink / raw)
To: dev, Pavan Nikhilesh, Shijith Thotton, Nithin Dabilpuram,
Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: jerinj, Rahul Bhansali
This is to avoid CPT queue overflow and thereby a CPT misc
interrupt.
Fixes: 1a7da795f64 ("net/cnxk: support Tx security offload on cn9k")
Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
---
Changes in v2: Updated commit message.
drivers/event/cnxk/cn9k_worker.h | 1 +
drivers/net/cnxk/cn9k_tx.h | 10 ++++++++++
2 files changed, 11 insertions(+)
diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
index 54213db3b4..1ce4b044e8 100644
--- a/drivers/event/cnxk/cn9k_worker.h
+++ b/drivers/event/cnxk/cn9k_worker.h
@@ -730,6 +730,7 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, uint64_t base,
rte_io_wmb();
cn9k_sso_txq_fc_wait(txq);
+ cn9k_nix_sec_fc_wait_one(txq);
/* Write CPT instruction to lmt line */
vst1q_u64(lmt_addr, cmd01);
diff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h
index 17bbdce3a0..b4ef45d65c 100644
--- a/drivers/net/cnxk/cn9k_tx.h
+++ b/drivers/net/cnxk/cn9k_tx.h
@@ -411,6 +411,16 @@ cn9k_nix_xmit_prep_lmt(uint64_t *cmd, void *lmt_addr, const uint32_t flags)
roc_lmt_mov(lmt_addr, cmd, cn9k_nix_tx_ext_subs(flags));
}
+static __rte_always_inline void
+cn9k_nix_sec_fc_wait_one(const struct cn9k_eth_txq *txq)
+{
+ uint64_t nb_desc = txq->cpt_desc;
+ uint64_t *fc = txq->cpt_fc;
+
+ while (nb_desc <= __atomic_load_n(fc, __ATOMIC_RELAXED))
+ ;
+}
+
static __rte_always_inline uint64_t
cn9k_nix_xmit_submit_lmt(const rte_iova_t io_addr)
{
--
2.25.1
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] event/cnxk: wait for CPT flow control on WQE path
2023-01-19 5:53 ` [PATCH v2] event/cnxk: wait for CPT flow control on WQE path Rahul Bhansali
@ 2023-01-24 8:52 ` Jerin Jacob
2023-01-24 8:53 ` Jerin Jacob
0 siblings, 1 reply; 5+ messages in thread
From: Jerin Jacob @ 2023-01-24 8:52 UTC (permalink / raw)
To: Rahul Bhansali
Cc: dev, Pavan Nikhilesh, Shijith Thotton, Nithin Dabilpuram,
Kiran Kumar K, Sunil Kumar Kori, Satha Rao, jerinj
On Thu, Jan 19, 2023 at 11:23 AM Rahul Bhansali <rbhansali@marvell.com> wrote:
>
> This is to avoid CPT queue overflow and thereby a CPT misc
> interrupt.
>
> Fixes: 1a7da795f64 ("net/cnxk: support Tx security offload on cn9k")
>
> Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
> ---
> Changes in v2: Updated commit message.
>
> drivers/event/cnxk/cn9k_worker.h | 1 +
> drivers/net/cnxk/cn9k_tx.h | 10 ++++++++++
> 2 files changed, 11 insertions(+)
>
> diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
> index 54213db3b4..1ce4b044e8 100644
> --- a/drivers/event/cnxk/cn9k_worker.h
> +++ b/drivers/event/cnxk/cn9k_worker.h
> @@ -730,6 +730,7 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, uint64_t base,
>
> rte_io_wmb();
> cn9k_sso_txq_fc_wait(txq);
> + cn9k_nix_sec_fc_wait_one(txq);
>
> /* Write CPT instruction to lmt line */
> vst1q_u64(lmt_addr, cmd01);
> diff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h
> index 17bbdce3a0..b4ef45d65c 100644
> --- a/drivers/net/cnxk/cn9k_tx.h
> +++ b/drivers/net/cnxk/cn9k_tx.h
> @@ -411,6 +411,16 @@ cn9k_nix_xmit_prep_lmt(uint64_t *cmd, void *lmt_addr, const uint32_t flags)
> roc_lmt_mov(lmt_addr, cmd, cn9k_nix_tx_ext_subs(flags));
> }
>
> +static __rte_always_inline void
> +cn9k_nix_sec_fc_wait_one(const struct cn9k_eth_txq *txq)
> +{
> + uint64_t nb_desc = txq->cpt_desc;
> + uint64_t *fc = txq->cpt_fc;
> +
> + while (nb_desc <= __atomic_load_n(fc, __ATOMIC_RELAXED))
> + ;
> +}
> +
> static __rte_always_inline uint64_t
> cn9k_nix_xmit_submit_lmt(const rte_iova_t io_addr)
> {
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] event/cnxk: wait for CPT flow control on WQE path
2023-01-24 8:52 ` Jerin Jacob
@ 2023-01-24 8:53 ` Jerin Jacob
0 siblings, 0 replies; 5+ messages in thread
From: Jerin Jacob @ 2023-01-24 8:53 UTC (permalink / raw)
To: Rahul Bhansali
Cc: dev, Pavan Nikhilesh, Shijith Thotton, Nithin Dabilpuram,
Kiran Kumar K, Sunil Kumar Kori, Satha Rao, jerinj
On Tue, Jan 24, 2023 at 2:22 PM Jerin Jacob <jerinjacobk@gmail.com> wrote:
>
> On Thu, Jan 19, 2023 at 11:23 AM Rahul Bhansali <rbhansali@marvell.com> wrote:
> >
> > This is to avoid CPT queue overflow and thereby a CPT misc
> > interrupt.
> >
> > Fixes: 1a7da795f64 ("net/cnxk: support Tx security offload on cn9k")
> >
> > Signed-off-by: Rahul Bhansali <rbhansali@marvell.com>
>
> Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
>
>
> > ---
> > Changes in v2: Updated commit message.
> >
> > drivers/event/cnxk/cn9k_worker.h | 1 +
> > drivers/net/cnxk/cn9k_tx.h | 10 ++++++++++
> > 2 files changed, 11 insertions(+)
> >
> > diff --git a/drivers/event/cnxk/cn9k_worker.h b/drivers/event/cnxk/cn9k_worker.h
> > index 54213db3b4..1ce4b044e8 100644
> > --- a/drivers/event/cnxk/cn9k_worker.h
> > +++ b/drivers/event/cnxk/cn9k_worker.h
> > @@ -730,6 +730,7 @@ cn9k_sso_hws_xmit_sec_one(const struct cn9k_eth_txq *txq, uint64_t base,
> >
> > rte_io_wmb();
> > cn9k_sso_txq_fc_wait(txq);
> > + cn9k_nix_sec_fc_wait_one(txq);
> >
> > /* Write CPT instruction to lmt line */
> > vst1q_u64(lmt_addr, cmd01);
> > diff --git a/drivers/net/cnxk/cn9k_tx.h b/drivers/net/cnxk/cn9k_tx.h
> > index 17bbdce3a0..b4ef45d65c 100644
> > --- a/drivers/net/cnxk/cn9k_tx.h
> > +++ b/drivers/net/cnxk/cn9k_tx.h
> > @@ -411,6 +411,16 @@ cn9k_nix_xmit_prep_lmt(uint64_t *cmd, void *lmt_addr, const uint32_t flags)
> > roc_lmt_mov(lmt_addr, cmd, cn9k_nix_tx_ext_subs(flags));
> > }
> >
> > +static __rte_always_inline void
> > +cn9k_nix_sec_fc_wait_one(const struct cn9k_eth_txq *txq)
> > +{
> > + uint64_t nb_desc = txq->cpt_desc;
> > + uint64_t *fc = txq->cpt_fc;
> > +
> > + while (nb_desc <= __atomic_load_n(fc, __ATOMIC_RELAXED))
> > + ;
> > +}
> > +
> > static __rte_always_inline uint64_t
> > cn9k_nix_xmit_submit_lmt(const rte_iova_t io_addr)
> > {
> > --
> > 2.25.1
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-01-24 8:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-09 13:41 [PATCH] event/cnxk: wait for CPT fc on wqe path Rahul Bhansali
2023-01-18 15:06 ` Jerin Jacob
2023-01-19 5:53 ` [PATCH v2] event/cnxk: wait for CPT flow control on WQE path Rahul Bhansali
2023-01-24 8:52 ` Jerin Jacob
2023-01-24 8:53 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).