From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0D5CA034F; Wed, 6 May 2020 12:51:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 97D9F1D91D; Wed, 6 May 2020 12:51:28 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 0F9931D91A for ; Wed, 6 May 2020 12:51:27 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id n11so1293576ilj.4 for ; Wed, 06 May 2020 03:51:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NufgC9gIRxWtkDCW7aD6z4jodSezOueayf+GX5TKgz8=; b=rTJdOBSPuH1jr/dIPFduRKDKmRMXgM/9MIX6MlmtMS1v/wrxuDBCEeyuk7nY8jmcwS fpUpylUucUNvJfeaaLZ0dxl3EeygeKVMo4VBom3WT3PquKlfpcdbPZQ64mzQmBZli1TG jxKcCez8uHdm8n+YEEPxYgqVgd6JfOaAtzc1NRo3G/ZPQ9/B6hEM4qqFk9c9lw7ynP4s V5SW+L9CxvldLKnBWUmOnsxzVwLv170pj1LmR9bAA0ozyfzgpkVCSJRlY7vOapiMyWIP qMkNsn5EIe8+LAZ69pRLCqAO0D4mnC2M5ardP8ts2o1PSjoK1tguTb3ItbqoenCQ9SWG g77w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NufgC9gIRxWtkDCW7aD6z4jodSezOueayf+GX5TKgz8=; b=IL2lVi5mqI5+kE54J3c28TeQdvbzRv9CB0YXlKzqxhfAefBAuIx+2dG5LGicP41ohQ Lz7lhJvI5zhsQ9xulv+T9N1UqVLfn1bZFZLKWk4/GgrofKfM/2zFdDVNL2NnfbPaLk8M hWri1OKMsMiQcg5sJDJzVivYsTr+DFeeQ0FD1Sx4GXaySyrhAo9lzxtWXrjlI375TsDg MEk0FsOYMoiIheB0pBcgePaji2Rgafvbmckbn5Ng8kax1VUukHeY/AmgYkeyYiiW3T6u dLYXIk+uBiuZOMUVVMU+LU7QlWqJAYjI+sWLtkdYrKPjO9yVoELMLdU5YNFB2+XbUf9H CiYA== X-Gm-Message-State: AGi0PuZs/ozz+HFQZjW5fihfjFDebrjNQizEKNPifk+IJ0SkjRN8aZUT 3ZHzGNdKcW9xBMQ+SgGRXtG7d1yHm+PTi9N/238= X-Google-Smtp-Source: APiQypK6bEdwMQzHAd3L+tj5Lq0miCo+tRN2T0DzNZKN1fRXwS0rSwMjTEg35hVnfrtevIOX64+9wocKHQw8r4QrC8w= X-Received: by 2002:a05:6e02:790:: with SMTP id q16mr7699288ils.60.1588762286265; Wed, 06 May 2020 03:51:26 -0700 (PDT) MIME-Version: 1.0 References: <20200426173811.49788-1-jerinj@marvell.com> <3102527.CAdn2TfLgq@thomas> <6277521.uz5P2jW1tq@thomas> <9115e497-8c08-a0dc-51c1-1eea358d49b5@redhat.com> In-Reply-To: From: Jerin Jacob Date: Wed, 6 May 2020 16:21:10 +0530 Message-ID: To: Maxime Coquelin Cc: David Marchand , Thomas Monjalon , Jerin Jacob , dpdk-dev , Zhihong Wang , "Ye, Xiaolong" , Harman Kalra , Kevin Traynor , Luca Boccassi , Gaetan Rivet Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] bus/pci: optimize pci device probe X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 6, 2020 at 1:23 PM Maxime Coquelin wrote: > > > > On 5/6/20 8:43 AM, Jerin Jacob wrote: > > On Wed, May 6, 2020 at 12:05 PM Maxime Coquelin > > wrote: > >> > >> Hi, > >> > >> On 5/5/20 6:16 PM, David Marchand wrote: > >>> On Tue, May 5, 2020 at 5:50 PM Jerin Jacob wrote: > >>>>>> > >>>>>> Removing this special case could break x86 applications running with > >>>>>> legacy virtio. > >>>>>> > >>>>>> > >>>>>> On the plus side, we have been announcing for some time in virtio: > >>>>>> RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_pci_generic | vfio-pci"); > >>>>> > >>>>> What is to conclude? > >>>>> # The In-tree virtio driver uses ""* igb_uio | uio_pci_generic | > >>>>> vfio-pci"" driver as backend and it does not need RTE_KDRV_NONE? > >>>>> OR > >>>>> # The in-tree, legacy virtio(const struct virtio_pci_ops legacy_op) > >>>>> can work without any kernel driver in the backend. So RTE_KDRV_NONE > >>>>> need? > >>>> > >>>> Ping. What is the conclusion? If it is former then this patch is valid. > >>> > >>> I am fine with dropping the legacy part, but I wanted to hear from > >>> Maxime at least. > >>> > >>> > >> > >> IIUC, it means that with Jerin patch, Virtio Legacy devices support will > >> be dropped as they won't be probed anymore? > > > > The device drivers with RTE_KDRV_NONE as the backend will not be probed. > > 1) Are Virtio Legacy devices are type of RTE_KDRV_NONE? > > Virtio Legacy devices can be probed with no kernel driver. > > > 2) if yes, Would you like to support for virtio legacy device? > > I am OK to remove legacy + RTE_KDRV_NONE case, but I think it needs an > announcement and being done in a later release to let end-users using > that configuration time to do the change. OK > > > 3) if yes, Please fix RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio > > | uio_pci_generic | vfio-pci"); > > While support gets removed, what about: > > RTE_PMD_REGISTER_KMOD_DEP(net_virtio, "* igb_uio | uio_pci_generic | > vfio-pci | none"); ? +1 > > Maxime >