From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B891043391; Tue, 21 Nov 2023 18:21:48 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 46E9F42E8E; Tue, 21 Nov 2023 18:21:48 +0100 (CET) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com [209.85.160.181]) by mails.dpdk.org (Postfix) with ESMTP id 2045240DCD for ; Tue, 21 Nov 2023 18:21:46 +0100 (CET) Received: by mail-qt1-f181.google.com with SMTP id d75a77b69052e-41e3e77e675so34627531cf.1 for ; Tue, 21 Nov 2023 09:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700587305; x=1701192105; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=l7opNjoxC6Q2jxgD/80vsj7YElXt0R68fjAMlZgn/CQ=; b=IewvB/IqoKmNv8q/unQU9O+HiGbqS55GO321bU2yOSTuZsvQYlxZGTezGdVppg0hzF E0C0d64mPQmdBhMaTr2Vc5HSk5hDa7lZ4zVV+ja5iPssAPsj5CpG/U1mvmYGDjDnR5cw iI0MfbAyvf9Xv/5ybban8on+bZJ8cLQU62XPcFa31Y0mjfN1kjDKSc2+MbzsnhADh+GW 4DKz7zqYQ+L730gowery5/6f82ROY0NihuWmzDA+eEN04Jc5vtiLUIcTdAh9HIbL01V+ qls0re37CeiPQla/4mEjls08BB+7cKGnXytaF2ZOy8RYUy93vYcB1YITKS1rZhx1LHYR Ksyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700587305; x=1701192105; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=l7opNjoxC6Q2jxgD/80vsj7YElXt0R68fjAMlZgn/CQ=; b=F6s8HrKXYExVpwFzAP9mnEUGT4Zh+JiDPVhcQYAqzirzHWNIIiPVMArfgnrvfifQL2 GQWj5G2OWDpP8cca5sMEq3J/6lenYlbeGrkv+mZp+OtBaoYr1X2DLJATRIZHFhc53/vW KgbaShVYldV+CGLmjydhnHM91jz9IAwpGjGfrRvwvIAsE7xwSuIxwdvcnrzkDSx+eD0i 2rp/6ZFylbESP+uxbYQmK4Xk65Tofg2QNQLCGj+PGMvJBB//IWZV1lboToNF4F1dd4vV QzMQRdQWdIg8LJnTpiZQX9ZZMreH+obzr7tXAfoEm1e9Mqi0LszY21j7lDuAnZncdX3e l20g== X-Gm-Message-State: AOJu0YwUyaqGgaRcFqROrDttPBVX6iLzb2VS59tE6nJpbA1Wo7sG0uMO B++afoSGnjy4NAhoJ0AMp5OLK6EAlgKkMLGHkYA= X-Google-Smtp-Source: AGHT+IHeq4zMmyERCptL8/3im/WXaquDEFnHCemwmD7dDzoXtgk9iO0jo4VJ737eaIUq9oheymMnbJlFCqPHgPt4New= X-Received: by 2002:ac8:7e8b:0:b0:41e:173e:82b7 with SMTP id w11-20020ac87e8b000000b0041e173e82b7mr11079638qtj.66.1700587305380; Tue, 21 Nov 2023 09:21:45 -0800 (PST) MIME-Version: 1.0 References: <20231023080710.240402-3-rjarry@redhat.com> <20231121083855.6ae8e362@hermes.local> <20231121090423.639655f4@hermes.local> In-Reply-To: <20231121090423.639655f4@hermes.local> From: Jerin Jacob Date: Tue, 21 Nov 2023 22:51:19 +0530 Message-ID: Subject: Re: [PATCH 1/2] usertools/rss: add driver abstractions To: Stephen Hemminger Cc: Robin Jarry , dev@dpdk.org, skori@marvell.com, thomas@monjalon.net Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Nov 21, 2023 at 10:34=E2=80=AFPM Stephen Hemminger wrote: > > On Tue, 21 Nov 2023 22:21:54 +0530 > Jerin Jacob wrote: > > > > The tool should not need to have driver specific tables like this. > > > DPDK is already riddled with enough driver specific quirks.. > > > > > > That shows a flaw in the rss design, which should have been fixed. > > > > Every NIC's implements standard Toeplitz hash algorithm for RSS hash ge= neration. > > Only the initial SEED is different. It is not DPDK property, all the > > HW like is that as > > there is no standardization on initial SEED for hash. > > The tool should be able to query the default key from driver, or the > build infrastructure should extract and generate the table. IMO, That may be too much of non-productive work to save a couple of lines(seed array) of duplicate code between c and python.