From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8E70343816; Thu, 4 Jan 2024 13:47:38 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5732C402CC; Thu, 4 Jan 2024 13:47:38 +0100 (CET) Received: from mail-qt1-f177.google.com (mail-qt1-f177.google.com [209.85.160.177]) by mails.dpdk.org (Postfix) with ESMTP id CBB84402C7 for ; Thu, 4 Jan 2024 13:47:36 +0100 (CET) Received: by mail-qt1-f177.google.com with SMTP id d75a77b69052e-427c4bf6017so2385711cf.0 for ; Thu, 04 Jan 2024 04:47:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704372456; x=1704977256; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=UoSDxSmC9iSR1gtzzastiH+GqS43Mx9UJ94EnUnkH4o=; b=MtlLIRfpt1KUQ//BzDuirC0ZjqGFbAdF2KIUAudTpjGl/6MnyxFgw5cuKoJGkrK3Zv 1GOaNUEE/zmR07591j+3RYXgLOKZ7zmbYbwDUz0OK/X6nHmPBHwXAx54L9JxMJs5/f5a tmimMgzqyrERw/2Xij2it4liVo9OAub53LKKpJfOXZczxcpd/Z1b35I8M+5wXjUAILmr yk3RgBtQX+F750/NE2GucWfpYHPF4SWvQSa5K9AA4PG6mUmlRO2lBGdk0dCwNkXumRrA B8iYzALIk9u7Iu8nxM516wWRRek6IBjzKJIkcB+G0dftQbnni/MXZ7zqFwyUFO0NQXy0 Ey2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704372456; x=1704977256; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=UoSDxSmC9iSR1gtzzastiH+GqS43Mx9UJ94EnUnkH4o=; b=Gbk2i2SzLOQ8GbbL2gRRPatujkqoAGCC0EVzp7Wm/cMlQyxNoQQMMy0Bmelsz7T1aX oh23f1NcA2BaPnURsuUISAF+LtkBgSqnBqx7JfvNAMmMVIsRkLZfkZFsCezUaPEl7Bao q2bRTF9H3kWYaRN7DncLnZbUvFlQATJVBlQ/Ie/na0Hu2DLMGSpuronkZd2Sk3NSh+Uf A9jI5ygacwJ6Ab1f8bFwYskOQLYdIej1lve6cHyApirMRF6Au/WwkqE+Gi5T772VOK9P HuTrktyjLNEfi0fXlyEmYg1hQaOyXebENeDwr4P5fwR/UJThkG2eC4MAm3G0b3BKV4Nj w/Ig== X-Gm-Message-State: AOJu0YzSvCljg4MnSQgJ//2uNJxhulLTSwyrQMkSrjsZQcAQxPaoZB8+ cPiJTTyXx9TawrOBakC0ZLFduVrajhweCkOmTxo6jnWk X-Google-Smtp-Source: AGHT+IEYsjJQi/AMMz/laq2ygU542j38s3vHGTk0mxSmKjjhrW2m6scxLFPzlbX3CnKAC9bR+9OGWsKSoBMtliyQUlk= X-Received: by 2002:a05:622a:1aa5:b0:428:a58:4ec8 with SMTP id s37-20020a05622a1aa500b004280a584ec8mr523777qtc.25.1704372456159; Thu, 04 Jan 2024 04:47:36 -0800 (PST) MIME-Version: 1.0 References: <20230811163419.165790-1-hkalra@marvell.com> <20231219174003.72901-1-hkalra@marvell.com> <20231219174003.72901-8-hkalra@marvell.com> In-Reply-To: <20231219174003.72901-8-hkalra@marvell.com> From: Jerin Jacob Date: Thu, 4 Jan 2024 18:17:10 +0530 Message-ID: Subject: Re: [PATCH v2 07/24] common/cnxk: interface to update VLAN TPID To: Harman Kalra Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Dec 20, 2023 at 12:53=E2=80=AFAM Harman Kalra = wrote: > > Introducing eswitch variant of set vlan tpid api which can be > using for PF and VF > > Signed-off-by: Harman Kalra > + > +int > +roc_eswitch_nix_vlan_tpid_set(struct roc_nix *roc_nix, uint32_t type, ui= nt16_t tpid, bool is_vf) > +{ > + struct nix *nix =3D roc_nix_to_nix_priv(roc_nix); > + struct dev *dev =3D &nix->dev; > + int rc =3D 0; Across the series, Please check the need for initializing to zero for rc. In this case, it is not needed. > + > + /* Configuring for PF/VF */ > + rc =3D nix_vlan_tpid_set(dev->mbox, dev->pf_func | is_vf, type, t= pid); > + if (rc) > + plt_err("Failed to set tpid for PF, rc %d", rc); > + > + return rc; > +}