From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2597742466; Mon, 23 Jan 2023 10:32:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B56D3400EF; Mon, 23 Jan 2023 10:32:02 +0100 (CET) Received: from mail-vs1-f47.google.com (mail-vs1-f47.google.com [209.85.217.47]) by mails.dpdk.org (Postfix) with ESMTP id 4C8AB400D4 for ; Mon, 23 Jan 2023 10:32:01 +0100 (CET) Received: by mail-vs1-f47.google.com with SMTP id 187so12189279vsv.10 for ; Mon, 23 Jan 2023 01:32:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=3HdfVmZj26+MgG1rC95kW2vvdFYvhdIjWpH5rBZ6dWE=; b=e9Krb2bf+kH5fWiZBgej2asV2L+Szk/RlR3j2+4uDz9KfThJrS+OU9C9CGEGWBwskN Xn9Z9KaAdA3LXtTxfeATPUbJYGDuk6YQzedtOYCMdlVTCmKGAK0Xnnw01ej5H1mLCC7C A4dAeBNCSM2PHmnvGNFDr42iwbBQjGBWgw5V0PMeXQ4mlnBGOfn1QvdWhMrKI9GjXGy9 /KNJ3va+TYw3nTGUVQuC/2b0PSAJqmkF0hRNswONYfzgdp58GRIfbDZAisO7jbqh7vrw p6E2gBWKQxGsnKduAPK+Hllv8gCGUndAaG6Z7cnhWCzLsnY5FsUh+h/8fdrlq1xasDH8 NGwg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=3HdfVmZj26+MgG1rC95kW2vvdFYvhdIjWpH5rBZ6dWE=; b=uF/b1xTHsouiKAU9JS4VcPMGZkL8hJ++V26g85Zju6bVWg/JcsQh41UDv/gvGIOxrm 5Vyf1o/YMzaT7Oz6C2VHzAOghhz40WoYI3bIiFlALlMo/Y0BRQzqPIwr6kOBH2rFV/Mw u0uped3I2EZ5hsL+eB3/ctxkFPwkX53q8Z1GKZmrTZuiWeHJISohfAOENWxHaFkeyCA4 cw8aTcrIRxIcX4MlzBKHTexT7+bPYUapqNAiOGJBxN9Ft4v82lyhM6IN8svwdIli/Wtv rg5JS/hyIENSGHK61oI7ASPPrZv2FOb8sCxVWuPABVhPBPYJF7SUkDDb3WBSgYWklxTu EsAw== X-Gm-Message-State: AFqh2kpM3Eyf0M9hvzAhWTplR6/a2tnKpdlYoSIZXmY5XxDccN5dZgQk HBvr7PfcyoFq2Rj3fj+MthcalXb+M224wac+aF4= X-Google-Smtp-Source: AMrXdXtGBCkjhI2VdN8nX2b+Ty05dzSPeQFRlJCNSOXmKhBixipYoLF5dD4oqlcHlB9nW/V3kBPq6/DdWPBJbPOZRYk= X-Received: by 2002:a05:6102:5124:b0:3d3:c7fb:d602 with SMTP id bm36-20020a056102512400b003d3c7fbd602mr3225461vsb.31.1674466320555; Mon, 23 Jan 2023 01:32:00 -0800 (PST) MIME-Version: 1.0 References: <20230107161852.3708690-1-s.v.naga.harish.k@intel.com> In-Reply-To: From: Jerin Jacob Date: Mon, 23 Jan 2023 15:01:34 +0530 Message-ID: Subject: Re: [PATCH 1/3] eventdev/eth_rx: add params set/get APIs To: "Naga Harish K, S V" Cc: "jerinj@marvell.com" , "Gujjar, Abhinandan S" , "dev@dpdk.org" , "Jayatheerthan, Jay" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Fri, Jan 20, 2023 at 4:03 PM Naga Harish K, S V wrote: > > Hi Jerin, > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Friday, January 20, 2023 3:02 PM > > To: Naga Harish K, S V > > Cc: jerinj@marvell.com; Gujjar, Abhinandan S > > ; dev@dpdk.org; Jayatheerthan, Jay > > > > Subject: Re: [PATCH 1/3] eventdev/eth_rx: add params set/get APIs > > > > On Fri, Jan 20, 2023 at 2:28 PM Naga Harish K, S V > > wrote: > > > > > > Hi Jerin, > > > > > > > -----Original Message----- > > > > From: Jerin Jacob > > > > Sent: Wednesday, January 18, 2023 3:52 PM > > > > To: Naga Harish K, S V > > > > Cc: jerinj@marvell.com; Gujjar, Abhinandan S > > > > ; dev@dpdk.org; Jayatheerthan, Jay > > > > > > > > Subject: Re: [PATCH 1/3] eventdev/eth_rx: add params set/get APIs > > > > > > > > On Sat, Jan 7, 2023 at 9:49 PM Naga Harish K S V > > > > wrote: > > > > > > > > > > The adapter configuration parameters defined in the ``struct > > > > > rte_event_eth_rx_adapter_config_params`` can be configured and > > > > > retrieved using ``rte_event_eth_rx_adapter_set_params`` and > > > > > ``rte_event_eth_tx_adapter_get_params`` respectively. > > > > > > > > > > Signed-off-by: Naga Harish K S V > > > > > --- > > > > > > > > > > +/** > > > > > + * Adapter configuration parameters */ struct > > > > > +rte_event_eth_rx_adapter_runtime_params { > > > > > + uint32_t max_nb_rx; > > > > > + /**< The adapter can return early if it has processed at least > > > > > + * max_nb_rx mbufs. This isn't treated as a requirement; batching > > may > > > > > + * cause the adapter to process more than max_nb_rx mbufs. > > > > > > > > This parameter as specific to SW only driver. So future something > > > > added from HW only driver item then it won't work for SW driver. So > > > > we need capability per adapter. > > > > > > > > So, I would suggest following theme across _all_ adapters. > > > > > > > > 1) Introduce RTE_EVENT_ETH_RX_ADAPTER_CAP_RUNTIME_XYZ and > > associate > > > > each parameter(the one we think, it is not common for all > > > > adapters) > > > > > > The parameters that are exposed in the patch are all existing > > > parameters and they are made runtime configurable for SW > > > implementation. I think, there are no such parameters existing today > > > for HW driver implementation. Hence it may be better to introduce these > > flags when the HW driver Implementation requires runtime configurable > > parameters. > > > > Since current values are not applicable to HW. So we any way need the > > capability now to tell this is not applicable for HW. > > > > Depending on the existing adapter capability flag "RTE_EVENT_ETH_RX_ADAPTER_CAP_INTERNAL_PORT", > the current values can be applied to only SW implementation. In this way, there is no need for > creating new capability flags. OK. Makes sense. Please send next version with remaining suggestions. > > > > > > > > 2) Add some reserved fields in > > > > rte_event_eth_rx_adapter_runtime_params > > > > so that we don't break ABI in future > > > > > > Agreed. > > > > > > > 3) Add rte_event_eth_rx_adapter_runtime_params_init() function just > > > > make structure fill with default to avoid ABI break > > > > 4) Add rte_event_eth_rx_adapter_runtime_params_info_get(). Lets > > > > capability flags and other items can be return via this > > > > > > These two items(3,4) can be taken as and when item "1" above is > > implemented. > > > > See above. > > > > > > > > > 5) Change rte_event_eth_rx_adapter_set_params as > > > > rte_event_eth_rx_adapter_runtime_set() or > > > > rte_event_eth_rx_adapter_runtime_params_set() to make it runtime > > > > explicit > > > > > > Agreed > > > > > > > 6) Change rte_event_eth_rx_adapter_get_params as > > > > rte_event_eth_rx_adapter_runtime_get() or > > > > rte_event_eth_rx_adapter_runtime_params_get() to make it runtime > > > > explicit > > > > > > Agreed