From mboxrd@z Thu Jan 1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
by inbox.dpdk.org (Postfix) with ESMTP id E6491A034F;
Mon, 6 Dec 2021 09:08:57 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
by mails.dpdk.org (Postfix) with ESMTP id 7EAA74013F;
Mon, 6 Dec 2021 09:08:57 +0100 (CET)
Received: from mail-io1-f43.google.com (mail-io1-f43.google.com
[209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id 493E940040
for <dev@dpdk.org>; Mon, 6 Dec 2021 09:08:56 +0100 (CET)
Received: by mail-io1-f43.google.com with SMTP id b187so11839341iof.11
for <dev@dpdk.org>; Mon, 06 Dec 2021 00:08:56 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
h=mime-version:references:in-reply-to:from:date:message-id:subject:to
:cc; bh=XNXFvqiTp6LL/QuJ8gHpN7/QPG8H+s9kKJ22fTOeYks=;
b=dZWYxWyYRBAocofIIT/7vV/hKsLp5plhwE3qVmG9ViZYhF7V89+vGkVqnAIznrohbi
y11MrrelaroIGLpebRLpfSNPX1NEh+KBvhy4LI/D/fTe+HGRSClZnlX1maklZa/H4rTv
pRz48Nm184URy387z2dFToN8V4tEv59mXI9Q/B0UZbM0ctsZ7vPxJBUhFrRC32lnYjA6
Z6fIScvT89oY/Jw+9M5rHeHtpCrH38MMZqoMOG/4vzUKd9snaJEXvDJbCfwGbUAnIhy/
ulaA9H9QubKVTGnyJXGuQs0ULosIidI8naKqkHO48Ksk1zzrnVGbe/Zx75XaS52h4wJg
NDmA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=x-gm-message-state:mime-version:references:in-reply-to:from:date
:message-id:subject:to:cc;
bh=XNXFvqiTp6LL/QuJ8gHpN7/QPG8H+s9kKJ22fTOeYks=;
b=vXlQycATUpBSVLii0NhmH7rt92zhD9X6cg2471l1v3JUyQ/R38E8hPuJrJBXts1kBW
gfV2epk0L4CkXpV/8YMtVr1iqNp8tA6V9R4Pc2GF6WlofgUS9jvmhy2tzIndtw2C21cT
XcbmLjz/zuf3H6i218+5EmyGfjMTUIg9OmZU2uFhFZ/PeT8E+BQdeP62scZjtR72IZC5
rtd5s3T02KM909z5T5zX3mGfftgLehZzD+QnDXTBa4gog1NWK1MgRtmlbooxpog4rTRx
pEaXPLrqpLwnVV6fFL55dEx7w/YcWovABTiLyvSdMEThLjGore++YYyWxs+SouvrQIpf
47ig==
X-Gm-Message-State: AOAM532ERzsuhTNX/Mt0sqz23dhEWATARLdZaM1kr47w5JVl0m1lZtL7
1qvXsUoCSYV58ObMlyarSrGlLRafp9kjcK09uYw=
X-Google-Smtp-Source: ABdhPJyRhHhNDMEOeowWvKYuuiL2CC0bzcVF51uoxFkuJw04n/eVE6AGX5IzAtJM+SPrfJddH39+E7X7JaGiGcO4qHs=
X-Received: by 2002:a6b:b886:: with SMTP id
i128mr32361931iof.151.1638778135433;
Mon, 06 Dec 2021 00:08:55 -0800 (PST)
MIME-Version: 1.0
References: <20211123191348.31239-1-lironh@marvell.com>
<20211129195931.14815-1-lironh@marvell.com>
<20211129195931.14815-5-lironh@marvell.com>
<CALBAE1Mia7rnoM8MR1HtNsdNRQBcefOh+nZSCg_bMrxP8DqqAA@mail.gmail.com>
<PH0PR18MB447325FF5D9F319D38DDA6C7C66D9@PH0PR18MB4473.namprd18.prod.outlook.com>
In-Reply-To: <PH0PR18MB447325FF5D9F319D38DDA6C7C66D9@PH0PR18MB4473.namprd18.prod.outlook.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Mon, 6 Dec 2021 13:38:29 +0530
Message-ID: <CALBAE1OLv__9hgzpXoJu7i4f=TMEWZRX-qh4+LV0LA3z79fjVQ@mail.gmail.com>
Subject: Re: [EXT] Re: [PATCH v3 4/5] common/cnxk: link REE support to ROC
files
To: Liron Himi <lironh@marvell.com>
Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>, dpdk-dev <dev@dpdk.org>
Content-Type: text/plain; charset="UTF-8"
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
<mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
<mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
On Mon, Dec 6, 2021 at 12:24 PM Liron Himi <lironh@marvell.com> wrote:
>
> Hi,
>
> This patch is not just for map update.
> what about all other changes?
1) roc_ree.c is added in this patch to build. It should be moved to
the first patch where thing started building
+ 'roc_ree.c',
2) All other minor changes in this patch can be squashed to respective patches.
>
> Liron Himi
>
>
>
> Park Azorim, Kyriat Arie, Petah Tikva, 49527, Israel
> Mobile: +972.52.3329169
>
> -----Original Message-----
> From: Jerin Jacob <jerinjacobk@gmail.com>
> Sent: Monday, 6 December 2021 07:08
> To: Liron Himi <lironh@marvell.com>
> Cc: Jerin Jacob Kollanukkaran <jerinj@marvell.com>; dpdk-dev <dev@dpdk.org>
> Subject: [EXT] Re: [PATCH v3 4/5] common/cnxk: link REE support to ROC files
>
> External Email
>
> ----------------------------------------------------------------------
> On Tue, Nov 30, 2021 at 1:30 AM <lironh@marvell.com> wrote:
> >
> > From: Liron Himi <lironh@marvell.com>
> >
> > add references to REE files from ROC files
> >
> > Signed-off-by: Liron Himi <lironh@marvell.com>
> > ---
> > cnxk_logtype_nix;
> > cnxk_logtype_npa;
> > cnxk_logtype_npc;
> > + cnxk_logtype_ree;
> > cnxk_logtype_sso;
> > cnxk_logtype_tim;
> > cnxk_logtype_tm;
> > @@ -347,6 +348,21 @@ INTERNAL {
> > roc_tim_lf_enable;
> > roc_tim_lf_free;
> > roc_se_ctx_swap;
> > -
> > + roc_ree_af_reg_read;
> > + roc_ree_af_reg_write;
> > + roc_ree_config_lf;
> > + roc_ree_dev_fini;
> > + roc_ree_dev_init;
> > + roc_ree_err_intr_register;
> > + roc_ree_err_intr_unregister;
> > + roc_ree_iq_disable;
> > + roc_ree_iq_enable;
> > + roc_ree_msix_offsets_get;
> > + roc_ree_qp_get_base;
> > + roc_ree_queues_attach;
> > + roc_ree_queues_detach;
> > + roc_ree_rule_db_get;
> > + roc_ree_rule_db_len_get;
> > + roc_ree_rule_db_prog;
>
>
> We don't update .map files in a separate patch. Please update this to the respective patch.
> In short, this 4/5 patch can be squashed to respective patches.
> Rest looks good to me. We can merge the next version if there are no other comments.
>
>
> > local: *;
> > };
> > --
> > 2.28.0
> >