From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9D14CA034E; Thu, 4 Jun 2020 08:31:06 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C7E191D5E2; Thu, 4 Jun 2020 08:31:05 +0200 (CEST) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by dpdk.org (Postfix) with ESMTP id 6D7731D5DA for ; Thu, 4 Jun 2020 08:31:04 +0200 (CEST) Received: by mail-io1-f49.google.com with SMTP id y5so5052385iob.12 for ; Wed, 03 Jun 2020 23:31:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=GxjYRMUxryBc9oixOzzwWvk4vxXQtqab+SG8/j37Tc4=; b=Yevqz10ECMwiRYpk+BPAMLnu01ufrSdmVdxNAtR52C6OpU0oiIpe9/m0UReLjfqvLH Qdv2cB32sGhtVXEKv+0StBTsIn/lZB0cZeGn4SsuxrtwK33xUYNdcPxVmadMTUCqph7B nzlmca03wdTpou1IIcZbAPanAHVU3Asa2+pmWfQDl+3/t3awXUpd/9VpTyOboq8+sgm7 CK0ktUTDb3BLS0tQ5zyVIM8qmLH1xqDlOBrWv98HxzeXW6MO/7RUhHxkdctgjPEJCxIA vbDpM2KLm2xRMs1HXnBoikzW6w39FpTjxREDaJRGnH3nhrfhIUzjwEJOEU+xOSMK63w+ 07Sg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=GxjYRMUxryBc9oixOzzwWvk4vxXQtqab+SG8/j37Tc4=; b=mhjIy5xT/Pbx2Ny6zXfWFLXE7mL+pPpQlkduQtU759quM+3gevGnLIZcmeuLTJsSV+ 8P3J0pBuIzZW70OGTmM3KZJ/pa6ysiqdRRNztpUKUAE24IPlkEEvrkoeRG+/hjuq9zlB HTZut1bY1WasHplB8KmvxQRWyurvuxhGeabhaAa0EIHj2YJJa+GeGC+/HrL8oQ0AT/60 tTywLG0RHaiVPzN5CslNRabsPqjze9MaArWE3UwuF4FqeKYjQE+BKzXYhmembo5l0G+x WwEX/lSTeA9ZBaQx0Inl2XWJaArdQTHepaWq5Gl/BU6UJwXbpdqBpnjf9lepS0U928l9 jtXA== X-Gm-Message-State: AOAM533OaFJOq11+6paAW7DFwub35eocRJ1kwZplFMBIFr28Cy3K3iCs S8nz88u/iJDC0jqqNbV8Pc0c/FW+72NVErrcBp4= X-Google-Smtp-Source: ABdhPJwbTOsxAVHwfEGZvp/1n0I+BymNsDZc5YSrdNGS7IyRB8M6P40uiqYIwDbAYD0Fnboz3jYF+wbbZgmrXvFaJNw= X-Received: by 2002:a02:942e:: with SMTP id a43mr2982478jai.113.1591252263524; Wed, 03 Jun 2020 23:31:03 -0700 (PDT) MIME-Version: 1.0 References: <1591219752-46544-1-git-send-email-orika@mellanox.com> In-Reply-To: From: Jerin Jacob Date: Thu, 4 Jun 2020 12:00:47 +0530 Message-ID: To: Ori Kam Cc: Jerin Jacob , Wang Xiang , Guy Kaneti , dpdk-dev , Pavan Nikhilesh , Shahaf Shuler , Hemant Agrawal , Opher Reviv , Alex Rosenbaum , Dovrat Zifroni , Prasun Kapoor , Nipun Gupta , "Richardson, Bruce" , "yang.a.hong@intel.com" , "harry.chang@intel.com" , "gu.jian1@zte.com.cn" , "shanjiangh@chinatelecom.cn" , "zhangy.yun@chinatelecom.cn" , "lixingfu@huachentel.com" , "wushuai@inspur.com" , "yuyingxia@yxlink.com" , "fanchenggang@sunyainfo.com" , "davidfgao@tencent.com" , "liuzhong1@chinaunicom.cn" , "zhaoyong11@huawei.com" , "oc@yunify.com" , Jim Thompson , "hongjun.ni@intel.com" , "j.bromhead@titan-ic.com" , "deri@ntop.org" , "fc@napatech.com" , "arthur.su@lionic.com" , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application. X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jun 4, 2020 at 11:21 AM Ori Kam wrote: > > Hi Jerin, HI Ori, > > > -----Original Message----- > > From: Jerin Jacob > > Sent: Thursday, June 4, 2020 7:56 AM > > Subject: Re: [dpdk-dev] [RFC] app/test-regex: add RegEx test application. > > > > On Thu, Jun 4, 2020 at 2:59 AM Ori Kam wrote: > > > > > > Following the new RegEx class [1]. > > > There is a need to create a dedecated test application in order to > > > validate this class and PMD. > > > > > > Unlike net device this application loads data from a file. > > > > > > This commit introduce the new RegEx test app. > > > > > > The basic app flow: > > > 1. query probed RegEx device. > > > 2. configure the probed device accoding to the device caps. > > > 3. read a rule database file. > > > 4. read a data file to be searched. > > > 5. allocate one mbuf. > > > 6. select the request job len, based on the number of jobs requsted. > > > 7. create one RegEx op which uses the mbuf defined in step 5. > > > 8. attach the data buffer at offset 0 with len accoding to request > > > len to the mbuf as external buffer. > > > 9. enqueue one job. > > > 10. wait for completion of the job. > > > 11. check job results and print them. > > > 12. move the mbuf to point to the next part of the buffer. > > > 13. while there are more parts jump to 9. > > > > > > Future improvments to this application may include: > > > 1. submiting more then one job at a time. > > > 2. working with more then one queue. > > > 3. support out of order. > > > 4. allow runtime rule updating. > > > > > > This commit is only at RFC level, which means that > > > the code is only basic reference and can't be compiled and doesn't > > > include error or edge case handling. > > > > > > > > [1]https://eur03.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatche > > s.dpdk.org%2Fcover%2F69919%2F&data=02%7C01%7Corika%40mellanox. > > com%7C777869b8df174845154008d80843aa33%7Ca652971c7d2e4d9ba6a4d1 > > 49256f461b%7C0%7C0%7C637268433993878386&sdata=GzSEh6O0rqPHBl > > OtkTGx3j6VGOdVykga2zYsuyK%2BxtM%3D&reserved=0 > > > > > > Signed-off-by: Ori Kam > > > > IMO, this kind simile application with fixed-function can go in the > > example folder. > > I think, for app/test-regex, it better to have a framework to add new > > tests, modes, parse the modes, etc. > > Please see git log app/test-eventdev/ initial check-ins for the > > skeleton as a reference > > Currently all dedicateded tests for example, the crypto are located in this folder. > As I see it the example folder is used for simple programs to be used as a reference, while this app should be used to test the > RegEx class, I assume it will get much more functionality to support all test modes. Yes. We are on the same, What I meant is to create a framework for adding testcase and options first before addingthe test so that it can scale. see as just reference app/test-eventdev/evt_test.h app/test-eventdev/evt_options.h > > Best, > Ori > >