From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 65BBCA04B1; Mon, 5 Oct 2020 18:10:29 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3D50A1B74B; Mon, 5 Oct 2020 18:10:27 +0200 (CEST) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id B5F601B737 for ; Mon, 5 Oct 2020 18:10:25 +0200 (CEST) Received: by mail-il1-f193.google.com with SMTP id l16so8269748ilt.13 for ; Mon, 05 Oct 2020 09:10:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=TbTZqwEml3VIJZLOgpSIEIG317BrntsCk68wBybh9+8=; b=orEW/vPFQ0PSVehrqBdgteyEqCoN4OluNR903HHf6NPcdR0I/+8qiZI/x8oxexlt6a CTFJAxHfOvaI+b34dId92uGCL4+zif5pq6/IqAmWcgnqjdrctG22H32Lf3ryCYsZK6Kw Hp625DIsfA8Ogmq10nQ6k1JX/UMSOZLEo8TX2+G+fZFYyzg0tNL6uz9FY0nfeVlDKbbj /0v9AyVmUoy+4jXZmlIhnlAK/xyy7Cbr7bJ5QGOEmspHfsCtCJyHzCWKyqDzxMfaP8vT vwQIUEQ0WWBKPVPIBeHLjBmpk6E1RmOZCS47sPtBui32S3EHpA8W7ssAR4yuJt4QWXKe HDFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=TbTZqwEml3VIJZLOgpSIEIG317BrntsCk68wBybh9+8=; b=uliPzT+h7hm44e5QnyVknovvDs18o5xd4gWKYVF2GfuF3YShRl1Bn12hgD73KnfSGY ZjQtxlzSl3011gMqpfJAhR64bniqYSAk4V6YuAcZaHwxnI2+5EUV27aRcFTP9w4lLB1M X6gUJ/HnTzpKXgIyKt6KHy7sQnfCksYOfNRhbQSQ/X53URxqXjZ6a20kyYVXUP7N/noT MlLtieymRPBS4Yj0DDIuF8CueebzcOPwAtTGc014LSU/bz5yT43oEoSFgpg1EFJhosLP ST7Eccd3kXIeXZxAtYONK0hculQ/3jZwu1ypxrrzqEO0hM5j2vLKUBiivtj8LDnbWBdY c3tg== X-Gm-Message-State: AOAM5305twz2YBb9cK8JmIYPQENIQQ3Dx/6Mw3BkQUrKBcrhG8XFpKja IHmlSnCh4tcv0Yi4gwn1x6ULKkyyOYN+BTHjN9Y= X-Google-Smtp-Source: ABdhPJyqdRkP2j+jFZ0JsjRdgE+utopOayJRDyPXMhCq01WgEexa1ypHYSwr9QnnxootjBjUWEOdHoM63feCyiw8/Xw= X-Received: by 2002:a92:c910:: with SMTP id t16mr106869ilp.60.1601914223946; Mon, 05 Oct 2020 09:10:23 -0700 (PDT) MIME-Version: 1.0 References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201005071506.28861-1-nipun.gupta@nxp.com> <20201005083455.2fdf57f2@hermes.local> In-Reply-To: <20201005083455.2fdf57f2@hermes.local> From: Jerin Jacob Date: Mon, 5 Oct 2020 21:40:07 +0530 Message-ID: To: Stephen Hemminger Cc: Nipun Gupta , dpdk-dev , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Hemant Agrawal , Sachin Saxena , rohit.raj@nxp.com Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/3 v2] ethdev: add rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Oct 5, 2020 at 9:05 PM Stephen Hemminger wrote: > > On Mon, 5 Oct 2020 12:45:04 +0530 > nipun.gupta@nxp.com wrote: > > > From: Nipun Gupta > > > > This change adds a RX offload capability, which once enabled, > > hardware will drop the packets in case there of any error in > > the packet such as L3 checksum error or L4 checksum. IMO, Providing additional support up to the level to choose the errors to drops give more control to the application. Meaning, L1 errors such as FCS error L2 errors .. L3 errors such checksum i.e ethdev spec need to have error level supported by PMD and the application can set the layers interested to drop. > > > > Signed-off-by: Nipun Gupta > > Signed-off-by: Rohit Raj > > --- > > These patches are based over series: > > https://patchwork.dpdk.org/patch/78630/ > > > > Changes in v2: > > - Add support in DPAA1 driver (patch 2/3) > > - Add support and config parameter in testpmd (patch 3/3) > > > > lib/librte_ethdev/rte_ethdev.h | 1 + > > 1 file changed, 1 insertion(+) > > Maybe this should be an rte_flow match/action which would then make it > more flexible? I think, it is not based on any Patten matching. So IMO, it should be best if it is part of RX offload. > > There is not much of a performance gain for this in real life and > if only one driver supports it then I am not convinced this is needed. Marvell HW has this feature.