From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DEEEE43F85; Sat, 4 May 2024 12:04:23 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B03DF402D5; Sat, 4 May 2024 12:04:23 +0200 (CEST) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id 704524014F for ; Sat, 4 May 2024 12:04:22 +0200 (CEST) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-43692353718so3538501cf.0 for ; Sat, 04 May 2024 03:04:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714817062; x=1715421862; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=jVTU7R5YpCk3p1VXbmko5zBNxXpmH8R0oiclIuqVHAA=; b=ezFkKquHHgwD9VlBp73rpS+yGwsrkmiKD8lwz2RSArDxb33qNFsgn8fscPen2x6Yny CDnmN4i/mpBgLbeIRv4a7YmFAj7KLr6dC4A4O5erGVZmJCxGKw+LobHEBH/xj0FHzIVV 7VKcBmKgL+ieAmFJup339orLCGJWVYeCoce3xS2vkOM1wTXF22E6GLWKbGGejeqiW5Oe 3v16kOWdzGROsYdhDbfFSQQwPitm/vZtgibaPdyUuZZTd8K5n1ZaKrteRAafyzywHdIt gAu/1feoHpL5Fgxa1/m/oqtNUEV2RKnoB8Z74J4ajhAj+Bj6bD9mEPxfzENqPqP7N+Jg OUjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714817062; x=1715421862; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jVTU7R5YpCk3p1VXbmko5zBNxXpmH8R0oiclIuqVHAA=; b=YJnHLGXZZR83kOSf+gXCuV58aMTSBLxNSl/ahcstxJcp1K8dJnQvmcDt6z0W4f5TOp QQfjtUlhKSDCM5U8oMgAHZfPLmV0mfmLTxGVqZK2FuGIrPHMFeqSAVuv1DMLiX/1X0VU hrAwK/W7b1x2yB7cP793TPpogl8zeIDyZzvqnqbD5tWYqN0n7hZrymYxBG0/KYdW1o4I 8JkBE/mwZ+zpAmlS/yooY9SL+qQeBLIQV/Qymb0uLuyJnOwYcR53mw6hJKjpiE0kFwyE opYb8GEqpeIEKhBF2l+Wa7wNQ3QDpQ4UuQD+VvQWxrSIdIDY8dmbGxab7CmTM+k7D1No E+dw== X-Gm-Message-State: AOJu0Yw2Co00E3Nn+/zsxDoZncPbYR+t9kseL+T4ciNL0/k+b5T0UJK4 Wpc0dNKdlZVuIkNYzMrPPU7pfAt90Hhso211XfeKp1UDrmH/EpC4VodC6BlNmv/q7CM/b73Epze Dvw8N+mDyR1K5J61cn24IBlznitU= X-Google-Smtp-Source: AGHT+IGot2d0gvG/+ytYW+0D/Ef2pGMXAxQF1et4jBQ1x9zXFQgJl+SPDEK1Zwzh5NKtih7Qu1Ozflvz4y4y+aoEsV4= X-Received: by 2002:ac8:57c4:0:b0:43a:f1c8:f18e with SMTP id w4-20020ac857c4000000b0043af1c8f18emr4956531qta.10.1714817061628; Sat, 04 May 2024 03:04:21 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Jerin Jacob Date: Sat, 4 May 2024 15:33:54 +0530 Message-ID: Subject: Re: [RFC] graph/node: feedback and future improvements To: Robin Jarry Cc: dev@dpdk.org, Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , Pavan Nikhilesh , Thomas Monjalon Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 24, 2024 at 6:54=E2=80=AFPM Robin Jarry wro= te: > > Robin Jarry, Apr 14, 2024 at 12:35: > > Jerin Jacob, Apr 06, 2024 at 01:11: > > > Great. > > > > > > You may consider improving and/or adding inbuilt nodes for generic > > > protocol processing. Furthermore, consider contributing on app/graph. > > > I think, most likely, you should be able to leverage app/graph. > > > > Thanks! I am definitely planning to upstream nodes into DPDK as much as > > possible. I still need to determine what is the correct level of data > > path node public API so that the nodes can be agnostic of the control > > plane implementation. > > Hey Jerin, > > while working on ARP support [1], I noticed that we need to have > configurability of nodes (or set of nodes to be more precise) from the > outside. But the nodes in the set also need to specify metadata that > they expect from other nodes to store in mbufs. > > For now, I have used a single dynamic field which I repurpose for every > node set depending on the use case [2]. However this raises a question: > how can we make it generic (and agnostic to the application) before > inclusion in lib/node? > > I would be glad to have your opinion on the subject. Looking at the brouter[1] project, Based on my understanding it has followi= ng 1)Data plane code: IMO, Since it is generic and any consumers can reuse this code. IMO, We can make as generic and upstream to lib/node. 2)Control plane code: IMO, if you are willing, I will be glad to see it is hosted at https://www.dpdk.org/hosted-projects/ like pktgen. This may attract more developers for control plane code for brouter and show good reference of using DPDK graph library. I think, TB needs to approve for this. If you are OK, We can add this to one of TB meeting agenda. [1] https://github.com/rjarry/brouter/ > Cheers! > > [1] https://github.com/rjarry/brouter/commit/e05246f51b736821b6689d40 > [2] https://github.com/rjarry/brouter/blob/main/modules/infra/datapath/br= _mbuf.h >