From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E588D440A7; Thu, 23 May 2024 16:13:41 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7242B402B3; Thu, 23 May 2024 16:13:41 +0200 (CEST) Received: from mail-qt1-f178.google.com (mail-qt1-f178.google.com [209.85.160.178]) by mails.dpdk.org (Postfix) with ESMTP id 2697D4026C for ; Thu, 23 May 2024 16:13:40 +0200 (CEST) Received: by mail-qt1-f178.google.com with SMTP id d75a77b69052e-43e1593d633so15403691cf.3 for ; Thu, 23 May 2024 07:13:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716473619; x=1717078419; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=KazmZHnOCSDCZux4DVGaLxb5UaCKD1RgZ/cQN+HTnLA=; b=DHcOwP3LGhaP8J5smpYKRvr3tgjD0mspmnI2r6E2LjaSJP5+PxKvdjmbbB0BIQKgJA l1W3/50i+Hj7sDywRX5WcC9wZGXkjWe4a6aspi4aKYXxiNl2Ta4P+eoQ/jQ609W/2JPR 2KKWQ6prn4a1qhjcizgpWPd/JZ83Mw9eSj5qh0GXJ976fyfSaSQKDJEEK+F3oHxSjMW+ UAyjynE4s/7w7zDSxTydxjeleZ9SIyU4pYmEg/0KksJWJfVPIhXpf0wE2nMF1TXokKi3 74FH2lIji+Q8vpr2a8brvMuYkNOUEHGid3CPt40TIZmnExetwKAcg7a35/GaH5yoZgdo n49Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716473619; x=1717078419; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KazmZHnOCSDCZux4DVGaLxb5UaCKD1RgZ/cQN+HTnLA=; b=hSqODUYMGtlt1L19ISW1JB5SXTFTDXOD3c3Ngmp6EDFvQtAN1R6jxwLW5S5E0ewyRN jrUjG5KLmcF8nduE97CuITrfS88NkPgW/RFGF5Z1SCfCLgiapvcnwpvXyjoYEn4NBIzW gfxzZHSuDsU2NbPC98JUCyj47uXJawrfuEZ+Ds79PiIQsw95oEF2zE/IhnnqN/O44KEQ ENQBUs5aZ3YxL+TtjEIAvP/WPRPKbeMHexPpI2tO/tR8SIKpVbHe8WWSbkQUDQEVuY0A MSMA24Ttds7lppo0EpbxBrD6jSdYEQ8Pl/NJsYpjgwK3boNd58JDX0v27tFEnlA9+HrV 0YXQ== X-Forwarded-Encrypted: i=1; AJvYcCXC31WEOIxLbJhDC0IngEdMXl//6M2kwqzceGbtBvtah9E+4OYe/26ayhCSJcl4c6KnieBDuirn93baTi0= X-Gm-Message-State: AOJu0Ywlt7qPcsbiRNTeZj+GMGqYR3Uqrrm6EuVhLm5js6ocfQGHhjS+ GQB86uPbD5VFzA7cIeOLIiAkDeACKahslNo/S0+MhTQq7MtFHJBxO8D9nQMC1vqaY6TMQI9ljoR HrCYiMylXlSC2RIEgSqlPZEIeWywTzQ== X-Google-Smtp-Source: AGHT+IENC7cqZanRgYFZd4zG3RAt4fDgsAAgEhC7JHL9eK9O7QOkQBfjEceXN5NDwaXrZfMtwz1VGeu5OVShFVtZCLU= X-Received: by 2002:ac8:5f47:0:b0:43e:3b8e:670f with SMTP id d75a77b69052e-43f9e1ab4bemr58431621cf.43.1716473619248; Thu, 23 May 2024 07:13:39 -0700 (PDT) MIME-Version: 1.0 References: <20240410131127.2482240-1-skori@marvell.com> In-Reply-To: <20240410131127.2482240-1-skori@marvell.com> From: Jerin Jacob Date: Thu, 23 May 2024 19:43:11 +0530 Message-ID: Subject: Re: [PATCH] net/cnxk: add RSS config via ethdev configure API To: skori@marvell.com Cc: Nithin Dabilpuram , Kiran Kumar K , Satha Rao , Harman Kalra , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Apr 10, 2024 at 6:41=E2=80=AFPM wrote: > > From: Sunil Kumar Kori > > Currently user passed RSS configuration is ignored via > rte_eth_dev_configure() API. Instead default RSS setup is done by > driver. Rewrite the git commit as fix and add Fixes: tag > > Adding handling for user passed RSS configuration too via > rte_eth_dev_configure(). > > Signed-off-by: Sunil Kumar Kori > --- > drivers/net/cnxk/cnxk_ethdev.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/drivers/net/cnxk/cnxk_ethdev.c b/drivers/net/cnxk/cnxk_ethde= v.c > index 6b37bd877f..95a3d8aaf9 100644 > --- a/drivers/net/cnxk/cnxk_ethdev.c > +++ b/drivers/net/cnxk/cnxk_ethdev.c > @@ -1384,6 +1384,13 @@ cnxk_nix_configure(struct rte_eth_dev *eth_dev) > goto free_nix_lf; > } > > + /* Overwrite default RSS setup if requested by user */ > + rc =3D cnxk_nix_rss_hash_update(eth_dev, &conf->rx_adv_conf.rss_c= onf); > + if (rc) { > + plt_err("Failed to configure rss rc=3D%d", rc); > + goto free_nix_lf; > + } > + > /* Init the default TM scheduler hierarchy */ > rc =3D roc_nix_tm_init(nix); > if (rc) { > -- > 2.25.1 >