From: Jerin Jacob <jerinjacobk@gmail.com>
To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
Cc: Shijith Thotton <sthotton@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] app/test-eventdev: wait for workers before cryptodev destroy
Date: Mon, 13 Jun 2022 12:29:35 +0530 [thread overview]
Message-ID: <CALBAE1OR4w_ob9th5meL05MKOwHViZSa8gc-_Qg1i3VD=xUcBg@mail.gmail.com> (raw)
In-Reply-To: <PH0PR18MB40864950B6576EFD4B34CE3EDEAB9@PH0PR18MB4086.namprd18.prod.outlook.com>
On Mon, Jun 13, 2022 at 12:08 PM Pavan Nikhilesh Bhagavatula
<pbhagavatula@marvell.com> wrote:
>
>
>
> > -----Original Message-----
> > From: Shijith Thotton <sthotton@marvell.com>
> > Sent: Thursday, June 2, 2022 5:15 PM
> > To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
> > Cc: Shijith Thotton <sthotton@marvell.com>; dev@dpdk.org; Pavan
> > Nikhilesh Bhagavatula <pbhagavatula@marvell.com>
> > Subject: [PATCH] app/test-eventdev: wait for workers before cryptodev
> > destroy
> >
> > Destroying cryptodev resources before exiting workers are not safe.
> > Moved cryptodev destroy after worker thread exit in main thread.
> >
> > Fixes: de2bc16e1bd1 ("app/eventdev: add crypto producer mode")
Cc: stable@dpdk.org
> >
> > Signed-off-by: Shijith Thotton <sthotton@marvell.com>
>
> Acked-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-eventdev/for-main. Thanks
>
> > ---
> > app/test-eventdev/evt_main.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/app/test-eventdev/evt_main.c b/app/test-eventdev/evt_main.c
> > index c5d63061bf..b785e603ee 100644
> > --- a/app/test-eventdev/evt_main.c
> > +++ b/app/test-eventdev/evt_main.c
> > @@ -159,9 +159,6 @@ main(int argc, char **argv)
> > if (test->ops.ethdev_rx_stop)
> > test->ops.ethdev_rx_stop(test, &opt);
> >
> > - if (test->ops.cryptodev_destroy)
> > - test->ops.cryptodev_destroy(test, &opt);
> > -
> > rte_eal_mp_wait_lcore();
> >
> > if (test->ops.test_result)
> > @@ -173,6 +170,9 @@ main(int argc, char **argv)
> > if (test->ops.eventdev_destroy)
> > test->ops.eventdev_destroy(test, &opt);
> >
> > + if (test->ops.cryptodev_destroy)
> > + test->ops.cryptodev_destroy(test, &opt);
> > +
> > if (test->ops.mempool_destroy)
> > test->ops.mempool_destroy(test, &opt);
> >
> > --
> > 2.25.1
>
prev parent reply other threads:[~2022-06-13 7:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 11:45 Shijith Thotton
2022-06-13 6:38 ` Pavan Nikhilesh Bhagavatula
2022-06-13 6:59 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1OR4w_ob9th5meL05MKOwHViZSa8gc-_Qg1i3VD=xUcBg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=sthotton@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).