From: Jerin Jacob <jerinjacobk@gmail.com>
To: Rasesh Mody <rmody@marvell.com>, Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Igor Russkikh <irusskikh@marvell.com>,
Balazs Nemeth <bnemeth@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Devendra Singh Rawat <dsinghrawat@marvell.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v2] net/qede: fix regression introduced by b10231aed1ed
Date: Thu, 14 Jan 2021 18:59:39 +0530 [thread overview]
Message-ID: <CALBAE1ORj6OdAi8t2iPw1eEchETVUGPydk7C3+S3-hep27Yxog@mail.gmail.com> (raw)
In-Reply-To: <BYAPR18MB2838BA3F849DC60470C2BD1BB5AA9@BYAPR18MB2838.namprd18.prod.outlook.com>
On Tue, Jan 12, 2021 at 11:25 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> > From: Jerin Jacob <jerinjacobk@gmail.com>
> > Sent: Tuesday, January 12, 2021 10:21 AM
> >
> > On Mon, Jan 4, 2021 at 7:47 PM Rasesh Mody <rmody@marvell.com> wrote:
> > >
> > > > From: dev <dev-bounces@dpdk.org> On Behalf Of Igor Russkikh
> > > > Sent: Monday, January 4, 2021 6:15 PM
> > > >
> > > > > When calling rte_eth_promiscuous_enable(port_id) followed by
> > > > > rte_eth_allmulticast_enable(port_id), the port is not in promisc
> > > > > mode anymore. This patch ensures that promisc mode takes
> > > > > precedence over allmulticast mode fixing the regression introduced by
> > b10231aed1ed.
> >
> > Please add Fixes:
> >
> > > > >
> > > > > Signed-off-by: Balazs Nemeth <bnemeth@redhat.com>
> >
>
> Even if promiscuous mode is disabled after the change, allmulti mode setting will persist.
> Fix looks good to me.
>
> Acked-by: Rasesh Mody <rmody@marvell.com>
Fixed check-git-log.sh issues and applied to dpdk-next-net-mrvl/for-main. Thanks
>
> Thanks,
> Rasesh
>
> > > > Igor
>
prev parent reply other threads:[~2021-01-14 13:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-23 14:15 [dpdk-dev] " Balazs Nemeth
2021-01-04 12:44 ` Igor Russkikh
2021-01-04 14:17 ` [dpdk-dev] [EXT] " Rasesh Mody
2021-01-12 4:50 ` Jerin Jacob
2021-01-12 5:55 ` Rasesh Mody
2021-01-14 13:29 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1ORj6OdAi8t2iPw1eEchETVUGPydk7C3+S3-hep27Yxog@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=bnemeth@redhat.com \
--cc=dev@dpdk.org \
--cc=dsinghrawat@marvell.com \
--cc=ferruh.yigit@intel.com \
--cc=irusskikh@marvell.com \
--cc=rmody@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).