Re: [PATCH v1] graph: remove the useless duplicate name check

[Jerin Jacob <jerinjacobk@gmail.com>]

On Mon, Mar 7, 2022 at 12:47 PM Haiyue Wang <haiyue.wang@intel.com> wrote:
>
> The node clone API parameter 'name' is the new node's postfix name, not
> the final node name, so it makes no sense to check it. And the new name
> will be checked duplicate when calling API '__rte_node_register'.
>
> Signed-off-by: Haiyue Wang <haiyue.wang@intel.com>

Could you check the test failure with this change?
Reproducer:

echo "graph_autotest" | ./build/app/test/dpdk-test -c 0x30 --no-huge

> ---
>  lib/graph/node.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/lib/graph/node.c b/lib/graph/node.c
> index 79230035a2..ae6eadb260 100644
> --- a/lib/graph/node.c
> +++ b/lib/graph/node.c
> @@ -150,10 +150,6 @@ node_clone(struct node *node, const char *name)
>                 goto fail;
>         }
>
> -       /* Check for duplicate name */
> -       if (node_has_duplicate_entry(name))
> -               goto fail;
> -
>         reg = calloc(1, sizeof(*reg) + (sizeof(char *) * node->nb_edges));
>         if (reg == NULL) {
>                 rte_errno = ENOMEM;
> --
> 2.35.1
>