DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Bruce Richardson <bruce.richardson@intel.com>,
	dpdk-dev <dev@dpdk.org>,
	 David Marchand <david.marchand@redhat.com>,
	Ferruh Yigit <ferruh.yigit@intel.com>,
	 Olivier Matz <olivier.matz@6wind.com>,
	Morten Brørup <mb@smartsharesystems.com>,
	 "Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
	 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
	 Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
	Ajit Khaparde <ajit.khaparde@broadcom.com>,
	 Jerin Jacob <jerinj@marvell.com>,
	Hemant Agrawal <hemant.agrawal@nxp.com>,
	 Ray Kinsella <mdr@ashroe.eu>,
	Neil Horman <nhorman@tuxdriver.com>,
	 Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	 Ali Alnubani <alialnu@nvidia.com>,
	rasland@nvidia.com
Subject: Re: [dpdk-dev] [PATCH 1/1] mbuf: move pool pointer in first half
Date: Mon, 9 Nov 2020 20:23:25 +0530
Message-ID: <CALBAE1OShTSzhdBsA5aAi1BB_ozA2y=BTGKMdvNQ591e0sMWDg@mail.gmail.com> (raw)
In-Reply-To: <3413133.us5WgodGNe@thomas>

On Mon, Nov 9, 2020 at 8:12 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 09/11/2020 15:08, Jerin Jacob:
> > On Mon, Nov 9, 2020 at 7:32 PM Thomas Monjalon <thomas@monjalon.net> wrote:
> > > 09/11/2020 14:35, Jerin Jacob:
> > > > Are you facing the issue with 32bit? Could you share the steps to
> > > > reproduce and gcc version?
> > >
> > > Oh you're right, the issue was with 32-bit build,
> >
> > Thanks
> >
> > > sorry for the confusion.
> >
> > >
> > > > --- a/drivers/net/octeontx2/otx2_ethdev.c
> > > > +++ b/drivers/net/octeontx2/otx2_ethdev.c
> > > > @@ -749,7 +749,7 @@ nix_tx_offload_flags(struct rte_eth_dev *eth_dev)
> > > >         RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, pkt_len) !=
> > > >                          offsetof(struct rte_mbuf, ol_flags) + 12);
> > > >         RTE_BUILD_BUG_ON(offsetof(struct rte_mbuf, tx_offload) !=
> > > > -                        offsetof(struct rte_mbuf, pool) + 2 * sizeof(void *));
> > > > +                        offsetof(struct rte_mbuf, pool) + 2 * sizeof(uint64_t));
> > >
> > > The actual "fix" is
> > > offsetof(struct rte_mbuf, pool) + sizeof(uint64_t) + sizeof(void *)
> > >
> > > I don't understand the octeontx2 vector code.
> > > Please check what is the impact of this offset change.
> >
> > Tested the changes, No issue seen. All the expectation of vector code
> > is expressed with RTE_BUILD_BUG_ON.
> >
> > > BTW, is 32-bit build really supported with octeontx2?
> >
> > No. I think, keeping assert as "sizeof(void *)"(Same as now) and remove build
> > support for 32bit works too for octeontx2.
>
> OK, I think it's better than tweaking RTE_BUILD_BUG_ON for
> something not really supported.
>
> > We will add it when really required.
>
> Then I'm going to send a patch to disable octeontx2 drivers on 32-bit.

OK.

>
> Note there is another build issue with octeontx2 drivers on CentOS/RHEL 7
> with Arm GGC 4.8.

It is a segfault from the compiler. In Makefile, we have skipped
building < 4.9, not sure what needs to be done
for meson.



>
>

  reply	other threads:[~2020-11-09 14:53 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-07 15:53 Thomas Monjalon
2020-11-07 17:12 ` Jerin Jacob
2020-11-07 18:39   ` Thomas Monjalon
2020-11-07 19:05     ` Jerin Jacob
2020-11-07 20:33       ` Thomas Monjalon
2020-11-09  5:18         ` Jerin Jacob
2020-11-09  8:04           ` Thomas Monjalon
2020-11-09  8:27             ` Jerin Jacob
2020-11-09  9:47               ` Bruce Richardson
2020-11-09 12:01                 ` Jerin Jacob
2020-11-09 12:59                   ` Thomas Monjalon
2020-11-09 13:35                     ` Jerin Jacob
2020-11-09 14:02                       ` Thomas Monjalon
2020-11-09 14:08                         ` Jerin Jacob
2020-11-09 14:42                           ` Thomas Monjalon
2020-11-09 14:53                             ` Jerin Jacob [this message]
2020-11-09  8:16           ` Morten Brørup
2020-11-09 10:06             ` [dpdk-dev] [dpdk-techboard] " Bruce Richardson
2020-11-09 10:21               ` Morten Brørup
2020-11-09 18:04                 ` Stephen Hemminger
2020-11-10  7:15                   ` Morten Brørup
2020-11-07 18:57 ` [dpdk-dev] " Morten Brørup
2020-11-09 10:08   ` Bruce Richardson
2020-11-09 10:30     ` Morten Brørup
2020-11-09 10:33     ` Ananyev, Konstantin
2020-11-09 10:36       ` Bruce Richardson
2020-11-09 11:24       ` Ananyev, Konstantin
2020-11-09 21:29 ` [dpdk-dev] [PATCH v2 0/2] move mbuf pool pointer Thomas Monjalon
2020-11-09 21:29   ` [dpdk-dev] [PATCH v2 1/2] drivers: disable OCTEON TX2 in 32-bit build Thomas Monjalon
2020-11-10 18:05     ` Jerin Jacob
2020-11-09 21:29   ` [dpdk-dev] [PATCH v2 2/2] mbuf: move pool pointer in first half Thomas Monjalon
2020-11-10 10:05     ` Morten Brørup
2020-11-10 10:44       ` Thomas Monjalon
2020-11-10 16:25     ` Olivier Matz
2020-11-10 18:06       ` Jerin Jacob
2020-11-12 14:39         ` Thomas Monjalon
2020-11-10 18:08       ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CALBAE1OShTSzhdBsA5aAi1BB_ozA2y=BTGKMdvNQ591e0sMWDg@mail.gmail.com' \
    --to=jerinjacobk@gmail.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=alialnu@nvidia.com \
    --cc=andrew.rybchenko@oktetlabs.ru \
    --cc=bruce.richardson@intel.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jerinj@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=mb@smartsharesystems.com \
    --cc=mdr@ashroe.eu \
    --cc=ndabilpuram@marvell.com \
    --cc=nhorman@tuxdriver.com \
    --cc=olivier.matz@6wind.com \
    --cc=rasland@nvidia.com \
    --cc=thomas@monjalon.net \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git