From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C662FA04B5; Tue, 12 Jan 2021 19:14:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 84F1E140F07; Tue, 12 Jan 2021 19:14:02 +0100 (CET) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mails.dpdk.org (Postfix) with ESMTP id 265A1140F06; Tue, 12 Jan 2021 19:14:01 +0100 (CET) Received: by mail-io1-f49.google.com with SMTP id z5so5974412iob.11; Tue, 12 Jan 2021 10:14:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=vTCsjFJIEA5sMU46xx2C2RojTH9g6BEuwCRX2qWKk8A=; b=FsTOEu5TRjwI8j4vntDBrPtYqX8xwgsz7OhR2iz4kXwyPBU1NmmD/+5IrQlRrhV8gV ctpkUbtfz75ZjpyLshD2r8jXRbtBudpip+wJtGn89y4/q4kOxTAmj1OLvoyN8rMeXOn/ 8WQH7ZrBnomIEDp9lhlJzuyKlpbe3chOSJoIEt/B6Bur9RGFbEFv8c0VoxP8+oqjNin3 BVHyBm2MH30weeq3QGrezP/QlFb+L5PZ42/w802xL9pd7MGL12ZytRnWR6aMfzOcQ2Vt NN+T2DG8XCTCQiaxozd6HTF1XTlfrEoNhAUY0skY/hRYZ9PhTRFdDrgdEK5Fxo3C22U0 puoQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=vTCsjFJIEA5sMU46xx2C2RojTH9g6BEuwCRX2qWKk8A=; b=GUpUY5k6SiRWA0Q1vvAOlTAfWwhMYy1iM9LHVkmLKsCOpm4ryIMWfIfn2Tmsem+OFq jHZPlyHeyo1UcTfPQr6Jjt8VA0/EbllnZ/yzg7PwCEuXfdnpveFu14/MLASMMlFnwYhS dV5h/aKnOETCWvFR5rzI14PYTUSTaCd4flGhpPAYtMkm8bAXUIDI9HTiEQqDTfJ7LEU8 U40gq83+5ZBIZ/b+TAsJ/anW69TzZWnRySRLQZu3wUxK1vouiwcwOSdAmdZxq29K0tuU lqWj15wgm4Yg1Pc8GV1FOR2cVhs0YDaSCpzIDxbxUc5VEvVIOYGnnk4xyvyMUoxU4g2E glcw== X-Gm-Message-State: AOAM530MVjHO01/96O0KP3IOkh4tfSu9eE/q+EkOhAnM4FcP6fnFLdnC UMZ10ot9bvO/T3kWP9nIacSltWGaEQ+5qyUWFH0= X-Google-Smtp-Source: ABdhPJxmBemdJ+klSEbOA9NlSfZWads4uJMAiaurMWiOCi5d01T+UB5Yhm2MTReMr+CtQWNh4yW33mYC14O+VaU/w6g= X-Received: by 2002:a05:6e02:92f:: with SMTP id o15mr249444ilt.130.1610475240503; Tue, 12 Jan 2021 10:14:00 -0800 (PST) MIME-Version: 1.0 References: <20201221140308.9809-1-skori@marvell.com> In-Reply-To: From: Jerin Jacob Date: Tue, 12 Jan 2021 23:43:44 +0530 Message-ID: To: Nithin Dabilpuram Cc: Sunil Kumar Kori , Jerin Jacob , Kiran Kumar K , dpdk-dev , dpdk stable Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix corruption in segments list X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Dec 28, 2020 at 5:48 PM Nithin Dabilpuram wrote: > > On Mon, Dec 21, 2020 at 07:33:08PM +0530, skori@marvell.com wrote: > > From: Sunil Kumar Kori > > > > On Tx, lastseg->next is not being reset to null for multi segmented packet > > and same mbuf can be used on Rx which has a stale mbuf entry into > > mbuf->next. > > > > On Rx, application receives mbuf with mbuf->next uninitialized though > > mbuf->nb_segs is correct. Application iterates over all segments using > > mbuf->next ignoring mbuf->nb_segs which leads to undefined behavior. > > > > So earlier assumption of just having right value in mbuf->nb_segs is > > enough, is incorrect. Mbuf must contain valid and synced value in > > nb_segs and next pointer. > > > > Fixes: 364eb0e46683 ("net/octeontx2: avoid per packet barrier with multi segment") > > Cc: stable@dpdk.org > > > > Signed-off-by: Sunil Kumar Kori > > > > Acked-by: Nithin Dabilpuram Applied to dpdk-next-net-mrvl/for-main. Thanks