From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97840A0586; Wed, 19 Oct 2022 15:43:40 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 7A084427F3; Wed, 19 Oct 2022 15:43:40 +0200 (CEST) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id 20562410D1 for ; Wed, 19 Oct 2022 15:43:39 +0200 (CEST) Received: by mail-qt1-f175.google.com with SMTP id g16so6826204qtu.2 for ; Wed, 19 Oct 2022 06:43:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=2Sv9OIR6oo9zypazeNKjsPZ/g4BDClltTcaHFAowdc4=; b=C4lkXtukdmComiaWpItdQgsRwGXUK9hGvJo1UxGSUVPRa3PHxtLsveZg9CKqf42a2+ xVz+SD+O3z9p/a1HDTgBe+HxeIUn8YiHC6PoBcAe6nc48RGkmJeWwPy3KDkYu8t0bzdd FIVMbtj3soxPll0E1+kjW+c7JYAGHA3SLcnumDgbjBBhHWR7XD+LVaRRehiWuV9FEVnD 1xTYDAdaeqB2RSSTSrPOAq/hxOl1QETgEtYgZoOSdrNlT4fs+lMD/1Sqm9LPvJoa3Dsh vi4AgLetik7wv6j/BVOn41LUc3mcPLkpqsv3QqboaIAr/HbcTdar/WsAlM+4O2JdeXEc gVjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=2Sv9OIR6oo9zypazeNKjsPZ/g4BDClltTcaHFAowdc4=; b=MHsfAFo6AKGOrgOJJhuUjK2vi8alaSVg5PCT/Qt68rHXTy9tp0h63AKuKGEoUC8047 OTjp3Na+WpcsZpGyZharzaVoTAnGXnT7LFyOnTmdK74rRsmTB5xtE+QvuDQJEnFnBLj/ aoNHLQtQE0z80Q2YkkA4g6g/vW1eCoYLQ8qX5DEzMI3N34YOiuhQb10T1VEA/RmlkCh3 EFbyUAkuloDXulfm93K0S1fYDsiYTVZdgnl7KBQhB8TjeEZUkLFyXJjRWEhaf/sxgP8a 5Va8ErwcBBYU4RIf/wAIYGwjQ9cNajyYOvfVl6zS3qIBunGhAd5f6HCmQNcxT0L4kJRB 53ug== X-Gm-Message-State: ACrzQf0M3hERLtp3tTHbp9WVZaaMmQQHXHdt3WhFdd/ts0CYMDAaULFB 1tpyanWfI3X3D6msdLfCJzOG6xgxo2CHcJvimyDK7omE X-Google-Smtp-Source: AMsMyM5i59Dq5tKWQv4k50MFN/4RBIU4KB+8xWjQf3iShtuy4OSC3b+ixRWiG62O0VWWL0xudA6jEpfqsdcQmZTFbzk= X-Received: by 2002:a05:622a:1651:b0:38f:2829:a1fe with SMTP id y17-20020a05622a165100b0038f2829a1femr6504105qtj.173.1666187018451; Wed, 19 Oct 2022 06:43:38 -0700 (PDT) MIME-Version: 1.0 References: <20221018093926.562384-1-ganapati.kundapura@intel.com> In-Reply-To: <20221018093926.562384-1-ganapati.kundapura@intel.com> From: Jerin Jacob Date: Wed, 19 Oct 2022 19:13:12 +0530 Message-ID: Subject: Re: [PATCH v1] eventdev/crypto: add memzone lookup To: Ganapati Kundapura Cc: jay.jayatheerthan@intel.com, dev@dpdk.org, jerinj@marvell.com, abhinandan.gujjar@intel.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Tue, Oct 18, 2022 at 3:09 PM Ganapati Kundapura wrote: > > Secondary process is not able to call the crypto adapter > api's stats get/reset as crypto adapter memzone memory is not accessible by > secondary process. > > Added memzone lookup so that secondary process can call the > crypto adapter api's(stats_get etc) > > Signed-off-by: Ganapati Kundapura @Gujjar, Abhinandan S Does this patch need to be part of rc2? If so, please review ASAP. I will complete the rc2 PR by tomorrow. > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c b/lib/eventdev/rte_event_crypto_adapter.c > index a11cbcf..7c9901c 100644 > --- a/lib/eventdev/rte_event_crypto_adapter.c > +++ b/lib/eventdev/rte_event_crypto_adapter.c > @@ -33,6 +33,8 @@ > */ > #define CRYPTO_ENQ_FLUSH_THRESHOLD 1024 > > +#define ECA_ADAPTER_ARRAY "crypto_adapter_array" > + > struct crypto_ops_circular_buffer { > /* index of head element in circular buffer */ > uint16_t head; > @@ -138,7 +140,6 @@ eca_valid_id(uint8_t id) > static int > eca_init(void) > { > - const char *name = "crypto_adapter_array"; > const struct rte_memzone *mz; > unsigned int sz; > > @@ -146,9 +147,10 @@ eca_init(void) > RTE_EVENT_CRYPTO_ADAPTER_MAX_INSTANCE; > sz = RTE_ALIGN(sz, RTE_CACHE_LINE_SIZE); > > - mz = rte_memzone_lookup(name); > + mz = rte_memzone_lookup(ECA_ADAPTER_ARRAY); > if (mz == NULL) { > - mz = rte_memzone_reserve_aligned(name, sz, rte_socket_id(), 0, > + mz = rte_memzone_reserve_aligned(ECA_ADAPTER_ARRAY, sz, > + rte_socket_id(), 0, > RTE_CACHE_LINE_SIZE); > if (mz == NULL) { > RTE_EDEV_LOG_ERR("failed to reserve memzone err = %" > @@ -161,6 +163,22 @@ eca_init(void) > return 0; > } > > +static int > +eca_memzone_lookup(void) > +{ > + const struct rte_memzone *mz; > + > + if (event_crypto_adapter == NULL) { > + mz = rte_memzone_lookup(ECA_ADAPTER_ARRAY); > + if (mz == NULL) > + return -ENOMEM; > + > + event_crypto_adapter = mz->addr; > + } > + > + return 0; > +} > + > static inline bool > eca_circular_buffer_batch_ready(struct crypto_ops_circular_buffer *bufp) > { > @@ -1234,6 +1252,9 @@ rte_event_crypto_adapter_stats_get(uint8_t id, > uint32_t i; > int ret; > > + if (eca_memzone_lookup()) > + return -ENOMEM; > + > EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL); > > adapter = eca_id_to_adapter(id); > @@ -1275,6 +1296,9 @@ rte_event_crypto_adapter_stats_reset(uint8_t id) > struct rte_eventdev *dev; > uint32_t i; > > + if (eca_memzone_lookup()) > + return -ENOMEM; > + > EVENT_CRYPTO_ADAPTER_ID_VALID_OR_ERR_RET(id, -EINVAL); > > adapter = eca_id_to_adapter(id); > -- > 2.6.4 >