From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DE138A0A0C;
	Mon,  5 Jul 2021 10:47:40 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 60AFA4068C;
	Mon,  5 Jul 2021 10:47:35 +0200 (CEST)
Received: from mail-io1-f41.google.com (mail-io1-f41.google.com
 [209.85.166.41]) by mails.dpdk.org (Postfix) with ESMTP id F307B4003C
 for <dev@dpdk.org>; Mon,  5 Jul 2021 10:47:33 +0200 (CEST)
Received: by mail-io1-f41.google.com with SMTP id l5so20093240iok.7
 for <dev@dpdk.org>; Mon, 05 Jul 2021 01:47:33 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=dMC4/JaQfS38u7H3lhORmnPRsmsgaj4TodkeNL9IDZ4=;
 b=smxrrP0a3h9Hq8zFNxBNHwH2DZl6xH4S5370Cb6zVi2Sv08HIIXdvAtfk0TLygR28m
 fnWTvBYOanhjoilzuFex2JvAP4n3Vx6Izh4p0FPhncKW/qiab8JjPaG/pbo3BjOMn+uG
 /zojbyLfbgd5r5chWj5dL4DUkz6wAnxKhVzCwwU+0WbiBxT/KyXfnxF2amnPjWgk5M0p
 4m6LX+bBlaBeStLbvCA4+0sbXvmgz4PZVMSIYuslPv67Lfwc8wOaxWx+HPHgsvEJd6JF
 xhyAJHM3vdVjVnKt+CFiEjRgxVbFXPWF9ak0CMeQY2gTS8NY9TpvyoBPzDvJnjSYU70d
 dZmw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=dMC4/JaQfS38u7H3lhORmnPRsmsgaj4TodkeNL9IDZ4=;
 b=pgXspfwHpOuWyvnoghbh9yTBktxM4gJHgfzvULgPCo7fOWEzjNQk1CBIE/gByCXrWT
 ZMj8ABMtfBZw+nxe2Sadce+aLUKrWhMMOLLK+XpfXkrsYPpeVaEfGUlfHsTPDV41rIUm
 RQeIPd4y1PPRXTuw2HQ2Ny+snpDamoltWT4fuBrwyJrw5CSzrhmM3oz6ftBpVHyd/Bpp
 siptX4miLib44BNH7JIsLpJOhA4MI81IlZkFXKuMRxX9YKyNQ3THW8hcTDrnmmboLKz+
 gSdRYKJS4Z5hDkctgSFET1an4SA0AatD7xspD0ajgnuVe5F5Gv56zAWCKODWEHb3TyLy
 78vQ==
X-Gm-Message-State: AOAM531ebaxepjI3SRNdF8SPg+JpNbC0TBOS/tRek0Yvmj9b142iN5Hb
 OQEB9SnU/xXh/V4SbdWegz3bhB1CGd4rXBbiINQ=
X-Google-Smtp-Source: ABdhPJw18Q+QDFcgzeU4uTPxwCYbP1R3d9eX10SLfAyFZ2tGKdz29h7RytqHjmyXVbU2ZZw66h9L09qfP1y3JkphJIE=
X-Received: by 2002:a05:6638:28a:: with SMTP id
 c10mr11343803jaq.112.1625474853373; 
 Mon, 05 Jul 2021 01:47:33 -0700 (PDT)
MIME-Version: 1.0
References: <20210526074712.9270-1-hemant.agrawal@nxp.com>
In-Reply-To: <20210526074712.9270-1-hemant.agrawal@nxp.com>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Mon, 5 Jul 2021 14:17:07 +0530
Message-ID: <CALBAE1OTtgP=eLQPyb9wykH0zodest_amTmg9pdm1dQeBktMzA@mail.gmail.com>
To: Hemant Agrawal <hemant.agrawal@nxp.com>
Cc: dpdk-dev <dev@dpdk.org>, Xiaoyun Li <xiaoyun.li@intel.com>, 
 "Richardson, Bruce" <bruce.richardson@intel.com>,
 Jingjing Wu <jingjing.wu@intel.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH 1/2] doc: add policy for adding vendor PMD
 specific examples
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Wed, May 26, 2021 at 1:19 PM Hemant Agrawal <hemant.agrawal@nxp.com> wrote:
>
> This patch update the dpdk sample app policy to support
> vendor PMD specific test examples in the respective drivers
> sub-directory in examples.
>
> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
> ---
>  doc/guides/sample_app_ug/intro.rst | 16 ++++++++++++----
>  1 file changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/doc/guides/sample_app_ug/intro.rst b/doc/guides/sample_app_ug/intro.rst
> index 8ff223b16c..fd34e7790d 100644
> --- a/doc/guides/sample_app_ug/intro.rst
> +++ b/doc/guides/sample_app_ug/intro.rst
> @@ -58,10 +58,6 @@ examples are highlighted below.
>    forwarding Graph, or ``l3fwd_graph`` application does forwarding based on IPv4
>    like a simple router with DPDK Graph framework.
>
> -* :doc:`Hardware packet copying<ioat>`: The Hardware packet copying,
> -  or ``ioatfwd`` application demonstrates how to use IOAT rawdev driver for
> -  copying packets between two threads.
> -
>  * :doc:`Packet Distributor<dist_app>`: The Packet Distributor
>    demonstrates how to distribute packets arriving on an Rx port to different
>    cores for processing and transmission.
> @@ -94,3 +90,15 @@ examples are highlighted below.
>  There are many more examples shown in the following chapters. Each of the
>  documented sample applications show how to compile, configure and run the
>  application as well as explaining the main functionality of the code.
> +
> +Driver specific Sample Application
> +----------------------------------
> +
> +There are case where exiting sample applications may not be suitable to test

cases

> +a new driver contribution. In such cases a new driver specific sample application
> +can be added to specific drivers sub-directory in the examples folder with prior
> +approval from DPDK technical board. e.g.
> +
> +* :doc:`Hardware packet copying<ioat>`: The Hardware packet copying,
> +  or ``ioat`` application demonstrates how to use IOAT rawdev driver for
> +  copying packets between two threads.

With the above fix, it looks good to me.

Acked-by: Jerin Jacob <jerinj@marvell.com>


> --
> 2.17.1
>