From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66FE6A0543; Thu, 22 Sep 2022 10:36:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4296E40156; Thu, 22 Sep 2022 10:36:07 +0200 (CEST) Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) by mails.dpdk.org (Postfix) with ESMTP id 4C8B5400D7 for ; Thu, 22 Sep 2022 10:36:06 +0200 (CEST) Received: by mail-qk1-f177.google.com with SMTP id 3so5687078qka.5 for ; Thu, 22 Sep 2022 01:36:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=Obd0bhIkONrnB3zzvNMbD3eqT8vrQgrc6NOD8pz+8H0=; b=cbv0GxxUQ6oM3sozr2SGncEvrRHfNQIaLVMM0IGb2I5wPCWqP1mukK0Ccifu6q+5Op kBMzVB+UAYrSqJ4MqLsin7ZX/SNCNAtO9Wbe0Yq3pyVZh2xm0d8F/YGPXuI3eWi5DTR7 IV9c0jC4FLUbuvepx678Frh6d5olTiPQEXkXJiiy7n/i9mKMriqGIqyuciFFJBIK69fD p4tihAzip9lZfuOW1JXMTpQbkNZPa9CITDSvCkXI8kvCf26okNBT0ZEks1UuzimJoX+T WN7u90liVbt7GmbRKYkZAdgCv9RRQzq2YbX8guLX+RI0bGIPFOmWiShOKKRQiU7u3mPw 4EoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=Obd0bhIkONrnB3zzvNMbD3eqT8vrQgrc6NOD8pz+8H0=; b=ir5aZ27ZXwQw+SKWWVNcnRJfxctoBh/unjlOGK4yDC/VyMr0caev/usMxs+odahOYI +vjg/Rfx+EimWv16A/Rd7Cf8qxmliNj2U+UdJUXjWkULIQC56EuzVkrVAIKSrj8cLuZf q2CcIt0YEPTtuIP+3vOV5STUbLBcVKsmpl9xOcTpEKuVKZNVxFLMIiqGzXEaXlt9dY7f SsUjv/O0LK6C7pf0iUEIDE3XhmSjEJgYIorN+B8mkdJpaL4FACS6PhQ0YEN0WDAWCkBJ SqO61Njd4BMvd0+PtyvjtxoHQwaaWtKX2Lwf54UTn+/0mkH44BcR/N5PFloldERAU3aP 6Smg== X-Gm-Message-State: ACrzQf2UBmKsHhhmWygiFPieF3oY+gAt64hikcK7GPoUM3FQbXzWFQKC fKEBCPtSd3nqcNL0IL7bm7ZajZQelAHUH3pg+QY= X-Google-Smtp-Source: AMsMyM6jwTrG6dBkdLzY1dx4s1JVyZyhqtbEPkxJap1z+02XAelyj/Ppnmuyp3YgNRw/2TuBK/OhMJxomuXfaPEtzek= X-Received: by 2002:ae9:efc4:0:b0:6cb:e44c:723a with SMTP id d187-20020ae9efc4000000b006cbe44c723amr1274011qkg.402.1663835765616; Thu, 22 Sep 2022 01:36:05 -0700 (PDT) MIME-Version: 1.0 References: <20220922045909.479006-1-psatheesh@marvell.com> In-Reply-To: <20220922045909.479006-1-psatheesh@marvell.com> From: Jerin Jacob Date: Thu, 22 Sep 2022 14:05:39 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: add changes in base rule merging To: psatheesh@marvell.com Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Sep 22, 2022 at 10:29 AM wrote: > > From: Kiran Kumar K > > Added changes to base rule install mechanism. > If action type is IPsec and multi channel is set, > then base rule will not be merged. > > Signed-off-by: Kiran Kumar K > Reviewed-by: Satheesh Paul Antonysamy Please keep the consistent name. Updated the git commit as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks common/cnxk: update base rule merging mechanism Added changes to base rule install mechanism. If action type is IPsec and multi channel is set, then base rule will not be merged. Signed-off-by: Kiran Kumar K Reviewed-by: Satheesh Paul > --- > drivers/common/cnxk/roc_npc_mcam.c | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c > index 4bea6719c5..a725cabc57 100644 > --- a/drivers/common/cnxk/roc_npc_mcam.c > +++ b/drivers/common/cnxk/roc_npc_mcam.c > @@ -720,10 +720,13 @@ npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc) > uint64_t key_data[2] = {0ULL, 0ULL}; > uint64_t key_mask[2] = {0ULL, 0ULL}; > int key_len, bit = 0, index, rc = 0; > + struct nix_inl_dev *inl_dev = NULL; > int intf = pst->flow->nix_intf; > struct mcam_entry *base_entry; > + bool skip_base_rule = false; > int off, idx, data_off = 0; > uint8_t lid, mask, data; > + struct idev_cfg *idev; > uint16_t layer_info; > uint64_t lt, flags; > > @@ -789,7 +792,14 @@ npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc) > if (pst->set_ipv6ext_ltype_mask) > npc_set_ipv6ext_ltype_mask(pst); > > - if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX) { > + idev = idev_get_cfg(); > + if (idev) > + inl_dev = idev->nix_inl_dev; > + if (inl_dev && inl_dev->is_multi_channel && > + (pst->flow->npc_action & NIX_RX_ACTIONOP_UCAST_IPSEC)) > + skip_base_rule = true; > + > + if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX && !skip_base_rule) { > (void)mbox_alloc_msg_npc_read_base_steer_rule(npc->mbox); > rc = mbox_process_msg(npc->mbox, (void *)&base_rule_rsp); > if (rc) { > -- > 2.35.3 >