From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 52A3D433A7; Thu, 23 Nov 2023 10:38:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DC3B6402A6; Thu, 23 Nov 2023 10:38:43 +0100 (CET) Received: from mail-qt1-f172.google.com (mail-qt1-f172.google.com [209.85.160.172]) by mails.dpdk.org (Postfix) with ESMTP id 5892F4026B for ; Thu, 23 Nov 2023 10:38:42 +0100 (CET) Received: by mail-qt1-f172.google.com with SMTP id d75a77b69052e-41cd97d7272so3590641cf.0 for ; Thu, 23 Nov 2023 01:38:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700732321; x=1701337121; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=oxudVIvvkWz7h52JfcZavy3rFuiqx4d5HI6ZPo2MYFM=; b=IjsvSrzCEkqmhkpq7nO97p7796kU5H8ktEnofnGpRPuM2lDRyOZ1iPtdYIf92O8fHF bgVpNP5cXJ4FckA+0kNTMRkRJQUagutZQ4RUPXQNPCA63CGwzNd6Kv2yDaKXx/gvTS1K jFQ5SZvghlNIixyzuTE6auPZ+/7Xvg12WzpsSQQOKpQxGPgM3GSLsaSedpE0HxhBN/V0 AtMsrl098Iaa7gMNG4kSOspxpF5kAXD6mQCffSidC+OoS8uBDld7c2ypT4q/jCZfuj1C cJPXzfvyZV9FTSBkLVyxO6GgNi7B034xBb0RkkGsGZnFFlzx1ZDCt0LhEO/2oCrbtXgx coPg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700732321; x=1701337121; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oxudVIvvkWz7h52JfcZavy3rFuiqx4d5HI6ZPo2MYFM=; b=GiMM9U98yiIZIBV5kQpmDBdeAiop8GU0TmG2G2cB6ltGTAmRn/cOk32Lclcidp4F8G 507Yk6kzqRoqnVmQlgRL69C5W01chX3nExthSCQn34oWWO1a1qKa5cC9M2/Zw0zeaG+M 7fAQuTQJCZowyia4G7wmApg9QGOdvP8nJavKTVbVRPDh9U9ilxIjZoaKgdlbwioe9X1V VrHblTGCBLlPlKw0Jvgp72PUTCjF1A+VcViFtby4XHgg8sFyZHItEpNJHF/p8YTsgLe0 WEUe4RXKF9gRMEHFNbt8MTTonEkKSsH1bqMSGXE/rAwBlsVPSGxgQXudk4omv7CtqHbe cbow== X-Gm-Message-State: AOJu0Yyj2g6gMNlq1zKoUvNQgr2eyjcitj+xS5gQ0KhYjpa9zy7MvKx5 0VGlmFw6fV8AUVyVdSdXjMrDLaRGl3EeYPC5ZNU= X-Google-Smtp-Source: AGHT+IHFqOAZOplBppb9Iw1EHxADvTjyQ64N0mB9Zd+qrwz9LkQdE12VWM4FIgBKTvyqGObrOuWR73CIWQFkpUhpncM= X-Received: by 2002:ac8:5802:0:b0:423:6f05:33da with SMTP id g2-20020ac85802000000b004236f0533damr5869556qtg.18.1700732321584; Thu, 23 Nov 2023 01:38:41 -0800 (PST) MIME-Version: 1.0 References: <20231120172606.505579-1-bruce.richardson@intel.com> <20231121115437.96500-1-bruce.richardson@intel.com> <20231121115437.96500-9-bruce.richardson@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 23 Nov 2023 15:08:14 +0530 Message-ID: Subject: Re: [PATCH 24.03 v2 8/9] event/opdl: add schedule-type capability flags To: Bruce Richardson Cc: dev@dpdk.org, Liang Ma , Peter Mccarthy Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Nov 23, 2023 at 2:52=E2=80=AFPM Bruce Richardson wrote: > > On Thu, Nov 23, 2023 at 09:40:57AM +0530, Jerin Jacob wrote: > > On Tue, Nov 21, 2023 at 11:47=E2=80=AFPM Bruce Richardson > > wrote: > > > > > > Document explicitly the scheduling types supported by this driver, bo= th > > > via info_get() function, and via table in the documentation. > > > > > > Signed-off-by: Bruce Richardson > > > --- > > > > > > Maintainers, please check this patch carefully, as I'm not sure the > > > correct way to document this. > > > > > > According to the docs for this driver, it supports parallel only via > > > ordered. Therefore, I've actually made the docs inconsistent from the > > > flags claimed in the API. I've documented that PARALLEL is supported = in > > > the info_get() flags, so code that checks for that will run, but I've > > > omitted it from the table in the docs, since it is not directly > > > supported. Is this a good compromise, or an accurate reflection of th= e > > > driver? > > > --- > > > doc/guides/eventdevs/features/opdl.ini | 2 ++ > > > drivers/event/opdl/opdl_evdev.c | 3 +++ > > > 2 files changed, 5 insertions(+) > > > > > > diff --git a/doc/guides/eventdevs/features/opdl.ini b/doc/guides/even= tdevs/features/opdl.ini > > > index 5cc35d3c77..7adccc98de 100644 > > > --- a/doc/guides/eventdevs/features/opdl.ini > > > +++ b/doc/guides/eventdevs/features/opdl.ini > > > @@ -4,6 +4,8 @@ > > > ; Refer to default.ini for the full list of available PMD features. > > > ; > > > [Scheduling Features] > > > +atomic_scheduling =3D Y > > > +ordered_scheduling =3D Y > > > > Missed parallel > > > > Deliberate omission for now. See note above. Basically, parallel is I see. I missed the note. > supported through ordered, so I added the flag below to stop apps from > breaking, but I wasn't sure about advertising it in the docs. Will add it > if you feel its best to keep them consistent. I think, it is better to keep them consistent. > > /Bruce