From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E6E0A04C2; Thu, 21 Nov 2019 02:58:36 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C3D209E4; Thu, 21 Nov 2019 02:58:34 +0100 (CET) Received: from mail-il1-f193.google.com (mail-il1-f193.google.com [209.85.166.193]) by dpdk.org (Postfix) with ESMTP id 067672AB for ; Thu, 21 Nov 2019 02:58:32 +0100 (CET) Received: by mail-il1-f193.google.com with SMTP id i6so1649032ilr.11 for ; Wed, 20 Nov 2019 17:58:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=4++buHhsg7NIogAiTs2bpjJss64tZrp0HD5BBv9EWxE=; b=izyntWouRQo3dCPDsUWeuR/7Gd9yiouxRnPEWrCSFz5VUKsLYMqe4djkG7uGl/NMp3 MAXRa7wuiL3wphwRnuLJilpc9pgpaQINEH2Y4nqK6RBu8abm00tca55HJcyW8drh1DZi k3kpPCFNGT/k1DO8UVN2cHkuOEYGjbP1t9LHnYddcRuoC7F7JYq0pVrEA6qbcgG4fJOE zWxXRxVW2VsIwnhf7NxvvO567l/4xQ/jo1RAvooDAr/G8PPdsXlx/0lI7tL1ir6uQyyH qaZJI43HTRVS+nF39YSqLImcdv+At8Mg8hWesMNeK3uBe2erewe+w2kovYr+JuQDJ8vY U65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=4++buHhsg7NIogAiTs2bpjJss64tZrp0HD5BBv9EWxE=; b=TnkR/Xlt/tOE26RPdvUkAM+qHrsws0Yy87kk2Fx1vgJTAq6quEFw3SJz3tetd+qESA 5CQdjIwQmagWRg2uS42E2NzTtUAFPoH/qQGNl7lMbutI3ZwYcc0mA+l5WS7KQCnPDvWc bNMlr8rUP3uPXP2n5UhQUB47pi4Aov/1MvDatrzopzj8/o0KQ6TMwKbyYUjzbyyTFWYy Z6HxmUfgsNAgRmO4cdeK3qdkrw/oK7kPHIjnruH0J1SIsMqF10xh9gPwfvDr85H/PcGu ze0385CtRKiOyyjMj6yUg2G8Zz9bFWdKyI+cXm8O3f4kT2KVhBZHKi58MwraerSP1RZS 0nPA== X-Gm-Message-State: APjAAAUdAIkw88p3Z6z7w2z4W/YcvZDhMCDjT8ofiYvkH9wTEMWohd3g GFAf3BzfszGPb00vzAOCHezaus7bopepfEJhQ4w= X-Google-Smtp-Source: APXvYqy1gqnLEWdwNnIXlegTCzHTVn1Xzned+V5x7vxT4uN7J7jyKAd/SH8YtmAxAbP+Z+Z56M7fTTaJmxzyDWZsIpY= X-Received: by 2002:a92:1612:: with SMTP id r18mr6804256ill.60.1574301512025; Wed, 20 Nov 2019 17:58:32 -0800 (PST) MIME-Version: 1.0 References: <20191120160009.46270-1-ferruh.yigit@intel.com> <20191120172227.42798-1-ferruh.yigit@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 21 Nov 2019 07:28:15 +0530 Message-ID: To: David Marchand Cc: Vamsi Attunuru , Jerin Jacob , John McNamara , Marko Kovacevic , dev , Kiran Kumar K , Igor Ryzhov , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v2] kni: increase kernel version requirement for VA X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Nov 20, 2019 at 10:59 PM David Marchand wrote: > > On Wed, Nov 20, 2019 at 6:22 PM Ferruh Yigit wro= te: > > > > A build error reported related to the selected > > 'get_user_pages_remote()' kernel API: > > > > .../kernel/linux/kni/kni_dev.h:113:8: > > error: too few arguments to function =E2=80=98get_user_pages_remote= =E2=80=99 > > ret =3D get_user_pages_remote(tsk, tsk->mm, iova, 1 > > ^~~~~~~~~~~~~~~~~~~~~ > > > > Currently there are three version of the 'get_user_pages_remote()' > > supported, based on kernel version > > < 4.9, =3D 4.9, > 4.9 > > > > These version based checks are not working fine with the distro kernels > > which is the cause of reported build error. The error reported by the > > kernel version 4.8, but it is using API defined in > 4.9. > > > > To be able to take control of this, and possible more, related build > > error, increasing the minimum supported kernel version for iova=3Dva wi= th > > KNI to kernel version 4.9. > > > > This leaves us with single version of the kernel API and more > > manageable. > > > > Signed-off-by: Ferruh Yigit > > Jerin, Vamsi, > > Is this okay for you? Acked-by: Jerin Jacob > Thanks. > > > -- > David Marchand >