From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B5441A052A; Mon, 25 Jan 2021 17:10:13 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 99C6A140FBD; Mon, 25 Jan 2021 17:10:13 +0100 (CET) Received: from mail-io1-f41.google.com (mail-io1-f41.google.com [209.85.166.41]) by mails.dpdk.org (Postfix) with ESMTP id 3F139140FBC for <dev@dpdk.org>; Mon, 25 Jan 2021 17:10:10 +0100 (CET) Received: by mail-io1-f41.google.com with SMTP id n2so27557909iom.7 for <dev@dpdk.org>; Mon, 25 Jan 2021 08:10:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EAWpZpkYpECdC4QYIQd4nAjhPmY5mV56gS8GTL2ypTk=; b=bPEqOjki94aLHklrTlfb9DIQ6//LtBL9nZGs0pQXgZh6K2ehOT6ILC8hNEji4oN/OZ hvqQarD43RQ4AS1iRvkZRBptSLQLGw3treHrTvXPdAi/PEAN3tp59q/As7UAhl5KjTtE BMdFo3RKb7KQZCEymWAVfIZAOT7PE9tbDLgyfFiEsYnd2aqxw1C0xQXkpbdqSvdZRP9l 0y1Fcn2llPt2YLT1ciQni671VffbeSjltoL4I+M7TNZYc8vNO0ltEVMqubbj6SMV7mxn H2IsdTYhXw54wNsU0809yTaynlyCYIKTZe0O+VlGKrYUIph6TBdEVcWLfsaPXi1Ib3m1 eE0Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EAWpZpkYpECdC4QYIQd4nAjhPmY5mV56gS8GTL2ypTk=; b=M9Sby+pKufyNqS7GL2lSDGrSp3K0DBsNOgO2mJ8Pcfjw2yJZSRPDg2zbd0exFpaDgw /mKKPfPlHaTOtSbEsbf4cIf7fa9NAEregEzZa/cmJk0X9VqbQLgf/iOIzNf+HDhYUVJw 7p0K+m446RwjjypR4QshRd/dtSDpoiDYfCjCa5pdEFZdWrosRFsrUFY5wERjWXch24ZZ XgD7+uTux3xc1axQdBFlAGqyrIF7S6g/Ts3HHnzbVH+LdnGcjUPHoF6nQk/G6TPsFrRG Rzcv+I5F0BTYY59+Q+PXKxS9NZMBHFU5gIbORoeCJJpgn40FP4W71WJarY1yCzZMveL9 dW6Q== X-Gm-Message-State: AOAM530Me06Mcxj3eyyDHla9huplvPd3qUqg5hP/MNiu+upt8K3l1yk/ dDANxYvQvHIN8jpjjLas5XZTl2QBh3DNMEkfmvE= X-Google-Smtp-Source: ABdhPJxXZtQwK71UujVvUqWllBFM+PqnsaFB62UQA3F5QWQW+bflVIW2V2OJcdX8fRS6cZFmvxWE/wPMnASbwvGmseI= X-Received: by 2002:a02:5ec1:: with SMTP id h184mr1233673jab.133.1611591009600; Mon, 25 Jan 2021 08:10:09 -0800 (PST) MIME-Version: 1.0 References: <1608724059-8562-1-git-send-email-juraj.linkes@pantheon.tech> <2025364.IVKG2jy1nW@thomas> <CALBAE1NQcB=9Yh5vTfYMVac8MWu3aWe9t=Eb=vi-aE51krW_dA@mail.gmail.com> <2709196.oA3pVeJT1q@thomas> <DBAPR08MB5814809B2FE326646CEE66BE98BD0@DBAPR08MB5814.eurprd08.prod.outlook.com> In-Reply-To: <DBAPR08MB5814809B2FE326646CEE66BE98BD0@DBAPR08MB5814.eurprd08.prod.outlook.com> From: Jerin Jacob <jerinjacobk@gmail.com> Date: Mon, 25 Jan 2021 21:39:53 +0530 Message-ID: <CALBAE1OXGHYZjjkYWoX_y=rgj0sbkrf28iuqkz21-x8BS+9oog@mail.gmail.com> To: Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> Cc: "thomas@monjalon.net" <thomas@monjalon.net>, =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, "bruce.richardson@intel.com" <bruce.richardson@intel.com>, Ruifeng Wang <Ruifeng.Wang@arm.com>, Phil Yang <Phil.Yang@arm.com>, "vcchunga@amazon.com" <vcchunga@amazon.com>, Dharmik Thakkar <Dharmik.Thakkar@arm.com>, "hemant.agrawal@nxp.com" <hemant.agrawal@nxp.com>, "Ajit Khaparde (ajit.khaparde@broadcom.com)" <ajit.khaparde@broadcom.com>, "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>, "aboyer@pensando.io" <aboyer@pensando.io>, "dev@dpdk.org" <dev@dpdk.org>, "lironh@marvell.com" <lironh@marvell.com>, "allain.legacy@windriver.com" <allain.legacy@windriver.com>, nd <nd@arm.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Subject: Re: [dpdk-dev] [PATCH v15 09/12] build: disable drivers in Arm builds X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> On Mon, Jan 25, 2021 at 8:28 PM Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com> wrote: > > <snip> > > > > > 22/01/2021 10:07, Jerin Jacob: > > > On Fri, Jan 22, 2021 at 2:28 PM Thomas Monjalon <thomas@monjalon.net> > > wrote: > > > > 22/01/2021 09:39, Juraj Linke=C5=A1: > > > > > > > > > disabled drivers, similarly how the command line option > > > > > > > > > works and remove unneeded driver options ported from the > > > > > > > > > old makefile system, since they don't work in the current= Meson > > build system. > > > > > > > > > Add support for removing drivers for cross builds so that > > > > > > > > > we can disable them in cross files. > > > > > > > > > > > > > > > > Why disabling them? > > > > > > > > If a driver is not supported it should disable itseld in it= s meson file. > > > > > > > > > > > > > > > > > > > > > > This is helpful when building for an SoC where we don't want > > > > > > > to build to build a driver, but the build machine actually su= pports > > the driver. > > > > > > > I believe in this case the meson build system would find the > > > > > > > dependencies and designate the driver to be build, but we > > > > > > > don't want to build > > > > > > the driver for that SoC. > > > > > > > > > > > > > > There may be other reasons as well - Honnappa or others from > > > > > > > the Arm community may shed more light on this. > > > > > > IMO, the assumption should be everything compiles on all the > > > > > > platforms. Hence, the disables should be applied to the > > > > > > platforms where the drivers do not compile. > > > > > > > > If a driver does not compile, it can disable itself. > > > > No need for a configuration. > > > > > > > > > Would it be okay to leave the disabled as they're in this commit = and > > leave the updates to the plaform owners? Thomas, what do you think? > > > > > > > > I think this patch should not disable drivers but just add the infr= a to do it. > > > > > > IMO, If the SOC has "fixed" set of dpdk devices, probably better to > > > have positive logic to enable only those in config file. > > > I think, that will be portable and useful. > > > IMO, We can have infrastructure code enable only specific drivers and > > > config owners can later enable the required set. > > > > Yes you're right, enabling makes more sense than disabling for SoCs. > Every SoC also supports PCIe interfaces. This means, one could use them w= ith a PCIe based NIC (we do use these interfaces internally at Arm, I am no= t sure from a deployment perspective). Not every SoC. > > If we use the enable logic, the list will be huge? Yes. I think both support will be useful. IMO, Selecting a small subset can be achieved via, have a flag in config file to disable all the drivers and add the selective one as needed. > > > >