From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 215C8A00C2; Fri, 6 Jan 2023 14:23:14 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 03B96400EF; Fri, 6 Jan 2023 14:23:14 +0100 (CET) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mails.dpdk.org (Postfix) with ESMTP id EFBF0400D4 for ; Fri, 6 Jan 2023 14:23:12 +0100 (CET) Received: by mail-vs1-f43.google.com with SMTP id a64so1440361vsc.2 for ; Fri, 06 Jan 2023 05:23:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Rzdh8SkF2BT/4qXVZHjM1G1t/A+HDJpRzmMXJEnUilQ=; b=VoykqDwp+4rsYj3189z0z7vZYn1JkfQh8QRO/CBg0RP/EE8Np7By4cTKcE2w7LYwTF GblyPK7vpDdHfTVssYV8C5E74Q+Fpn6xKr5uQxUnZ3qYoqhL/R4xq2jn8nCR5BZjookP 7k3ZCHdQu+fXFos0yNoCOmaETVoDf7xSvSUl0e7ZizKgERZOpLU1GokhmQLItnM0H268 BicE/czZWxuZZytHfrvKNYftTfrxyqgNJ2DIW2XpdmZU4Yh+NjUaL0EewAAsVtLVidsI QtS4+U3C4QGATwug9XzFnAXaEvM/sBMef1axZOEExCPyxxBoMfUImeYBLRnAx76R8qoI qaOg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Rzdh8SkF2BT/4qXVZHjM1G1t/A+HDJpRzmMXJEnUilQ=; b=jnfPDqTpBySwHzWWwUDcBMJPEF7xBkGvDEqrgE+FX7zko/0zAdorwYfuwroN9dfFum BZ+Z6oonF8zDwaxoXZs38u0TQXRv0v1xQcOmnrsXKz6pqGz/48U8CKZ0OZiKh5WzwtsM /mu7K7/GVEjLOT5ig710Q4kR2AQLixKULUGw2ulC4PGaNdX/MGbElCoURhYJieWe/lum R00veaZxjD7EQJVWpxD9xyykMn/hoEGmXuRAd0nGEn3oOdyQUGfwiR4HbF3xnQotKxPZ FMrSpOJqMCBUHT/lIQbQsUIk3mYsuxLDe0Rc4H+sSALeFJIRcLDCSzRpuKrSUN6r6blZ BsAA== X-Gm-Message-State: AFqh2kqrWPFy46SIRHIEHlbA0ILZ4V1tsUHEOQFtwf0tcRxNbym2Q0hU RKQsaXa0WmRshNBMyTTnKhi+x9IcN7N/BXp459PrZUddexnanw== X-Google-Smtp-Source: AMrXdXtsToXmE/FCHkvVEPz+Lv1/TMQ/kBe6yOCZd1sW2dspEZNhxwsSfOdnIP5oSyverZxIssWKKEmLT0WA37BBaI4= X-Received: by 2002:a67:b44a:0:b0:3b2:e6c6:b207 with SMTP id c10-20020a67b44a000000b003b2e6c6b207mr6937656vsm.45.1673011392215; Fri, 06 Jan 2023 05:23:12 -0800 (PST) MIME-Version: 1.0 References: <20221128095442.3185112-1-ndabilpuram@marvell.com> <20221128095442.3185112-11-ndabilpuram@marvell.com> In-Reply-To: <20221128095442.3185112-11-ndabilpuram@marvell.com> From: Jerin Jacob Date: Fri, 6 Jan 2023 18:52:45 +0530 Message-ID: Subject: Re: [PATCH 11/11] common/cnxk: disable drop re in A1 chip revision To: Nithin Dabilpuram Cc: Kiran Kumar K , Sunil Kumar Kori , Satha Rao , jerinj@marvell.com, dev@dpdk.org, Pavan Nikhilesh Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 28, 2022 at 3:25 PM Nithin Dabilpuram wrote: > > From: Pavan Nikhilesh > > Disable drop re in CN10KA A1 as enabling it would leak > event vector buffers. > > Signed-off-by: Pavan Nikhilesh Updated the git commits[2] and minor cleanup[1] in 1/11 as follows and applied to dpdk-next-net-mrvl/for-next-net. Thanks [1] diff --git a/drivers/common/cnxk/roc_nix_irq.c b/drivers/common/cnxk/roc_nix_irq.c index 2e4bccb713..2b731302cd 100644 --- a/drivers/common/cnxk/roc_nix_irq.c +++ b/drivers/common/cnxk/roc_nix_irq.c @@ -328,9 +328,8 @@ nix_lf_q_irq(void *param) roc_nix_queues_ctx_dump(nix_priv_to_roc_nix(nix), NULL); /* Call reset callback */ - if (intr_cb) - if (dev->ops->q_err_cb) - dev->ops->q_err_cb(nix_priv_to_roc_nix(nix), NULL); + if (intr_cb && dev->ops->q_err_cb) + dev->ops->q_err_cb(nix_priv_to_roc_nix(nix), NULL); [2] commit 6141ebf5fbf3c2ccc4b78ab9491ccb43e570565b (HEAD -> for-next-net, origin/for-next-net) Author: Pavan Nikhilesh Date: Mon Nov 28 15:24:42 2022 +0530 common/cnxk: disable drop receive error in A1 revision Disable drop receive error in CN10KA A1 as enabling it would leak event vector buffers. Signed-off-by: Pavan Nikhilesh commit b7feb7d248072637d7143c6686ffc1ee7e04a3a7 Author: Pavan Nikhilesh Date: Mon Nov 28 15:24:41 2022 +0530 net/cnxk: mark HW errors as bad checksum Mark NIX packet parsing errors due to NPC/NPA errors as bad packets by setting L3/L4 checksum as BAD in olflags. Application can decide the fate of these packets. Signed-off-by: Pavan Nikhilesh commit 3dab27b88d5b367bf1d83f5ac6efc89bb9f0cc6d Author: Kommula Shiva Shankar Date: Mon Nov 28 15:24:40 2022 +0530 common/cnxk: fix aura ID handling Fix the aura handle to aura id while initialising inline dev SSO XAQ aura Fixes: 6f30ac80ca6b ("common/cnxk: use XAQ create API for inline device") Cc: stable@dpdk.org Signed-off-by: Kommula Shiva Shankar commit ff38e5da017d04760762fcb30227c91f338abb93 Author: Nithin Dabilpuram Date: Mon Nov 28 15:24:39 2022 +0530 common/cnxk: use lcore LMT line for CPT context write Use lcore LMT line for CPT context write as no one else is using it. Signed-off-by: Nithin Dabilpuram commit 9ac550f477b93c413d7dd57bf280d1d83a8436aa Author: Nithin Dabilpuram Date: Mon Nov 28 15:24:38 2022 +0530 net/cnxk: support late backpressure for cn10kb Add late backpressure support for cn10kb and set it up to backpressure CPT. Signed-off-by: Nithin Dabilpuram commit a5d5985247aa3bda9790df6961d57ceeb62c9e54 Author: Nithin Dabilpuram Date: Mon Nov 28 15:24:37 2022 +0530 net/cnxk: fix packet type for IPv6 packets post decryption Update ptype properly for IPv6 packets post inline decryption. Fixes: 4440eb88ddfc ("net/cnxk: use full context IPsec structures") Cc: stable@dpdk.org Signed-off-by: Nithin Dabilpuram commit 323b51f6adb985711d38069d1390e0bfa2560a3b Author: Rakesh Kudurumalla Date: Mon Nov 28 15:24:36 2022 +0530 event/cnxk: net/cnxk: support transmit completion added support to call callback handler provided by user when external buffer is attached to mbuf and transmit completion is enabled.Added support to enable transmit completion as device args Signed-off-by: Rakesh Kudurumalla commit 8950250f5241d12f7b32f424dab74bdf67350183 Author: Satha Rao Date: Mon Nov 28 15:24:35 2022 +0530 common/cnxk: split NIX TM hierarchy enable API roc_nix_tm_hierarchy_enable() API will do two things internally, 1) Creation of all TM nodes, allocate HW resources and connect them as requested. 2) Enable transmit by XON SMQ and start SQs In test cases where both steps called independently. In order to support this, patch split the functionality into two APIs. Signed-off-by: Satha Rao commit 05faa3527fdb9ca1875b5dab61c2916d9f0e3239 Author: Satha Rao Date: Mon Nov 28 15:24:34 2022 +0530 common/cnxk: set default SQ TC value Zero is valid TC, initialize SQ TC value to ROC_NIX_PFC_CLASS_INVALID. Signed-off-by: Satha Rao commit e5b2caa96a0358d83efb0e495074f69f0c1de034 Author: Satha Rao Date: Mon Nov 28 15:24:33 2022 +0530 net/cnxk: register callback to get queue errors Register a callback mechanism to get SQ error interrupts, add call ethdev event RTE_ETH_EVENT_INTR_RESET. Signed-off-by: Satha Rao commit 5f0d6a1ab3b4ff73cdbce8158cabe6d9a42cdcf8 Author: Satha Rao Date: Mon Nov 28 15:24:32 2022 +0530 common/cnxk: free pending SQE buffers This patch provides a callback mechanism when SQ receives MNQ_ERR. Even when SQ got MNQ_ERR interrupt application still enqueue packets for sending they will be struck at SQ, so we are freeing all these pending packets when we called SQ finish. Signed-off-by: Satha Rao > --- > drivers/common/cnxk/roc_errata.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/common/cnxk/roc_errata.h b/drivers/common/cnxk/roc_errata.h > index a39796e894..36e6db467a 100644 > --- a/drivers/common/cnxk/roc_errata.h > +++ b/drivers/common/cnxk/roc_errata.h > @@ -9,7 +9,7 @@ static inline bool > roc_errata_nix_has_no_drop_re(void) > { > return (roc_model_is_cn10ka_a0() || roc_model_is_cnf10ka_a0() || > - roc_model_is_cnf10kb_a0()); > + roc_model_is_cnf10kb_a0() || roc_model_is_cn10ka_a1()); > } > > /* Errata NIX-34873 */ > -- > 2.25.1 >