From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 01EB0A09FF; Mon, 11 Jan 2021 17:18:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DF257140F31; Mon, 11 Jan 2021 17:18:40 +0100 (CET) Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) by mails.dpdk.org (Postfix) with ESMTP id 8F894140F12 for ; Mon, 11 Jan 2021 17:18:39 +0100 (CET) Received: by mail-io1-f53.google.com with SMTP id 81so85605ioc.13 for ; Mon, 11 Jan 2021 08:18:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8cicDpuc0vrSmjLnknEhw0ubw1ovBiTEub6ax5v1ydo=; b=SeVJ1zL+lZf/kJDLMKekyE+1JCaW+dH5wi0uRbNDvejQOrk2gAYqA/QtXt6fUnaFew f7zy7n2/pzz07zamON4j1HX8e8N+87d0oPHfsquN98pozQYp3voitqpshv6WbIOoYPdM XpddY7zFr19qCdQgpLlpmI6/mizKvF70cb7rlo8nCU4Ag0MZN8D2/X43xFUYfOQ6Bk7T q2LdkbPxQR4vAM9GU2f5696U5kmv6Iud6/+Lha09CK/GlAD+A9rdScFy2SJKuDzK5SyL yI5r+kE+9GQTqeSbweAII7vu4O9JVCrqYBfSdZLrJ/2K6gpyiThjQSn+Hh6vJJKtY9sc E32Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8cicDpuc0vrSmjLnknEhw0ubw1ovBiTEub6ax5v1ydo=; b=Kgk+R+eNMlShZ3PaR0m7wO/YhyRVSlWioBm8/oDL5kHCLBsC0Tm3ZiXLCJXnCj0Psf Or3V26VaFGRxdXnd+iaV4f5iRIeDiD2444WHvUSFrIJhIPdtbIqcZ0kUSrpudjELMv3E qZR47f8nhnWaAmF7ghBhanB7OH0ZGEYoBvfecyh24T41Sqk5WH8A9myZfxUCN5M5yacp ruiJ86hXsRKwiVA+4QOjZ+Kz58nRqYmccOiCslXsIXgJHV1ylEhsDOI9hF52lYzaWu8y M9mzfh0Z6jApdv1FFlpq0KmNh6MU+oU3wu5TF26laLZ+s2gdwK1LoctpTthnKITceF7o thSQ== X-Gm-Message-State: AOAM530qlB2nNc9hFSxbYFukrgIAcG51bD2sXa8baI4BFAFuVNdN4UsZ 69Q+G8mqWHqkb8KVrPJMfLGYg8hgmv3ER7UFhkc= X-Google-Smtp-Source: ABdhPJwSoVcdrmDCSeCtvKbA2C006v4HXxEOYBkDep8fXqaD4yvErCRKiWy6tt1fna1BNWw046RFEmW3SaODuAsstCw= X-Received: by 2002:a05:6602:93:: with SMTP id h19mr16633iob.59.1610381919038; Mon, 11 Jan 2021 08:18:39 -0800 (PST) MIME-Version: 1.0 References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-23-lironh@marvell.com> In-Reply-To: From: Jerin Jacob Date: Mon, 11 Jan 2021 21:48:23 +0530 Message-ID: To: Michael Shamis Cc: Liron Himi , Jerin Jacob Kollanukkaran , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v1 22/38] net/mvpp2: flow: add support for RAW type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Dec 23, 2020 at 2:58 PM Michael Shamis wrote: > > Reviewed-by: Michael Shamis > > -----Original Message----- > From: dev On Behalf Of lironh@marvell.com > Sent: Wednesday, December 2, 2020 12:12 PM > To: Jerin Jacob Kollanukkaran > Cc: dev@dpdk.org; Liron Himi > Subject: [dpdk-dev] [PATCH v1 22/38] net/mvpp2: flow: add support for RAW type > > From: Liron Himi > > add support for RAW type and connect it to MUSDK UDF > > Signed-off-by: Liron Himi > Reviewed-by: Liron Himi > --- > drivers/net/mvpp2/mrvl_ethdev.h | 1 + > drivers/net/mvpp2/mrvl_flow.c | 141 ++++++++++++++++++++++++++++++++ > 2 files changed, 142 insertions(+) > > diff --git a/drivers/net/mvpp2/mrvl_ethdev.h b/drivers/net/mvpp2/mrvl_ethdev.h index e7f75067f..be5e5a51b 100644 > --- a/drivers/net/mvpp2/mrvl_ethdev.h > +++ b/drivers/net/mvpp2/mrvl_ethdev.h > @@ -92,6 +92,7 @@ struct rte_flow { > struct pp2_cls_tbl_rule rule; > struct pp2_cls_cos_desc cos; > struct pp2_cls_tbl_action action; > + uint8_t next_udf_id; > }; > > struct mrvl_mtr_profile { > diff --git a/drivers/net/mvpp2/mrvl_flow.c b/drivers/net/mvpp2/mrvl_flow.c index ffa47a12e..3c8052f06 100644 > --- a/drivers/net/mvpp2/mrvl_flow.c > +++ b/drivers/net/mvpp2/mrvl_flow.c > @@ -1196,6 +1196,146 @@ mrvl_parse_udp(const struct rte_flow_item *item, > return -rte_errno; > } > > +static int > +mrvl_string_to_hex_values(const uint8_t *input_string, > + uint8_t *hex_key, > + uint8_t *length) > +{ > + char tmp_arr[3], tmp_string[MRVL_CLS_STR_SIZE_MAX], *string_iter; > + int i; > + > + strcpy(tmp_string, (const char *)input_string); > + string_iter = tmp_string; > + > + string_iter += 2; /* skip the '0x' */ > + *length = ((*length - 2) + 1) / 2; > + > + for (i = 0; i < *length; i++) { > + strncpy(tmp_arr, string_iter, 2); > + tmp_arr[2] = '\0'; > + if (get_val_securely8(tmp_arr, 16, > + &hex_key[*length - 1 - i]) < 0) > + return -1; > + string_iter += 2; > + } > + > + return 0; > +} Is standard strtol() not enough?