From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFD8DA00C5; Sun, 26 Apr 2020 14:23:50 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3504E1BFAC; Sun, 26 Apr 2020 14:23:50 +0200 (CEST) Received: from mail-il1-f196.google.com (mail-il1-f196.google.com [209.85.166.196]) by dpdk.org (Postfix) with ESMTP id 48B451BF9E for ; Sun, 26 Apr 2020 14:23:48 +0200 (CEST) Received: by mail-il1-f196.google.com with SMTP id r2so14065200ilo.6 for ; Sun, 26 Apr 2020 05:23:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=tkfF1ETxwm7loY+QfoWye4bF2g8iL2BGK6VdqsAX/7Q=; b=i+XCUJFN6dQTEdX59ZGTPgzoqNaf3XkWIA9JoPO3eO3pFnIxuddkJgOH60W7i0YUsz 8AiHoNd+PnjOkFcMXAtUHtkq1mO3tV6yZzy+Y4qlNkRW4tkmy57H1etHYHB2ao+qUu25 uJQyWrTUymNiKnQaZR9IIfn3lcLFLcOZ/MarKdM5b4z+c2+rB83IjxOKRyRk44n0yG4u wquAtzdhuW7qk6IzIofmvtvL6s3taHwHDbUXjJ2AlfzAe/6ZNvzX/xMXLeAx6Ci6Gjfn wl1+FjGvVrjzadB7uA76qgnvRGjjQVvYW9rNGQHvDA/oseqbQH6w3c3QnO9t5E2LXheJ lOFw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=tkfF1ETxwm7loY+QfoWye4bF2g8iL2BGK6VdqsAX/7Q=; b=Uu0UsynhpLhuRJ9SweU1aV62GCCaCik4oMCXJ3sBmpc4S0xvGkkVu/ZiEusKdK143D /qXSnL9z1xxHGdXN4qJezGG+FP4kaOUysMzGNkZts1XqkgURNSbZCXxA/et11cOFE7YW wEAjFcuExVM4W7u7RaptQelCtoiWRTW0oF8cMFPejWE0Y2w06jVztaM6ewHEdJGm17j2 QY5is225itYFwb9Ra18SyNq6hjfDVCVusHMBvrREoZhzJXH4ahlOBhGaNXW99XVKawjk Pfs/fgqeT0d8jToTyaC2TdLmnOtrFzpudsLE/UBJtvyq7bgnnIuNoez1Hk6Y5vAepqlY DEnA== X-Gm-Message-State: AGi0PuZh6WixiyU0cEASxRgEbGjGxJaeOBl6UZqkVlsBpbmM7BYZOb+U omnwQtdt47l0rbENuDeXQaZsorJooX0qblGk6B0= X-Google-Smtp-Source: APiQypKERinmFca3r8mbHQpXv61rYuY3Kbyp37akaL80MeZ6q2MG3qm0mIYUWbOGT9HBxM50xfqDvqVMt4OAnzPB4P0= X-Received: by 2002:a92:d341:: with SMTP id a1mr5050413ilh.130.1587903827585; Sun, 26 Apr 2020 05:23:47 -0700 (PDT) MIME-Version: 1.0 References: <20200426032245.2437733-1-dmitry.kozliuk@gmail.com> <20200426032245.2437733-3-dmitry.kozliuk@gmail.com> <20200426150202.521e7930@Sovereign> In-Reply-To: <20200426150202.521e7930@Sovereign> From: Jerin Jacob Date: Sun, 26 Apr 2020 17:53:31 +0530 Message-ID: To: Dmitry Kozlyuk Cc: dpdk-dev , Pallavi Kadam , Narcisa Ana Maria Vasile , Ranjit Menon , Thomas Monjalon , Jerin Jacob , Sunil Kumar Kori , Bruce Richardson , Harini Ramakrishnan , Omar Cardona , David Marchand Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 2/2] eal/windows: fix build by supporting trace X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Apr 26, 2020 at 5:32 PM Dmitry Kozlyuk wrote: > > On 2020-04-26 17:02 GMT+0530 Jerin Jacob wrote: > > > +/** > > > + * Get absolute path to the directory where permanent data can be stored. > > > + * > > > + * @return > > > + * Statically allocated string on success, NULL on failure. > > > + */ > > > +const char * > > > +eal_permanent_data_path(void); > > > > Do windows have PATH_MAX kind of macro? I think, it is better API > > consumer allocates > > the memory of size PATH_MAX and implementation fills it, instead of, > > the static scheme. > > This API falls in line with rte_eal_get_runtime_dir() and other > eal_filesystem.h functions, that use static scheme. Logically, its result > never changes. It is race-free and is only called during initialization. What > you propose can be done, but are there any benefits? I thought who will free that memory? It looks like libc creating a static memory for this item. so, your current eal_permanent_data_path() declarations looks good to me. > > While we're at it, don't these declarations belong to eal_filesystem.h? I > left them in eal_private.h, because eal_filesystem.h is mostly Unix-specific. Understood, Leaving that decision to EAL maintainers. > > -- > Dmitry Kozlyuk