DPDK patches and discussions
 help / color / mirror / Atom feed
From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ruifeng Wang <Ruifeng.Wang@arm.com>
Cc: "Wei Hu (Xavier)" <huwei013@chinasoftinc.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 "xavier.huwei@huawei.com" <xavier.huwei@huawei.com>,
	nd <nd@arm.com>,
	 Honnappa Nagarahalli <Honnappa.Nagarahalli@arm.com>
Subject: Re: [dpdk-dev] [PATCH v3] eal/arm64: update CPU flags
Date: Tue, 18 Aug 2020 10:37:21 +0530
Message-ID: <CALBAE1Ob2sroj+mR8KHsdD0hNvuzqU2hNBh6H5xpxbCRvPCvBg@mail.gmail.com> (raw)
In-Reply-To: <HE1PR0801MB2025B666B290DB3E309312599E5C0@HE1PR0801MB2025.eurprd08.prod.outlook.com>

On Tue, Aug 18, 2020 at 9:11 AM Ruifeng Wang <Ruifeng.Wang@arm.com> wrote:
>
> Hi,
>
> > -----Original Message-----
> > From: Wei Hu (Xavier) <huwei013@chinasoftinc.com>
> > Sent: Tuesday, August 18, 2020 10:44 AM
> > To: dev@dpdk.org
> > Cc: xavier.huwei@huawei.com; nd <nd@arm.com>; Honnappa Nagarahalli
> > <Honnappa.Nagarahalli@arm.com>; Ruifeng Wang
> > <Ruifeng.Wang@arm.com>; jerinjacobk@gmail.com
> > Subject: [PATCH v3] eal/arm64: update CPU flags
> >
> > From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
> >
> > SVE is the next-generation SIMD extension of the ARMv8-A AArch64
> > instruction set.
> > The related marco definition can be found in linux kernel:
> >   arch/arm64/include/uapi/asm/hwcap.h
> >
> > This patch updates cpu SVE flags on ARM64 platform, such as SVE, etc.

Suggested rewording:

ARM64 Linux kernel updated the CPU flags using the HWCAP scheme.
This patch incorporates those changes to the eal library.


> >
> > Signed-off-by: Chengwen Feng <fengchengwen@huawei.com>
> > Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> > ---
> > v2 -> v3:
> >       1. Change commit log.
> >       2. Add HWCAP2_FLAGM2 and HWCAP2_FRINT to
> > rte_cpu_feature_table[].
> >       3. Add the flags for newly added items into enum rte_cpu_flag_t.
> > v1 -> v2:
> >       Adds more sve-related definition to rte_cpu_feature_table,
> >       sunch as SVE2, etc.
> > ---
> >  lib/librte_eal/arm/include/rte_cpuflags_64.h | 13 +++++++++++++
> >  lib/librte_eal/arm/rte_cpuflags.c            | 13 +++++++++++++
> >  2 files changed, 26 insertions(+)
> >
> How about updating test_cpuflags() too to cover these new flags?

+1 . Wei, Please update the test_cpuflags() functions for new flags.

  reply	other threads:[~2020-08-18  5:07 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-17 12:47 [dpdk-dev] [PATCH v2] lib/librte_eal: support SVE flag on ARM64 Wei Hu (Xavier)
2020-08-17 13:07 ` Jerin Jacob
2020-08-18  2:47   ` Wei Hu (Xavier)
2020-08-18  2:43 ` [dpdk-dev] [PATCH v3] eal/arm64: update CPU flags Wei Hu (Xavier)
2020-08-18  3:41   ` Ruifeng Wang
2020-08-18  5:07     ` Jerin Jacob [this message]
2020-08-18  8:05       ` Wei Hu (Xavier)
2020-08-18  8:06     ` Wei Hu (Xavier)
2020-08-18  8:09 ` [dpdk-dev] [PATCH v4 0/2] update CPU flags for arm64 platform Wei Hu (Xavier)
2020-08-18  8:09   ` [dpdk-dev] [PATCH v4 1/2] eal/arm64: update CPU flags Wei Hu (Xavier)
2020-08-19  2:27     ` Ruifeng Wang
2020-08-18  8:09   ` [dpdk-dev] [PATCH v4 2/2] test/cpuflag: add new flags for ARM64 platform Wei Hu (Xavier)
2020-08-19  2:26     ` Ruifeng Wang
2020-08-19  7:09       ` Wei Hu (Xavier)
2020-08-19  7:04 ` [dpdk-dev] [PATCH v5 0/2] update CPU flags for arm64 platform Wei Hu (Xavier)
2020-08-19  7:04   ` [dpdk-dev] [PATCH v5 1/2] eal/arm64: update CPU flags Wei Hu (Xavier)
2020-08-19  7:04   ` [dpdk-dev] [PATCH v5 2/2] test/cpuflag: add new flags for ARM64 platform Wei Hu (Xavier)
2020-08-19  8:11     ` Ruifeng Wang
2020-08-20  0:39       ` Wei Hu (Xavier)
2020-08-19 10:56 ` [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform Wei Hu (Xavier)
2020-08-19 10:56   ` [dpdk-dev] [PATCH v6 1/2] eal/arm64: update CPU flags Wei Hu (Xavier)
2020-10-12  3:30     ` Wei Hu (Xavier)
2020-08-19 10:56   ` [dpdk-dev] [PATCH v6 2/2] test/cpuflag: add new flags for ARM64 platform Wei Hu (Xavier)
2020-09-01  1:42   ` [dpdk-dev] [PATCH v6 0/2] update CPU flags for arm64 platform Wei Hu (Xavier)
2020-09-03  3:11   ` Wei Hu (Xavier)
2020-09-14  6:00   ` Wei Hu (Xavier)
2020-09-28  0:49   ` Wei Hu (Xavier)
2020-09-30  1:44   ` Ruifeng Wang
2020-10-09  6:34     ` Wei Hu (Xavier)
2020-10-13 16:00     ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CALBAE1Ob2sroj+mR8KHsdD0hNvuzqU2hNBh6H5xpxbCRvPCvBg@mail.gmail.com \
    --to=jerinjacobk@gmail.com \
    --cc=Honnappa.Nagarahalli@arm.com \
    --cc=Ruifeng.Wang@arm.com \
    --cc=dev@dpdk.org \
    --cc=huwei013@chinasoftinc.com \
    --cc=nd@arm.com \
    --cc=xavier.huwei@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git