From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1F45DA0566; Mon, 8 Mar 2021 16:14:02 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BB7CD22A384; Mon, 8 Mar 2021 16:14:01 +0100 (CET) Received: from mail-io1-f42.google.com (mail-io1-f42.google.com [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id 126EB4068A for ; Mon, 8 Mar 2021 16:14:00 +0100 (CET) Received: by mail-io1-f42.google.com with SMTP id o11so10302418iob.1 for ; Mon, 08 Mar 2021 07:13:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oaO1QXwy5fah/qlZr9tY9eUXGa0qTIRfTyMq7ixd+AY=; b=IX/6uQ36vCMgg9W5Oyr5CiMj0lSpgBwkeDLuPtplvxNMQsZeVLzhs6Q9fLwcemBDFL FbnfVTJqWhp4mdkQFTnPL12aQvCDu0dGLm7Rb0sUQJDhKBrkuG2z0gGucC3KwyBWZ7YP i1pGlFLwV6ndbPRENuQitTUj/07VSrH80xD6w/Wv4PqeD7xCHDtlQyHPSQFZPbYjITVz I9JWQug3uEbWPxKI2yeSxTDv4p0peSeU/oRMPquWsuC20jtj9vs3MjR+0pE8Bbv2Au/U 7CCwlykUUxJsVVcTvwFiUI7PvrtbqXm44iezZa87+TZ1pfzduT5M74IKg81XfDN5/2Xe SqIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oaO1QXwy5fah/qlZr9tY9eUXGa0qTIRfTyMq7ixd+AY=; b=AZTLk0824/I/u97jCwYpaX8MTZjhf725uZ9P/5auiXRs6IFMI4oOHzWZhXb6g1V4w0 LvcIBZoL0zsjSKJloK5WcRDnKdbAVkwPA8j93sdD1itSi4FbrGx5dgkJrJJv07ng8kcO /Oc5ts933ylEai2dMaa0KHZHBBq0rPBY60kNhlHZ7EuOcYfSJxzSzXMziFzuIw2FuOf+ 6bSBBTE3dw23UGqMoiBiBwPcDtZ3CXcOc2UlSEIwreSrdHNXUFbk+zSFzSw2qZYJb/Ix VqOEy1JPZAKFbgjxQn66Lb8Gx8pkho3Cefd8yARW1h6jXYWjAtypMatQXSyZkiZxXrjt q/Sw== X-Gm-Message-State: AOAM532OTAOsHjF37RYgptmkOA89/SfxiQSozSwGgXrE5fe/MNDtJQiy fZiYaIzazOfcajf2V07bFBfocqeNVY2607kQimo= X-Google-Smtp-Source: ABdhPJxZ/CfU12pjf8HeqihMPIPbvK/wGQfnnY/zXpDcsLn92kY+18MWZawWnP5xUXj75X32CERfAlAhfPX4XY+9r4o= X-Received: by 2002:a05:6638:582:: with SMTP id a2mr23533428jar.133.1615216439290; Mon, 08 Mar 2021 07:13:59 -0800 (PST) MIME-Version: 1.0 References: <20210210102045.96498-1-pnalla@marvell.com> In-Reply-To: <20210210102045.96498-1-pnalla@marvell.com> From: Jerin Jacob Date: Mon, 8 Mar 2021 20:43:43 +0530 Message-ID: To: Nalla Pradeep Cc: Radha Mohan Chintakuntla , Veerasenareddy Burru , Jerin Jacob , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/octeontx_ep: fixed format specifier X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Feb 10, 2021 at 3:52 PM Nalla Pradeep wrote: > > Used PRIx64 format specifier where ever the variable getting printed > is of type uint64 Fixes: tag is missing. Please send an updated version. rest looks good to me. > > Signed-off-by: Nalla Pradeep > --- > drivers/net/octeontx_ep/otx_ep_rxtx.c | 51 +++++++++++---------------- > 1 file changed, 20 insertions(+), 31 deletions(-) > > diff --git a/drivers/net/octeontx_ep/otx_ep_rxtx.c b/drivers/net/octeontx_ep/otx_ep_rxtx.c > index 28ff74d2d..4a7ddc264 100644 > --- a/drivers/net/octeontx_ep/otx_ep_rxtx.c > +++ b/drivers/net/octeontx_ep/otx_ep_rxtx.c > @@ -118,9 +118,8 @@ otx_ep_init_instr_queue(struct otx_ep_device *otx_ep, int iq_no, int num_descs, > goto iq_init_fail; > } > > - otx_ep_info("IQ[%d]: base: %p basedma: %lx count: %d\n", > - iq_no, iq->base_addr, (unsigned long)iq->base_addr_dma, > - iq->nb_desc); > + otx_ep_info("IQ[%d]: base: %p basedma: %" PRIx64 "count: %d\n", > + iq_no, iq->base_addr, iq->base_addr_dma, iq->nb_desc); > > iq->otx_ep_dev = otx_ep; > iq->q_no = iq_no; > @@ -298,8 +297,8 @@ otx_ep_init_droq(struct otx_ep_device *otx_ep, uint32_t q_no, > droq->desc_ring_dma = droq->desc_ring_mz->iova; > droq->desc_ring = (struct otx_ep_droq_desc *)droq->desc_ring_mz->addr; > > - otx_ep_dbg("OQ[%d]: desc_ring: virt: 0x%p, dma: %lx\n", > - q_no, droq->desc_ring, (unsigned long)droq->desc_ring_dma); > + otx_ep_dbg("OQ[%d]: desc_ring: virt: 0x%p, dma: %" PRIx64 "\n", > + q_no, droq->desc_ring, droq->desc_ring_dma); > otx_ep_dbg("OQ[%d]: num_desc: %d\n", q_no, droq->nb_desc); > > /* OQ buf_list set up */ > @@ -621,16 +620,14 @@ otx_ep_xmit_pkts(void *tx_queue, struct rte_mbuf **pkts, uint16_t nb_pkts) > > #ifdef OTX_EP_IO_DEBUG > otx_ep_dbg("After swapping\n"); > - otx_ep_dbg("Word0 [dptr]: 0x%016lx\n", > - (unsigned long)iqcmd.dptr); > - otx_ep_dbg("Word1 [ihtx]: 0x%016lx\n", (unsigned long)iqcmd.ih); > - otx_ep_dbg("Word2 [pki_ih3]: 0x%016lx\n", > - (unsigned long)iqcmd.pki_ih3); > - otx_ep_dbg("Word3 [rptr]: 0x%016lx\n", > - (unsigned long)iqcmd.rptr); > - otx_ep_dbg("Word4 [irh]: 0x%016lx\n", (unsigned long)iqcmd.irh); > - otx_ep_dbg("Word5 [exhdr[0]]: 0x%016lx\n", > - (unsigned long)iqcmd.exhdr[0]); > + otx_ep_dbg("Word0 [dptr]: 0x%016" PRIx64 "\n", iqcmd.dptr); > + otx_ep_dbg("Word1 [ihtx]: 0x%016" PRIx64 "\n", iqcmd.ih.u64); > + otx_ep_dbg("Word2 [pki_ih3]: 0x%016" PRIx64 "\n", > + iqcmd.pki_ih3.u64); > + otx_ep_dbg("Word3 [rptr]: 0x%016" PRIx64 "\n", iqcmd.rptr); > + otx_ep_dbg("Word4 [irh]: 0x%016" PRIx64 "\n", iqcmd.irh.u64); > + otx_ep_dbg("Word5 [exhdr[0]]: 0x%016" PRIx64 "\n", > + iqcmd.exhdr[0]); > rte_pktmbuf_dump(stdout, m, rte_pktmbuf_pkt_len(m)); > #endif > dbell = (i == (unsigned int)(nb_pkts - 1)) ? 1 : 0; > @@ -754,16 +751,12 @@ otx2_ep_xmit_pkts(void *tx_queue, struct rte_mbuf **pkts, uint16_t nb_pkts) > > #ifdef OTX_EP_IO_DEBUG > otx_ep_dbg("After swapping\n"); > - otx_ep_dbg("Word0 [dptr]: 0x%016lx\n", > - (unsigned long)iqcmd.dptr); > - otx_ep_dbg("Word1 [ihtx]: 0x%016lx\n", (unsigned long)iqcmd.ih); > - otx_ep_dbg("Word2 [pki_ih3]: 0x%016lx\n", > - (unsigned long)iqcmd.pki_ih3); > - otx_ep_dbg("Word3 [rptr]: 0x%016lx\n", > - (unsigned long)iqcmd.rptr); > - otx_ep_dbg("Word4 [irh]: 0x%016lx\n", (unsigned long)iqcmd.irh); > - otx_ep_dbg("Word5 [exhdr[0]]: 0x%016lx\n", > - (unsigned long)iqcmd.exhdr[0]); > + otx_ep_dbg("Word0 [dptr]: 0x%016" PRIx64 "\n", iqcmd2.dptr); > + otx_ep_dbg("Word1 [ihtx]: 0x%016" PRIx64 "\n", iqcmd2.ih.u64); > + otx_ep_dbg("Word2 [rptr]: 0x%016" PRIx64 "\n", iqcmd2.rptr); > + otx_ep_dbg("Word3 [irh]: 0x%016" PRIx64 "\n", iqcmd2.irh.u64); > + otx_ep_dbg("Word4 [exhdr[0]]: 0x%016" PRIx64 "\n", > + iqcmd2.exhdr[0]); > #endif > index = iq->host_write_index; > dbell = (i == (unsigned int)(nb_pkts - 1)) ? 1 : 0; > @@ -837,7 +830,7 @@ otx_ep_droq_read_packet(struct otx_ep_device *otx_ep, > struct otx_ep_droq_info *info2; > uint64_t total_pkt_len; > uint32_t pkt_len = 0; > - int next_idx; > + int next_idx, retry; > > droq_pkt = droq->recv_buf_list[droq->read_idx]; > droq_pkt2 = droq->recv_buf_list[droq->read_idx]; > @@ -845,11 +838,7 @@ otx_ep_droq_read_packet(struct otx_ep_device *otx_ep, > /* make sure info is available */ > rte_rmb(); > if (unlikely(!info->length)) { > - int retry = OTX_EP_MAX_DELAYED_PKT_RETRIES; > - /* otx_ep_dbg("OCTEON DROQ[%d]: read_idx: %d; Data not ready " > - * "yet, Retry; pending=%lu\n", droq->q_no, droq->read_idx, > - * droq->pkts_pending); > - */ > + retry = OTX_EP_MAX_DELAYED_PKT_RETRIES; > droq->stats.pkts_delayed_data++; > while (retry && !info->length) > retry--; > -- > 2.17.1 >