From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6B868A00C3; Fri, 15 May 2020 07:26:51 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4CE6A1D735; Fri, 15 May 2020 07:26:50 +0200 (CEST) Received: from mail-il1-f194.google.com (mail-il1-f194.google.com [209.85.166.194]) by dpdk.org (Postfix) with ESMTP id 4C1CB1D6D9 for ; Fri, 15 May 2020 07:26:49 +0200 (CEST) Received: by mail-il1-f194.google.com with SMTP id w18so1192718ilm.13 for ; Thu, 14 May 2020 22:26:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FhouiT4x8UomTEbaklpgrYmbizVhAm+WgEL4tTI1KXc=; b=VSgvRe4AJJNDxUamLRw0J3txbf5h011zlcOODb5anEwZDRfV0HcCLPb6S63ZFr/5/x vJIdEmb31ZDscCZEBQi2a+NnhsrOWnyqKDnuYilMMkRl+KqtXcK5z64FbmkmDL2R83Ci CCAui+SENq8ZWd3ilYDF49HQtJHxxnfPcCJ1F/yZLWXO3IQe+zSwe8v/u+WJvYpGIu/8 rTvfkO6XZmgruix0f65a4qprX+ej8I/ruzzhilPMo6pocmX5EU11ZTB1u1ZzXVicEdcN 54HX/Z6jdar//Wup31uItkAnNXYgVB50lmie43Z5hDpzqt0x+DM78Bs6lQWNZglIvuVF gY2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FhouiT4x8UomTEbaklpgrYmbizVhAm+WgEL4tTI1KXc=; b=s5dZvgANfNK88MRhgCIsqj3aK8XmO/C3zGS9EkO1xFHt5m82Jlxgqc5ArKV9qEwrD8 41lzNCl+Mo4iMuieTqpV9HR7o5CmXitIQYldVGXYDJTaUtQhOmppsAEJSzY54zsPF33X T09VBZKTgc9YVaGOBvxhhvRdrmrxBaMkHHjxXv8Udg0BIuj/uSBEf2hpxL8SA725weZy zG8Dg0HVHuQ/8eP91OI/5/ujCHjya7ZRLdHMyVBuRzQ0J541wjbO1upzK0tIyI4dwzYl YVmJ9U5j0fYgrjfGZVxzNmtUlMizFaeVwQbhG9HrJ+ooPH7H1yb7KThAA+n2eChk3Da3 j/ZA== X-Gm-Message-State: AOAM533QU2AS8APd/ypnOAPrPg4xVmAD7czjP8Eup0beRbxNqOS4XRbL vwciLeVGWVqqpcbN9hxR73P9jnMnMitTLGeNQAo= X-Google-Smtp-Source: ABdhPJxK9AK10VfUlovk3hAKUJ4sEcvtQi5xNm/tYrzp6v9JskOnENkiFVUnDGlkpVbRWZ/Q6lCWs5yg6d8Vj8fiiI8= X-Received: by 2002:a05:6e02:1341:: with SMTP id k1mr1699981ilr.162.1589520408519; Thu, 14 May 2020 22:26:48 -0700 (PDT) MIME-Version: 1.0 References: <20200513205600.6584-1-pbhagavatula@marvell.com> In-Reply-To: <20200513205600.6584-1-pbhagavatula@marvell.com> From: Jerin Jacob Date: Fri, 15 May 2020 10:56:32 +0530 Message-ID: To: Pavan Nikhilesh , David Marchand , Thomas Monjalon Cc: Jerin Jacob , Kiran Kumar K , Nithin Dabilpuram , dpdk-dev Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] test/graph_perf: fix memory leaks X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 14, 2020 at 2:26 AM wrote: > > From: Pavan Nikhilesh > > Fix memory leaks reported by coverity. > > Coverity issue: 358440, 358441, 358446. The last dot can be removed when merging. > Fixes: 61d77071ab99 ("test/graph: add performance tests") > > Signed-off-by: Pavan Nikhilesh Acked-by: Jerin Jacob > --- > app/test/test_graph_perf.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/app/test/test_graph_perf.c b/app/test/test_graph_perf.c > index 3089fb24c..296d99a9d 100644 > --- a/app/test/test_graph_perf.c > +++ b/app/test/test_graph_perf.c > @@ -76,6 +76,8 @@ test_node_ctx_init(const struct rte_graph *graph, struct rte_node *node) > RTE_SET_USED(graph); > > mz = rte_memzone_lookup(TEST_GRAPH_PERF_MZ); > + if (mz == NULL) > + return -ENOMEM; > graph_data = mz->addr; > node_data = graph_get_node_data(graph_data, nid); > node->ctx[0] = node->nb_edges; > @@ -570,6 +572,7 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks, > } > graph_data->graph_id = graph_id; > > + free(node_map); > for (i = 0; i < graph_data->nb_nodes; i++) > free(node_patterns[i]); > free(snk_nodes); > @@ -578,6 +581,7 @@ graph_init(const char *gname, uint8_t nb_srcs, uint8_t nb_sinks, > return 0; > > pattern_name_free: > + free(node_map); > for (i = 0; i < graph_data->nb_nodes; i++) > free(node_patterns[i]); > snk_free: > @@ -677,6 +681,8 @@ measure_perf(void) > struct test_graph_perf *graph_data; > > mz = rte_memzone_lookup(TEST_GRAPH_PERF_MZ); > + if (mz == NULL) > + return -ENOMEM; > graph_data = mz->addr; > > return measure_perf_get(graph_data->graph_id); > -- > 2.26.2 >