From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 0D769A0546;
	Tue,  6 Apr 2021 16:14:06 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 88675140FBA;
	Tue,  6 Apr 2021 16:14:06 +0200 (CEST)
Received: from mail-il1-f182.google.com (mail-il1-f182.google.com
 [209.85.166.182])
 by mails.dpdk.org (Postfix) with ESMTP id 55E0E140FB8
 for <dev@dpdk.org>; Tue,  6 Apr 2021 16:14:05 +0200 (CEST)
Received: by mail-il1-f182.google.com with SMTP id c18so6603954iln.7
 for <dev@dpdk.org>; Tue, 06 Apr 2021 07:14:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=3OajI3ZsJJpkIFroE+UKJ9EfD6h6FDOYVsuyGYxR2jQ=;
 b=khIQXsOagaKuJaF/rQG5sunyQuCWiAhJWyBaxcZcihTY/5yHYRSav6sw3X199EUXNB
 e0coFzzra9aZUMinK6INBtLnLyUHPxJ68EkDZBxcu212m34E/Zd6MkzYIHC5SVcHhuz5
 Xyrah+G87nyI0D198KBP9Xzrcma8zpwy4QYhqRbROnyUbvX03oRJE4/GCURTm0+ipiFv
 oCu+Q9XDY/RIOKYyMcdGng+9HrAYiL99Cr9ZZ3JZ5WxYZK1K/8/Px217C573h/9iBPvZ
 T0ZNB+wEzpWQ3D6uRF8ZT8ZHTgavLiHu8BEsB/htGTgfVXUsnTYn1/zXFuoJgvNbMQ7G
 RxUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=3OajI3ZsJJpkIFroE+UKJ9EfD6h6FDOYVsuyGYxR2jQ=;
 b=j6rbVFQ7WDn9RiiqIA2k/vBSFc+qUv4hiLofPb3TURhyNhTDEFqmshei+HxDeJw+Jd
 ZBEHzxMUFfcUpPOFeSB1lgYMl7TK9YJUxcwx8FwrfC96CsJ09Z6y2Z/SCq7/te4bLf/y
 QD3eEN8OCFK1opqg+NJK48Xlg1oFV+84KoFfUnebYPV4wqBqlsvx2/ciYKPtLTsK9BL0
 Kyr+++wj00skm8iyWN+f46F6f1RJ/Ga85djIvJQQC/qlhv2czy/bCAvwrOXpmbUSlxla
 RCeyE9ALHTuPK9a823ZPDXHH8quIdQp4Tzm5csifjT3ZsMgkcBB/zAaz6w1AzNCJmX82
 J9OA==
X-Gm-Message-State: AOAM5336AXYoX9WMc2aheQyaiMpRtELDu/SID5quumXshbC7IK6xOYxl
 yixrnk1HUrmSno8VxQL62UbXXJtR15QrlAbd32w=
X-Google-Smtp-Source: ABdhPJzjKSd2bCM6Zm01CAp9ypL+mPqVtg/YinO3hBQJbjOqgAzitSvaMIh6jLrqyUWojlR68pSOH0SyFdK5URpNGS8=
X-Received: by 2002:a05:6e02:672:: with SMTP id
 l18mr23123134ilt.271.1617718444643; 
 Tue, 06 Apr 2021 07:14:04 -0700 (PDT)
MIME-Version: 1.0
References: <20210309233116.1934666-1-thomas@monjalon.net>
 <20210405193954.1115838-5-thomas@monjalon.net>
 <CALBAE1PX-vqbwybEYQ9d2a8xFfBePYWoAA++x3nu_TC0x+Ay+Q@mail.gmail.com>
 <6370247.Qzv5sXHzo9@thomas>
In-Reply-To: <6370247.Qzv5sXHzo9@thomas>
From: Jerin Jacob <jerinjacobk@gmail.com>
Date: Tue, 6 Apr 2021 19:43:48 +0530
Message-ID: <CALBAE1OdCoY5ojNhfLoZ7JBK+1PQ9AztPFFPya=D5QJwHG_r_Q@mail.gmail.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: dpdk-dev <dev@dpdk.org>, David Marchand <david.marchand@redhat.com>, 
 Wisam Jaddo <wisamm@nvidia.com>, Bruce Richardson <bruce.richardson@intel.com>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
 Reshma Pattan <reshma.pattan@intel.com>, 
 Maryam Tahhan <maryam.tahhan@intel.com>,
 Konstantin Ananyev <konstantin.ananyev@intel.com>, 
 Nicolas Chautru <nicolas.chautru@intel.com>,
 Declan Doherty <declan.doherty@intel.com>, 
 Ciara Power <ciara.power@intel.com>,
 Vladimir Medvedkin <vladimir.medvedkin@intel.com>, 
 Xiaoyun Li <xiaoyun.li@intel.com>, Ori Kam <orika@nvidia.com>, 
 Bernard Iremonger <bernard.iremonger@intel.com>
Content-Type: text/plain; charset="UTF-8"
Subject: Re: [dpdk-dev] [PATCH v5 4/4] app: hook in EAL usage help
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Tue, Apr 6, 2021 at 7:35 PM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 06/04/2021 15:32, Jerin Jacob:
> > On Tue, Apr 6, 2021 at 1:10 AM Thomas Monjalon <thomas@monjalon.net> wrote:
> > >
> > > Use rte_set_application_usage_hook() in the test applications,
> > > so the full help including EAL options can be printed in one go
> > > with the EAL option -h or --help.
> [...]
> > > +       rte_set_application_usage_hook(print_usage);
> >
> > All DPDK APIs, We are having rte_<subsystem><...><verb> kind of API
> > name convention.
> > I think, it is better to change to rte_application_usage_hook_set() to
> > express the hierarchy.
>
> The naming of this function is not fantastic.
> Without thinking about a better name, we should ask if we want to go
> through a deprecation of this function name?

I thought it is a new function introduced by this series. Ignore my
comment as the function is already present in the codebase.


>
>