From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 342B9A00C3; Thu, 14 May 2020 09:56:43 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 51B7D1D68A; Thu, 14 May 2020 09:56:42 +0200 (CEST) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by dpdk.org (Postfix) with ESMTP id 898271D67F for ; Thu, 14 May 2020 09:56:40 +0200 (CEST) Received: by mail-io1-f67.google.com with SMTP id x5so1025606ioh.6 for ; Thu, 14 May 2020 00:56:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NFe26H5HtVfw3G5Ijz7PG34l726eeTwmzxzweZ9DtOg=; b=gTI8DR4Cw6k8TprOLTFakGS/bRkoFCBVFTJDjF657Ry2CoLaIv+gXkMAdsWMkTpd11 DYxinHxy2PRDKXExYMquiTfaAiuHWqfHoZUAaNs6PrByYQA2/tSRo5wyFAV/ckKwFB42 8c4uUXwNVKi9gRGCrpSX4UkqlusY2AA1N/27BMDdjYbR8KuhRBms5MOHs2uBiOVWJUDA bEsEfalsYpBOZpNvDYnU+uJ4B/gkwRhluvZHkFs2gJrrBqC0F9ek8SV7xtnc1TvaSwdU 6+co+/GKf0nv5BJYxz7gBAQmApGShcRHQ+dHV+IHYnFv8C99XiLnxPqctjdIgGV3bB3M 67BQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NFe26H5HtVfw3G5Ijz7PG34l726eeTwmzxzweZ9DtOg=; b=n4VVeb9yjwyzCX3Zi6LuMq3LaYMdpsXSmCYXfZ4PQHXfFb5IS+kJ0GlEC0pcnwzd1W Iou4wR/Cqd3h+NgFS9LMLxxKB8RJ5jF8vpgwmpaKF+s/lTjOEJeyqQktG26eAOwY8n7v oDm2yvt/1uA1itkKBcCQFxZHZ6QkYDd1BtYz9PLrg4doWhOiSHyzEGPQnz7HNo0DJUtw BhgnepDtbi9TwTNM9kfuDMqjvhFtmY3XJBx5/QjR1Wg8tg4nEfcXiot1k2mPT+O3DWEX 3n5w9j6xfFpwoYHDZ0dzA3g6tPw7gwBLasnoXm8VebfRgljzCq5HR0Qr2fFpteW8e82c gr9w== X-Gm-Message-State: AOAM5315g6U3XjrkU2JezIvQmK4OPSIC//YY8ePVk5tUfp0p2BHJv8Xb 2pozeco7yaiMZy1UX7SuYIibxL8OG2Gp8b22ca0= X-Google-Smtp-Source: ABdhPJzkPXFWHvn0oURBhyW3Fx+2BDG4yu8/+5MhYFMrT4ReLR/NGJiJCicXR1XZVCHIXuFYUWL8puvL1lf1r70e8hM= X-Received: by 2002:a05:6602:2dca:: with SMTP id l10mr2941593iow.163.1589442999766; Thu, 14 May 2020 00:56:39 -0700 (PDT) MIME-Version: 1.0 References: <20200505030943.1091-1-rmody@marvell.com> <4248918.cEBGB3zze1@thomas> In-Reply-To: From: Jerin Jacob Date: Thu, 14 May 2020 13:26:23 +0530 Message-ID: To: Rasesh Mody Cc: Thomas Monjalon , Ferruh Yigit , dpdk-dev , Jerin Jacob Kollanukkaran , GR-Everest-DPDK-Dev , Igor Russkikh , Andrew Rybchenko Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [EXT] Re: [PATCH 2/2] net/qede: restore Tx queue setup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 14, 2020 at 9:40 AM Rasesh Mody wrote: > > >> >> > +ethdev maintainers. > >> >> > > >> >> > I think, Ideally, the fix should be in common code if we need to > >> >> > support such applications. > >> >> > >> >> Is this a case application re-configures to increase the number of > >> >> queues but doesn't setup new queues? > >> >> If so this looks like application error and application should be > >> >> fixed instead of recover this in the ethdev. > >> > > >> >+1 > >> > > >> > >> This is a case of KNI application performing device re-configuration to > >change MTU. The application explicitly calls Rx queue setup, however doesn't > >call Tx queue setup. When MTU for KNI interface is changed it runs into a > >segfault when trying to start Tx queues. > > > >Can we fix the KNI application then? > > Yes, I have submitted a v2 series with changes to KNI application. Please apply for -rc3. Since it has the KNI app change, I have delegated the series to @Ferruh Yigit to take it over next-net instead of next-net-mrvl.