From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9C85BA0524; Thu, 6 May 2021 11:02:12 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 11CEE410DB; Thu, 6 May 2021 11:02:12 +0200 (CEST) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id 2BC1140040 for ; Thu, 6 May 2021 11:02:11 +0200 (CEST) Received: by mail-io1-f48.google.com with SMTP id t3so4183572iol.5 for ; Thu, 06 May 2021 02:02:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Zk70cQYv5gK1EjSVea//Q/RJGSo5IKXnvVEDg56cqIs=; b=h4xebN/2QC3EfXJeFFK9qVIahsw5zWdXr5JwZ8nbDPKL9cLzZuebmzRjqhP5YnP15l RcOI9QDzD4Bwem1t0pR1w/d6cjQSNkDbzEWQCZHc/HgY0dupX2JDuPOB0r+irhRdiV4N ZWhVo58vgrgRTP4ZlI32vH3sxBUGLKhMBcudQ05xrEXorbncwWYl0Ph2efCCB0v1T+Jq byMVK24ZEPVoGLSloH9nebm6qiUtq8oul5qTtR3NCFA1rbtYCZyYkz/Vn/tyAwEZ2ELb WmUjS2+NslNeL7nirVi9e98ZQS3w0y0dAzpJwUOR7vGionSl1P+VjjAgp/qNreF5zaf9 +65A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Zk70cQYv5gK1EjSVea//Q/RJGSo5IKXnvVEDg56cqIs=; b=Wdqs+yK3cO+7cGDsM+WXHpw28YqkXH8ZYdih6CoRSCYOQS3CpdbJhoRKTjRF/GWrza wN9rRtbOnVQOzEMyeqF5QiURHOOTndkgh8MXT/wXsRyQ3hqvTQhFri53gLnXgcRPHDAW FgyLYMbcoJfP8mHs3xDhXhiLRB5RkPqFfidKAW9pZ1fdtZ6uEMcKnWtU2gYNlbwmEaVW TZc66ELnmH5kxKTpxJel6FF+K8FF+ErSdM3WLOMU3NSsuQp4Qkd00qCRR2e7umlsgo51 QNUsTip4ZceuLfOxO2mhw92a8+DI7NRulNFDkbE5vTzSxn4pDgBbNvc9OynjA6Ah0sdR UMrw== X-Gm-Message-State: AOAM530A6Yfes5QKoWpQ4HbSBDA+/Cb3t6/pEpTodzjo0n6igEgqKZU6 mUmempCDyFDTQZxw7S7fhY55oMJrE6jprKj23SA= X-Google-Smtp-Source: ABdhPJxGm8VEzH2neXH25d4Q4KGwEKJAveYzerbh3F5RVq7h4c+pRNuxRsnZXN3WeJUdTEtgrlvunh4wir680aD5QdA= X-Received: by 2002:a5d:8188:: with SMTP id u8mr2407682ion.163.1620291730463; Thu, 06 May 2021 02:02:10 -0700 (PDT) MIME-Version: 1.0 References: <1619092340-4047-1-git-send-email-humin29@huawei.com> <1620285387-42792-1-git-send-email-humin29@huawei.com> <1620285387-42792-3-git-send-email-humin29@huawei.com> In-Reply-To: <1620285387-42792-3-git-send-email-humin29@huawei.com> From: Jerin Jacob Date: Thu, 6 May 2021 14:31:54 +0530 Message-ID: To: "Min Hu (Connor)" Cc: dpdk-dev , Ferruh Yigit , Thomas Monjalon , David Marchand , Jerin Jacob , Kiran Kumar K Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH v2 2/2] graph: fix dereferencing null pointer X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, May 6, 2021 at 12:46 PM Min Hu (Connor) wrote: > > From: HongBo Zheng > > In function 'stats_mem_init', pointer 'stats' should > be confirmed not null before memset it. > > Fixes: af1ae8b6a32c ("graph: implement stats") > Cc: stable@dpdk.org > > Signed-off-by: HongBo Zheng > Signed-off-by: Min Hu (Connor) Reviewed-by: Jerin Jacob > --- > lib/graph/graph_stats.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/graph/graph_stats.c b/lib/graph/graph_stats.c > index 30e295d..aa70929 100644 > --- a/lib/graph/graph_stats.c > +++ b/lib/graph/graph_stats.c > @@ -119,8 +119,8 @@ stats_mem_init(struct cluster *cluster, > cluster_node_size = RTE_ALIGN(cluster_node_size, RTE_CACHE_LINE_SIZE); > > stats = realloc(NULL, sz); > - memset(stats, 0, sz); > if (stats) { > + memset(stats, 0, sz); > stats->fn = fn; > stats->cluster_node_size = cluster_node_size; > stats->max_nodes = 0; > -- > 2.7.4 >