* [dpdk-dev] [PATCH] common/cnxk: fix base rule merging only for ingress
@ 2022-01-25 4:17 psatheesh
2022-02-17 8:12 ` Jerin Jacob
0 siblings, 1 reply; 2+ messages in thread
From: psatheesh @ 2022-01-25 4:17 UTC (permalink / raw)
To: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao
Cc: dev, Satheesh Paul, stable
From: Satheesh Paul <psatheesh@marvell.com>
When creating flow rule, merge base steering rule only
for ingress rules.
Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
---
drivers/common/cnxk/roc_npc_mcam.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c
index b251f643bc..7a3a8944f5 100644
--- a/drivers/common/cnxk/roc_npc_mcam.c
+++ b/drivers/common/cnxk/roc_npc_mcam.c
@@ -752,7 +752,7 @@ npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc)
if (pst->set_ipv6ext_ltype_mask)
npc_set_ipv6ext_ltype_mask(pst);
- if (pst->is_vf) {
+ if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX) {
(void)mbox_alloc_msg_npc_read_base_steer_rule(npc->mbox);
rc = mbox_process_msg(npc->mbox, (void *)&base_rule_rsp);
if (rc) {
--
2.25.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [dpdk-dev] [PATCH] common/cnxk: fix base rule merging only for ingress
2022-01-25 4:17 [dpdk-dev] [PATCH] common/cnxk: fix base rule merging only for ingress psatheesh
@ 2022-02-17 8:12 ` Jerin Jacob
0 siblings, 0 replies; 2+ messages in thread
From: Jerin Jacob @ 2022-02-17 8:12 UTC (permalink / raw)
To: Satheesh Paul, Ferruh Yigit
Cc: Nithin Dabilpuram, Kiran Kumar K, Sunil Kumar Kori, Satha Rao,
dpdk-dev, dpdk stable
On Tue, Jan 25, 2022 at 9:48 AM <psatheesh@marvell.com> wrote:
>
> From: Satheesh Paul <psatheesh@marvell.com>
>
> When creating flow rule, merge base steering rule only
> for ingress rules.
>
> Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
> Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
Updated the commit as follows and applied to
dpdk-next-net-mrvl/for-next-net. Thanks
common/cnxk: fix base rule merge
Egress rules do not have a base steering rule and the
current base steering rule is applicable only for ingress
rules. Hence, when creating a flow rule, merge base steering
rule only for ingress rules.
Fixes: f9af9080746 ("common/cnxk: add mcam utility API")
Cc: stable@dpdk.org
Signed-off-by: Satheesh Paul <psatheesh@marvell.com>
Reviewed-by: Kiran Kumar Kokkilagadda <kirankumark@marvell.com>
> ---
> drivers/common/cnxk/roc_npc_mcam.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_npc_mcam.c b/drivers/common/cnxk/roc_npc_mcam.c
> index b251f643bc..7a3a8944f5 100644
> --- a/drivers/common/cnxk/roc_npc_mcam.c
> +++ b/drivers/common/cnxk/roc_npc_mcam.c
> @@ -752,7 +752,7 @@ npc_program_mcam(struct npc *npc, struct npc_parse_state *pst, bool mcam_alloc)
> if (pst->set_ipv6ext_ltype_mask)
> npc_set_ipv6ext_ltype_mask(pst);
>
> - if (pst->is_vf) {
> + if (pst->is_vf && pst->flow->nix_intf == NIX_INTF_RX) {
> (void)mbox_alloc_msg_npc_read_base_steer_rule(npc->mbox);
> rc = mbox_process_msg(npc->mbox, (void *)&base_rule_rsp);
> if (rc) {
> --
> 2.25.4
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-02-17 8:12 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-25 4:17 [dpdk-dev] [PATCH] common/cnxk: fix base rule merging only for ingress psatheesh
2022-02-17 8:12 ` Jerin Jacob
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).