From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B86C342380; Mon, 9 Jan 2023 16:28:27 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9DD1540687; Mon, 9 Jan 2023 16:28:27 +0100 (CET) Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by mails.dpdk.org (Postfix) with ESMTP id 5FBAA4067C for ; Mon, 9 Jan 2023 16:28:25 +0100 (CET) Received: by mail-vs1-f43.google.com with SMTP id m2so8951252vsv.9 for ; Mon, 09 Jan 2023 07:28:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=nIT/dmHmBFG8FcmELNjwqPGJhe8KsEBMT7RUVDyMG9k=; b=o0sB1aVl1vt9pqdFsR9BjY/0ExPHhJh3UCrnGwOXxy4WOpZ1p+MCK1dE5m1M/JX0PU DrjFuwURtWH43b5yBh9XWWv2GJ1nB4aXt0Ie9l8wSe/SMnJjkmuOHKRYWzIJlc5d1ZFi 7JHGOU9CrlWhg1bsoedZ2VwazHyWu3GKHN/n4/vL/2X9xyKoYqUlx8ZUQiEXZOZt9H/6 PKTXRqg1cF3AjRajKaeQOuYG35PnvMtrfl2e41PpNe0JE3OlYBg1Kmj9l4nCVQkfiC8J Haon2uOMMN0ILu23cHbg2IU/5KnygMduX0k5EeZscwb3Iym3yf/QmnIhv/NR2GE4gGyX ogLA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=nIT/dmHmBFG8FcmELNjwqPGJhe8KsEBMT7RUVDyMG9k=; b=F5E3r6KYudMF+Sok/cnUAI9dOwKd+KS8uJ0ZEmHo4GnGy4R0CDc/kzsQo0va3qxzKU 9BAH3QeJeQ44fFN2tbDMy0fNI6MPqz27VMrPoqDF8tQfpaYjC5ubt0+kJNrUuaOZwYgr aiK8/el+PR9Ru1n8VgBnJE5Mods33Z7+mxiDuUjvl/xOh7E6hESlhsaDFElnJQZBBsqP aup8QlvJZlpDYT5Ksc0J0pfqKuDBpzOUC7ZPa6qKVsGAwgZcDdL6dVCuiJ/wgj6clAh7 JdDoDKMkeJn3+ArTi5SG1mvDpSvO4Y0ccEDtVMvUOya78iCtdru7iarjHKhqOxe50SLV cA+w== X-Gm-Message-State: AFqh2koDZHf3ukQkRdUyeGjEbt8Y7YiShqk3+G7o0DZzyOqARXAMinQp s4vNOwro48eMRZyPsjqTXRxHiYB2I+Q8fpeztnE= X-Google-Smtp-Source: AMrXdXugxU4TQfCuEitD7YacFztbHkCz3JESuLJh0VBxRGQ/UKS23tWitu0BTNCDw8Cvjy8zzJbAyRShRafdWqA3er0= X-Received: by 2002:a67:fd97:0:b0:3d0:bfd2:3a12 with SMTP id k23-20020a67fd97000000b003d0bfd23a12mr99771vsq.52.1673278104643; Mon, 09 Jan 2023 07:28:24 -0800 (PST) MIME-Version: 1.0 References: <20221201040344.2977495-1-psatheesh@marvell.com> In-Reply-To: <20221201040344.2977495-1-psatheesh@marvell.com> From: Jerin Jacob Date: Mon, 9 Jan 2023 20:57:58 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH] common/cnxk: move ICMP ltype to end of enum To: psatheesh@marvell.com Cc: Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao , dev@dpdk.org, Jerin Jacob Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Dec 1, 2022 at 9:33 AM wrote: > > From: Kiran Kumar K > > While configuring the RSS key, mask has been created to match multiple > ltypes for L4. Since ICMP is placed in between, it is also being > considered for RSS. So, moving the ICMP to end of enum. > > Signed-off-by: Kiran Kumar K > Reviewed-by: Jerin Jacob Applied to dpdk-next-net-mrvl/for-next-net. Thanks > --- > drivers/common/cnxk/hw/npc.h | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/drivers/common/cnxk/hw/npc.h b/drivers/common/cnxk/hw/npc.h > index b8218e25af..4164c6ac2e 100644 > --- a/drivers/common/cnxk/hw/npc.h > +++ b/drivers/common/cnxk/hw/npc.h > @@ -219,8 +219,7 @@ enum npc_kpu_lc_ltype { > enum npc_kpu_ld_ltype { > NPC_LT_LD_TCP = 1, > NPC_LT_LD_UDP, > - NPC_LT_LD_ICMP, > - NPC_LT_LD_SCTP, > + NPC_LT_LD_SCTP = 4, > NPC_LT_LD_ICMP6, > NPC_LT_LD_CUSTOM0, > NPC_LT_LD_CUSTOM1, > @@ -231,6 +230,7 @@ enum npc_kpu_ld_ltype { > NPC_LT_LD_NSH, > NPC_LT_LD_TU_MPLS_IN_NSH, > NPC_LT_LD_TU_MPLS_IN_IP, > + NPC_LT_LD_ICMP, > }; > > enum npc_kpu_le_ltype { > @@ -276,14 +276,14 @@ enum npc_kpu_lg_ltype { > enum npc_kpu_lh_ltype { > NPC_LT_LH_TU_TCP = 1, > NPC_LT_LH_TU_UDP, > - NPC_LT_LH_TU_ICMP, > - NPC_LT_LH_TU_SCTP, > + NPC_LT_LH_TU_SCTP = 4, > NPC_LT_LH_TU_ICMP6, > + NPC_LT_LH_CUSTOM0, > + NPC_LT_LH_CUSTOM1, > NPC_LT_LH_TU_IGMP = 8, > NPC_LT_LH_TU_ESP, > NPC_LT_LH_TU_AH, > - NPC_LT_LH_CUSTOM0 = 0xE, > - NPC_LT_LH_CUSTOM1 = 0xF, > + NPC_LT_LH_TU_ICMP = 0xF, > }; > > enum npc_kpu_lb_uflag { > -- > 2.35.3 >