From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 031CE43BA0; Fri, 23 Feb 2024 10:04:55 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 889A84068A; Fri, 23 Feb 2024 10:04:55 +0100 (CET) Received: from mail-pg1-f176.google.com (mail-pg1-f176.google.com [209.85.215.176]) by mails.dpdk.org (Postfix) with ESMTP id EEC40402ED for ; Fri, 23 Feb 2024 10:04:54 +0100 (CET) Received: by mail-pg1-f176.google.com with SMTP id 41be03b00d2f7-5dbcfa0eb5dso464279a12.3 for ; Fri, 23 Feb 2024 01:04:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1708679094; x=1709283894; darn=dpdk.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=YKrzKVh/NCKqxXfelVYNyoapCWrcdpekg9tthNIGiII=; b=Kj176i0825ge5dyJI45gmrjMxPFBfy0FEVDOncJCcyNeuR+fAz4pk6wyxr2jm2mR1i BKLRm5dgD7+bPqG3lyLa/P0w0e/HEgRau1NEqZNoo25MMITV5wmi9rtFPu64qO5YnwJv 8RElzNoSJ3Wk8UlNq18lwE0lb/SLwfwfHI349rx6KGRjnbYU7VVk1CS/XMUUsBHnKWv5 MOXhSVAd1bBqOERyoEl7QLCpFgIuS9Gqwou6vw3YLdKxbU4kp7TX9nB85O+VzH0XMdU7 aZ7wlou0Rzok87zdOLiLyLC3NIdXbkpz7P3wSsT7OthSW4Wv6YvdVm1Z/VctNFYGOQgW RpnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708679094; x=1709283894; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YKrzKVh/NCKqxXfelVYNyoapCWrcdpekg9tthNIGiII=; b=siIWvNoaFSvRggXLLAIkYhu+IwWjtHWsiVOwr+zf4LEzmXfKx5dv/uPofqAqDEFYSl UNV4RHQnXHHoeAduO/iLF4wdloBqQYzdGqMKID16Klurn3AIQoutMT5HyepclXmtiVUB Tshn64FVn74zGXUKmnLDv4LfgWNhgcLEOgDDf/ABqODp4F29b3ryQRX2aEcqVLutpqlc B0fUpISIK0YxltPrC0FPsTv9fHIRu+Inged8BJ7qtC9UGbESrPWECcGR3PmawVuoKQgn iNZocIMhO6bc+exsZKqWE4yaRgIGKaIRosVnXxp4gzlRELvtETe4CLI7ZbvanbIP05AS N0dg== X-Gm-Message-State: AOJu0YzW3wYtV8ujlBlyPsnTPvPAoq+nMBJ8vgKf/j22JtDYFk8deJKp OEVL0fWAlmhuaYyoP+cada/DMLHS3q/y3Oxitu2266sHOqSg1UPo7nUvCcYzw6gN7+7aPu+9Gfw I76Fpjh4IQ40QYq9FuX6WtLcZ1Fg= X-Google-Smtp-Source: AGHT+IH/FwIxiALxsf6rxkpgnmHUpTKc0fek6LOoF/7UHp9j51fqowEGBPDd6XtM/1JhEbfSMuz662NBmCQYt9SnfL8= X-Received: by 2002:a05:6a20:a895:b0:19c:678d:c1c with SMTP id ca21-20020a056a20a89500b0019c678d0c1cmr940716pzb.37.1708679093911; Fri, 23 Feb 2024 01:04:53 -0800 (PST) MIME-Version: 1.0 References: <20240119055721.1750399-1-rbhansali@marvell.com> <20240222100729.991411-1-rbhansali@marvell.com> <20240222100729.991411-5-rbhansali@marvell.com> In-Reply-To: <20240222100729.991411-5-rbhansali@marvell.com> From: Jerin Jacob Date: Fri, 23 Feb 2024 14:34:27 +0530 Message-ID: Subject: Re: [PATCH v2 5/5] net/cnxk: select optimized LLC transaction type To: Rahul Bhansali Cc: dev@dpdk.org, Nithin Dabilpuram , Kiran Kumar K , Sunil Kumar Kori , Satha Rao Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 22, 2024 at 3:38=E2=80=AFPM Rahul Bhansali wrote: > > LLC transaction optimization by using LDWB LDTYPE option > in SG preparation for Tx. With this, if data is present > and dirty in LLC then the LLC would mark the data clean. > > Signed-off-by: Rahul Bhansali Series applied to dpdk-next-net-mrvl/for-main. Thanks > --- > Changes in v2: No change > > drivers/net/cnxk/cn10k_tx.h | 16 +++++++++++++--- > 1 file changed, 13 insertions(+), 3 deletions(-) > > diff --git a/drivers/net/cnxk/cn10k_tx.h b/drivers/net/cnxk/cn10k_tx.h > index 664e47e1fc..fcd19be77e 100644 > --- a/drivers/net/cnxk/cn10k_tx.h > +++ b/drivers/net/cnxk/cn10k_tx.h > @@ -331,9 +331,15 @@ cn10k_nix_tx_skeleton(struct cn10k_eth_txq *txq, uin= t64_t *cmd, > else > cmd[2] =3D NIX_SUBDC_EXT << 60; > cmd[3] =3D 0; > - cmd[4] =3D (NIX_SUBDC_SG << 60) | BIT_ULL(48); > + if (!(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F)) > + cmd[4] =3D (NIX_SUBDC_SG << 60) | (NIX_SENDLDTYPE= _LDWB << 58) | BIT_ULL(48); > + else > + cmd[4] =3D (NIX_SUBDC_SG << 60) | BIT_ULL(48); > } else { > - cmd[2] =3D (NIX_SUBDC_SG << 60) | BIT_ULL(48); > + if (!(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F)) > + cmd[2] =3D (NIX_SUBDC_SG << 60) | (NIX_SENDLDTYPE= _LDWB << 58) | BIT_ULL(48); > + else > + cmd[2] =3D (NIX_SUBDC_SG << 60) | BIT_ULL(48); > } > } > > @@ -1989,7 +1995,11 @@ cn10k_nix_xmit_pkts_vector(void *tx_queue, uint64_= t *ws, > > senddesc01_w1 =3D vdupq_n_u64(0); > senddesc23_w1 =3D senddesc01_w1; > - sgdesc01_w0 =3D vdupq_n_u64((NIX_SUBDC_SG << 60) | BIT_ULL(48)); > + if (!(flags & NIX_TX_OFFLOAD_MBUF_NOFF_F)) > + sgdesc01_w0 =3D vdupq_n_u64((NIX_SUBDC_SG << 60) | (NIX_S= ENDLDTYPE_LDWB << 58) | > + BIT_ULL(48)); > + else > + sgdesc01_w0 =3D vdupq_n_u64((NIX_SUBDC_SG << 60) | BIT_UL= L(48)); > sgdesc23_w0 =3D sgdesc01_w0; > > if (flags & NIX_TX_NEED_EXT_HDR) { > -- > 2.25.1 >