From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 641D1A0544; Wed, 8 Jun 2022 10:22:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 581A4427EC; Wed, 8 Jun 2022 10:22:46 +0200 (CEST) Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) by mails.dpdk.org (Postfix) with ESMTP id 0C2794113F for ; Wed, 8 Jun 2022 10:22:45 +0200 (CEST) Received: by mail-qk1-f171.google.com with SMTP id o68so14991846qkf.13 for ; Wed, 08 Jun 2022 01:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UIa12O+Lo+Alcwr0mDXMJlCmGH8q5RsfNQSFiPhE69c=; b=M9KM6OwX6cImddo0GBnqfB3Ef8lSfPcPP30HcDAmuHITXbsgkqnOsNbH76swIUbc/q EKXuKs63lF3gCpOfHiapRyYTr0m591/NowfwnOcRS5Zmfaz9t36eb2MXASFjbYvnnyMT epdGI0YydTqv5a8T79GCKZ4i0eIPXKHKM2RGIHneMkZ33FOjepk/6BSKiRgsEHDs6gyD Lk7IYegnekCR1moyQ9b0c3145cVL0S6DCP1oqxmiQJMF1D7chbcwtPIFTD9bp1h4DeW1 4HvrsvJLR2LgSp2QrZYW5fCUG2ufJPqEGHgqkziop8SCJwX2Vl4BYlolKTU48fW0Hxwk TAlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UIa12O+Lo+Alcwr0mDXMJlCmGH8q5RsfNQSFiPhE69c=; b=WU3UvmWFGLgHE5W0nP2rJ8cDGk3wLmb5l0i8RNS4eETNcGtZa/XfdFdo9JI7YlNDYd kj8rxwgmxZgl2v8zpf7StvW7ikicWI7ordKns1Owv2WunRNn9tp65AxZKpn+EPyAr0fX LIcQxHWbfpvChi90nVshcq/N46zQNIEwVjw6F32EqMtM/qm7yWcGs2QJdc4nRkiL7gnD YAUXB6fV4oTNm4f7xEoekCAolOlPfmqn6590bWWxHAk4OOozaef4qF00LjbIk1y6hNqT UVKUThbhH/mL0h1JCiGUWjLcTOaUZSiQnhgKknwO74auZeanDrtWLJaj0aylV/ynLvfu nsUg== X-Gm-Message-State: AOAM533eXviTd517XRPCGtzGYCmVMmDpSisrHN24Zm9SmtUkASgu7KSs UuwqT+671BBQXYn+aaCFzUIlcyA+EkzVeTKHYDw= X-Google-Smtp-Source: ABdhPJxdjlH6BOU5RQX1xyIMk+Qd8fuWwugx3IiToP3+untZNMAIK2cmfbaLiiVgN86hdGgmbQ6vJQtMguk+3F+JCtA= X-Received: by 2002:a37:8e02:0:b0:6a6:d74f:90bc with SMTP id q2-20020a378e02000000b006a6d74f90bcmr5171473qkd.316.1654676564454; Wed, 08 Jun 2022 01:22:44 -0700 (PDT) MIME-Version: 1.0 References: <20220602092356.2788089-1-jerinj@marvell.com> <7385990.EvYhyI6sBW@thomas> In-Reply-To: From: Jerin Jacob Date: Wed, 8 Jun 2022 13:52:18 +0530 Message-ID: Subject: Re: [dpdk-dev] [PATCH v1] build: ccache support for cross build To: Thomas Monjalon Cc: Bruce Richardson , Jerin Jacob , dpdk-dev , Ruifeng Wang , Jan Viktorin , David Christensen , Konstantin Ananyev , David Marchand , =?UTF-8?Q?Juraj_Linke=C5=A1?= , fengchengwen Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Jun 2, 2022 at 5:30 PM Jerin Jacob wrote: > > On Thu, Jun 2, 2022 at 4:25 PM Thomas Monjalon wrote: > > > > 02/06/2022 11:43, Jerin Jacob: > > > On Thu, Jun 2, 2022 at 3:11 PM Bruce Richardson > > > wrote: > > > > > > > > On Thu, Jun 02, 2022 at 02:53:55PM +0530, jerinj@marvell.com wrote: > > > > > From: Jerin Jacob > > > > > > > > > > By default, ccache is not used for cross build[1]. > > > > > Update all cross files to use ccache if it is available > > > > > in build machine. > > > > > > > > > > [1] > > > > > https://mesonbuild.com/Machine-files.html > > > > > > > > > > Signed-off-by: Jerin Jacob > > > > > > > > Does this still work even if ccache is not available? That's not fully > > > > > > Yes. > > > > > > > clear from the docs, but it seems to be that if an array is passed the > > > > whole array is used as the command, rather than just one element of the > > > > array. That would imply that cross-builds now require ccache. Is that > > > > acceptable? > > > > > > I have removed ccache from the build machine still it works. > > > > I don't understand why it works without ccache. > > Meson is detecting valid compiler prefix. ccache is one of them. > > See > https://github.com/fabio-porcedda/meson/commit/44db495f5ece43645ca3994dc95895c76a828530 > https://github.com/mesonbuild/meson/issues/1392 I hope there are no other review comments to fix it for this patch. Since it is improving the build time for cross-build. If there is no objection to this patch, Please merge it. > > > > > > > In general, I would prefer we have a mechanism to update the cross file > > on the fly, depending on the setup. > > I believe, It would be a departure from the meson cross-file concept. > > > We have this for toolchain prefix name. > > The prefix depends on where the toochain comes from. > > In a "normal" build system, we set the prefix with an environment variable, > > not by writing a file. > > > >