From: Jerin Jacob <jerinjacobk@gmail.com>
To: Ankur Dwivedi <adwivedi@marvell.com>
Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com,
ferruh.yigit@amd.com, jerinj@marvell.com
Subject: Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map
Date: Fri, 10 Feb 2023 11:14:21 +0530 [thread overview]
Message-ID: <CALBAE1OkLiu4WyJvM6Ms1Yf1TxjHQxODRktpGeq2YkGpkP9Qow@mail.gmail.com> (raw)
In-Reply-To: <20230209133019.933380-2-adwivedi@marvell.com>
On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi <adwivedi@marvell.com> wrote:
>
> The file rte_mempool_trace.h contains tracepoints which are internal to the
> mempool library. This file is renamed to mempool_trace.h, and is made an
> internal header. The tracepoints in this file are removed from the
> experimental section in version.map file.
>
> Signed-off-by: Ankur Dwivedi <adwivedi@marvell.com>
> @@ -47,22 +47,8 @@ EXPERIMENTAL {
> __rte_mempool_trace_generic_get;
> __rte_mempool_trace_get_bulk;
> __rte_mempool_trace_get_contig_blocks;
I think, FP ones also can be removed.
Also, in one of the patch(may be eal). Update the doc
https://doc.dpdk.org/guides/prog_guide/trace_lib.html
The following note can be removed:
The RTE_TRACE_POINT_REGISTER defines the placeholder for the
rte_trace_point_t tracepoint object. The user must export a
__<trace_function_name> symbol in the library .map file for this
tracepoint to be used out of the library, in shared builds. For
example, __app_trace_string will be the exported symbol in the above
example.
> - __rte_mempool_trace_create;
> - __rte_mempool_trace_create_empty;
> - __rte_mempool_trace_free;
> - __rte_mempool_trace_populate_iova;
> - __rte_mempool_trace_populate_virt;
> - __rte_mempool_trace_populate_default;
> - __rte_mempool_trace_populate_anon;
> - __rte_mempool_trace_cache_create;
> - __rte_mempool_trace_cache_free;
> __rte_mempool_trace_default_cache;
> - __rte_mempool_trace_get_page_size;
> __rte_mempool_trace_cache_flush;
> - __rte_mempool_trace_ops_populate;
> - __rte_mempool_trace_ops_alloc;
> - __rte_mempool_trace_ops_free;
> - __rte_mempool_trace_set_ops_byname;
> };
>
> INTERNAL {
> --
> 2.25.1
>
next prev parent reply other threads:[~2023-02-10 5:44 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-09 13:30 [PATCH v1 0/5] " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 1/5] mempool: " Ankur Dwivedi
2023-02-09 14:23 ` David Marchand
2023-02-10 5:32 ` [EXT] " Ankur Dwivedi
2023-02-10 5:44 ` Jerin Jacob [this message]
2023-02-10 7:00 ` Ankur Dwivedi
2023-02-10 7:06 ` Jerin Jacob
2023-02-10 14:24 ` David Marchand
2023-02-10 15:32 ` Jerin Jacob
2023-02-14 11:37 ` Ankur Dwivedi
2023-02-20 14:18 ` David Marchand
2023-02-09 13:30 ` [PATCH v1 2/5] cryptodev: " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 3/5] eal: " Ankur Dwivedi
2023-02-09 13:30 ` [PATCH v1 4/5] ethdev: " Ankur Dwivedi
2023-02-09 14:13 ` Ferruh Yigit
2023-02-09 13:30 ` [PATCH v1 5/5] eventdev: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 0/5] " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 1/5] mempool: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 2/5] cryptodev: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 3/5] eal: " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 4/5] ethdev: " Ankur Dwivedi
2023-02-10 14:19 ` David Marchand
2023-02-13 8:14 ` [EXT] " Ankur Dwivedi
2023-02-10 10:34 ` [PATCH v2 5/5] eventdev: " Ankur Dwivedi
2023-02-10 13:08 ` Jerin Jacob
2023-02-15 9:42 ` [PATCH v3 0/5] " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 1/5] mempool: " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 2/5] cryptodev: " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 3/5] eal: " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 4/5] ethdev: " Ankur Dwivedi
2023-02-15 9:42 ` [PATCH v3 5/5] eventdev: " Ankur Dwivedi
2023-02-20 14:39 ` [PATCH v3 0/5] " Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1OkLiu4WyJvM6Ms1Yf1TxjHQxODRktpGeq2YkGpkP9Qow@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=adwivedi@marvell.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).