From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4B11D41C5B; Fri, 10 Feb 2023 06:44:51 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D9D3F40EE6; Fri, 10 Feb 2023 06:44:50 +0100 (CET) Received: from mail-vs1-f54.google.com (mail-vs1-f54.google.com [209.85.217.54]) by mails.dpdk.org (Postfix) with ESMTP id 393D840EE3 for ; Fri, 10 Feb 2023 06:44:49 +0100 (CET) Received: by mail-vs1-f54.google.com with SMTP id l8so4524834vsm.11 for ; Thu, 09 Feb 2023 21:44:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=coAdBtZgalB3VFifr80fKAKkEL1HdFCsxzb3AtgHbdE=; b=A42q3a4NPvgTuC+6YEwHSk0QLB2KXR15DqujrZBqP0ruDOGJQMD9uCZg8kDn5A7UOe SUZU2GpAy5dJKAGnhmTr3yt//f2iePK2JAbGAgGDur9+owbGf0ljYIrQchRpPRRN579V YZpn/eUe+cijsoQQROLzjeZ5PpGhBJ1+x8j8AhWTNszF6cbw4ipfT65xpUgE6clHeeXl RHZNghUHEof2mhHscJsXWZeuFGFkMypYiBYV1L//R+cdSM6e5fl8FgL9x2uWGJbUaJvg jp6IRbesmykoPJ9bUtYVj9p+6YYf6BEccYpYtr0I9p8C6XFfr5k0aPT85PPl/3p+4E/W 1vdw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=coAdBtZgalB3VFifr80fKAKkEL1HdFCsxzb3AtgHbdE=; b=X59QvA/QFAsf+63dBJ+Ji97L1mVIGzcWpbwR7UlRGeVkrqdCUXzxhhZKhTObvhRRLG mYC66EPEIpu/qDS+TYXPffmwPdcr/XdfqxtdI0DocxXVZ+/F9dVGcquGHTmxD83rAjnZ zxau621O7mmVjvc6BryNTdu6sJmKXx5Yp4xhQZOT3P97vgELmHqhgCEZWOhpVNIZ7wgg NLn8edzMFDjj+xZAsQfr3je2qKksdsvzfO0pHAfftTk6WZMAydPguJfsPnmpcQhM9sa/ BWUpzrCKvZbfqDJorEkphTILjoEqSRb3D3XkARKI3FUzsMaSCVhneafe/77HDQa0taBp TOJg== X-Gm-Message-State: AO0yUKX2VjODFRIhh8UNREL6Hhls051zh1GwR+nZ7pnSNuklxBkH1k0w Y72HMiW/Upahqm6WyDZLoqK3RyXiwn1Py/pOlMc= X-Google-Smtp-Source: AK7set/Da/K1q1MpfGxzIfy0WhObgW+NEECpm3t1i5AjO6gQqPanmchL1CyEi9VwnK/AAiybkgjZBhBCEF4WhutZL0k= X-Received: by 2002:a05:6102:214f:b0:411:b561:b3a with SMTP id h15-20020a056102214f00b00411b5610b3amr2348343vsg.66.1676007888545; Thu, 09 Feb 2023 21:44:48 -0800 (PST) MIME-Version: 1.0 References: <20230209133019.933380-1-adwivedi@marvell.com> <20230209133019.933380-2-adwivedi@marvell.com> In-Reply-To: <20230209133019.933380-2-adwivedi@marvell.com> From: Jerin Jacob Date: Fri, 10 Feb 2023 11:14:21 +0530 Message-ID: Subject: Re: [PATCH v1 1/5] mempool: remove internal tracepoints from version map To: Ankur Dwivedi Cc: dev@dpdk.org, thomas@monjalon.net, david.marchand@redhat.com, ferruh.yigit@amd.com, jerinj@marvell.com Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 9, 2023 at 7:00 PM Ankur Dwivedi wrote: > > The file rte_mempool_trace.h contains tracepoints which are internal to the > mempool library. This file is renamed to mempool_trace.h, and is made an > internal header. The tracepoints in this file are removed from the > experimental section in version.map file. > > Signed-off-by: Ankur Dwivedi > @@ -47,22 +47,8 @@ EXPERIMENTAL { > __rte_mempool_trace_generic_get; > __rte_mempool_trace_get_bulk; > __rte_mempool_trace_get_contig_blocks; I think, FP ones also can be removed. Also, in one of the patch(may be eal). Update the doc https://doc.dpdk.org/guides/prog_guide/trace_lib.html The following note can be removed: The RTE_TRACE_POINT_REGISTER defines the placeholder for the rte_trace_point_t tracepoint object. The user must export a __ symbol in the library .map file for this tracepoint to be used out of the library, in shared builds. For example, __app_trace_string will be the exported symbol in the above example. > - __rte_mempool_trace_create; > - __rte_mempool_trace_create_empty; > - __rte_mempool_trace_free; > - __rte_mempool_trace_populate_iova; > - __rte_mempool_trace_populate_virt; > - __rte_mempool_trace_populate_default; > - __rte_mempool_trace_populate_anon; > - __rte_mempool_trace_cache_create; > - __rte_mempool_trace_cache_free; > __rte_mempool_trace_default_cache; > - __rte_mempool_trace_get_page_size; > __rte_mempool_trace_cache_flush; > - __rte_mempool_trace_ops_populate; > - __rte_mempool_trace_ops_alloc; > - __rte_mempool_trace_ops_free; > - __rte_mempool_trace_set_ops_byname; > }; > > INTERNAL { > -- > 2.25.1 >