From: Jerin Jacob <jerinjacobk@gmail.com>
To: Rasesh Mody <rmody@marvell.com>
Cc: dpdk-dev <dev@dpdk.org>, Jerin Jacob <jerinj@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>,
Stephen Hemminger <stephen@networkplumber.org>,
GR-Everest-DPDK-Dev <GR-Everest-DPDK-Dev@marvell.com>,
dpdk stable <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix to set stripped flag for VLAN packet
Date: Wed, 29 Jan 2020 19:47:51 +0530 [thread overview]
Message-ID: <CALBAE1OoE4x3wJuNkhXVEaNAaO=bqf6s8DofLUEBhwnE2=pnqg@mail.gmail.com> (raw)
In-Reply-To: <20200129014313.18108-1-rmody@marvell.com>
On Wed, Jan 29, 2020 at 7:13 AM Rasesh Mody <rmody@marvell.com> wrote:
>
> For VLAN packet the tci is saved in rx_mb->vlan_tci, however the
> STRIPPED offload flag is not set along with PKT_RX_VLAN flag.
> Set the PKT_RX_VLAN_STRIPPED flag as well.
>
> Fixes: 380a7aab1ae2 ("mbuf: rename deprecated VLAN flags")
> Fixes: b37b528d957c ("mbuf: add new Rx flags for stripped VLAN")
> Cc: stable@dpdk.org
> Signed-off-by: Rasesh Mody <rmody@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/net/bnx2x/bnx2x_rxtx.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnx2x/bnx2x_rxtx.c b/drivers/net/bnx2x/bnx2x_rxtx.c
> index ae97dfee36..ea2b53dff8 100644
> --- a/drivers/net/bnx2x/bnx2x_rxtx.c
> +++ b/drivers/net/bnx2x/bnx2x_rxtx.c
> @@ -414,7 +414,7 @@ bnx2x_recv_pkts(void *p_rxq, struct rte_mbuf **rx_pkts, uint16_t nb_pkts)
> */
> if (cqe_fp->pars_flags.flags & PARSING_FLAGS_VLAN) {
> rx_mb->vlan_tci = cqe_fp->vlan_tag;
> - rx_mb->ol_flags |= PKT_RX_VLAN;
> + rx_mb->ol_flags |= PKT_RX_VLAN | PKT_RX_VLAN_STRIPPED;
> }
>
> rx_pkts[nb_rx] = rx_mb;
> --
> 2.18.0
>
prev parent reply other threads:[~2020-01-29 14:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 1:43 Rasesh Mody
2020-01-29 14:17 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CALBAE1OoE4x3wJuNkhXVEaNAaO=bqf6s8DofLUEBhwnE2=pnqg@mail.gmail.com' \
--to=jerinjacobk@gmail.com \
--cc=GR-Everest-DPDK-Dev@marvell.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=rmody@marvell.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).