From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BE212A0353; Thu, 24 Feb 2022 06:23:17 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4D1314114D; Thu, 24 Feb 2022 06:23:17 +0100 (CET) Received: from mail-io1-f46.google.com (mail-io1-f46.google.com [209.85.166.46]) by mails.dpdk.org (Postfix) with ESMTP id 8548040E5A for ; Thu, 24 Feb 2022 06:23:15 +0100 (CET) Received: by mail-io1-f46.google.com with SMTP id w7so1476535ioj.5 for ; Wed, 23 Feb 2022 21:23:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2SGXAED3tgKjmh3mWqrGJdNXk+M7ArZg50vZ13dOtqs=; b=U7iwiZVUi6CH9+WzSiIIOO3rOKP+QC1Jaomzfw4q5AieckUA96Ym6MRtEVPEDv3h50 Yi3RkI/+1dpBERNxpLx4FBprMbLWrmWsY2AuC4wP7dz5m0CC3EX876puwdu8Dtxyr8C4 /RB1uTiqNUoUXSA+EborvP3qOh2bAAWov0JWmuKi/Un7ORidFsgM1/x4VDy2/pz4En4d SD+QZUR1Go8cbD9w8EoVR4tg87TgfmrO5fWuYSkd3BFP8b5k8TO2ed1/wCtFKbO8xeFz lDqZ24XPvOTfLcfJkyCcnCesDGzAHMYBZ4nlAC8hbnaOJGc0r0Esqfqcj78BpeD09QBy LDMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2SGXAED3tgKjmh3mWqrGJdNXk+M7ArZg50vZ13dOtqs=; b=Dyzl3xHHfFLVcu3M02XSMyU9AW9M3K/QRw0iyoJYvy3ndDAVFyfLgc2ujporL9qLvy MH3CDY2eeofNa5fLFz2gpX42/6ONPYPmLa/yTvEF0L4PcXNME8XSfXq/YTkaI3ZqvUhR WSts9/DMIpSm2dM/D6D//NafNP4REHizFSckU47Z00ryLeTVaS1L3WZC8srJ2HkezIXS /eGjYzl1Dis7Aqn156clZwDi5F8z6osDjB4f6icFPXoSTb0af+JBjblcDuKdLHMHOUyR gWuvDEJ9uYBV+B3yD4O47agfvyNhj8sIDCH6HSsHgZJAN9pJmJT6WEwLam1sKC19giRi vBrw== X-Gm-Message-State: AOAM533wFIvWOZ3/l746s5twK032YEZ0CG6mGWZqr4KgLIC9mGRKFhz1 6ua4BsUm/5IbVJcJYodBoyWQFSb9KYDCHTGjUwwNJLcT1dBFgw== X-Google-Smtp-Source: ABdhPJyPS9bFQFHk8GGLRb1KHzuYNeZE8nR6HgJ93ubl9fmd9o8G/Iiq2n85rWR6CXHZMC5M6x3IFeXjSc7WdiHNIHU= X-Received: by 2002:a6b:ce01:0:b0:610:8f2:3b7 with SMTP id p1-20020a6bce01000000b0061008f203b7mr819039iob.25.1645680194957; Wed, 23 Feb 2022 21:23:14 -0800 (PST) MIME-Version: 1.0 References: <20220223073443.647695-1-ganapati.kundapura@intel.com> In-Reply-To: From: Jerin Jacob Date: Thu, 24 Feb 2022 10:52:48 +0530 Message-ID: Subject: Re: [PATCH v1] eventdev/crypto_adapter: remove logically dead code To: "Gujjar, Abhinandan S" Cc: "Kundapura, Ganapati" , "Jayatheerthan, Jay" , "dev@dpdk.org" Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Thu, Feb 24, 2022 at 8:41 AM Gujjar, Abhinandan S wrote: > > Acked-by: Abhinandan Gujjar Applied to dpdk-next-net-eventdev/for-main. Thanks > > > -----Original Message----- > > From: Kundapura, Ganapati > > Sent: Wednesday, February 23, 2022 1:05 PM > > To: Jayatheerthan, Jay ; > > jerinjacobk@gmail.com; Gujjar, Abhinandan S > > ; dev@dpdk.org > > Subject: [PATCH v1] eventdev/crypto_adapter: remove logically dead code > > > > eca_cryptodev_cdev_flush() is internal function and called with valid range > > of cdevs. > > > > crypto_cdev_info structure is allocated at adapter creation time and > > retrieved from the adapter for a valid cdevs which cannot be NULL and > > hence no need for NULL check. > > > > Fixes: 2ae84b39ae7b ("eventdev/crypto: store operations in circular buffer") > > > > Signed-off-by: Ganapati Kundapura > > > > diff --git a/lib/eventdev/rte_event_crypto_adapter.c > > b/lib/eventdev/rte_event_crypto_adapter.c > > index 0b484f3..f624f50 100644 > > --- a/lib/eventdev/rte_event_crypto_adapter.c > > +++ b/lib/eventdev/rte_event_crypto_adapter.c > > @@ -529,10 +529,8 @@ eca_crypto_cdev_flush(struct > > event_crypto_adapter *adapter, > > uint16_t qp; > > > > curr_dev = &adapter->cdevs[cdev_id]; > > - if (unlikely(curr_dev == NULL)) > > - return 0; > > - > > dev = rte_cryptodev_pmd_get_dev(cdev_id); > > + > > for (qp = 0; qp < dev->data->nb_queue_pairs; qp++) { > > > > curr_queue = &curr_dev->qpairs[qp]; > > -- > > 2.6.4 >