From: Jerin Jacob <jerinjacobk@gmail.com>
To: Sunil Kumar Kori <skori@marvell.com>,
Ferruh Yigit <ferruh.yigit@intel.com>
Cc: Jerin Jacob <jerinj@marvell.com>,
Nithin Dabilpuram <ndabilpuram@marvell.com>,
Kiran Kumar K <kirankumark@marvell.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/octeontx2: fix minimum length to SMQ config
Date: Mon, 11 May 2020 15:10:29 +0530 [thread overview]
Message-ID: <CALBAE1OpJ3Q5Mfu14p-31oMrcSe8BxDdAwZuwojygKN6KQQNDw@mail.gmail.com> (raw)
In-Reply-To: <20200511062156.15534-1-skori@marvell.com>
On Mon, May 11, 2020 at 11:52 AM Sunil Kumar Kori <skori@marvell.com> wrote:
>
> NIX exposes NIX_AF_SMQ(0..511)_CFG to configure minimum length
> of the packet which is being used for zero padding if packet is
> less than configured value.
>
> Setting it to default minimum length i.e. 60 bytes.
>
> Fixes: ec8ddd4fb1be ("net/octeontx2: restructure TM helper functions")
>
> Signed-off-by: Sunil Kumar Kori <skori@marvell.com>
Acked-by: Jerin Jacob <jerinj@marvell.com>
Applied to dpdk-next-net-mrvl/master. Thanks
> ---
> drivers/net/octeontx2/otx2_tm.c | 9 ++++++---
> 1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/octeontx2/otx2_tm.c b/drivers/net/octeontx2/otx2_tm.c
> index b57e10f74..8ed059549 100644
> --- a/drivers/net/octeontx2/otx2_tm.c
> +++ b/drivers/net/octeontx2/otx2_tm.c
> @@ -555,10 +555,13 @@ populate_tm_reg(struct otx2_eth_dev *dev,
> switch (hw_lvl) {
> case NIX_TXSCH_LVL_SMQ:
>
> - /* Set xoff which will be cleared later */
> + /* Set xoff which will be cleared later and minimum length
> + * which will be used for zero padding if packet length is
> + * smaller
> + */
> reg[k] = NIX_AF_SMQX_CFG(schq);
> - regval[k] = BIT_ULL(50);
> - regval_mask[k] = ~BIT_ULL(50);
> + regval[k] = BIT_ULL(50) | NIX_MIN_HW_FRS;
> + regval_mask[k] = ~(BIT_ULL(50) | 0x7f);
> k++;
>
> /* Parent and schedule conf */
> --
> 2.17.1
>
prev parent reply other threads:[~2020-05-11 9:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-11 6:21 Sunil Kumar Kori
2020-05-11 9:40 ` Jerin Jacob [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CALBAE1OpJ3Q5Mfu14p-31oMrcSe8BxDdAwZuwojygKN6KQQNDw@mail.gmail.com \
--to=jerinjacobk@gmail.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=skori@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).